Francesco Romani
23147ff4b3
e2e: node: devplugin: tolerate node readiness flip
...
In the AfterEach check of the e2e node device plugin tests,
the tests want really bad to clean up after themselves:
- delete the sample device plugin
- restart again the kubelet
- ensure that after the restart, no stale sample devices
(provided by the sample device plugin) are reported anymore.
We observed that in the AfterEach block of these e2e tests
we have quite reliably a flip/flop of the kubelet readiness
state, possibly related to a race with/ a slow runtime/PLEG check.
What happens is that the kubelet readiness state is true,
but goes false for a quick interval and then goes true again
and it's pretty stable after that (observed adding more logs
to the check loop).
The key factor here is the function `getLocalNode` aborts the
test (as in `framework.ExpectNoError`) if the node state is
not ready. So any occurrence of this scenario, even if it
is transient, will cause a test failure. I believe this will
make the e2e test unnecessarily fragile without making it more
correct.
For the purpose of the test we can tolerate this kind of glitches,
with kubelet flip/flopping the ready state, granted that we meet
eventually the final desired condition on which the node reports
ready AND reports no sample devices present - which was the condition
the code was trying to check.
So, we add a variant of `getLocalNode`, which just fetches the
node object the e2e_node framework created, alongside to a flag
reporting the node readiness. The new helper does not make
implicitly the test abort if the node is not ready, just bubbles
up this information.
Signed-off-by: Francesco Romani <fromani@redhat.com>
2022-05-16 14:22:25 +02:00
Francesco Romani
56c539bff0
e2e: node: deviceplug: deepcopy the pod dev template
...
Let's avoid unexpected side effects
Signed-off-by: Francesco Romani <fromani@redhat.com>
2022-05-16 14:22:24 +02:00
Kubernetes Prow Robot
22a21f974f
Merge pull request #110063 from wojtek-t/cleanup_testing_namespaces_in_integration
...
Simplify Create/Delete-TestingNamespace functions
2022-05-16 01:50:18 -07:00
Wojciech Tyczyński
deef9e40de
Simplify Create/Delete-TestingNamespace functions
2022-05-15 23:06:26 +02:00
Kubernetes Prow Robot
69cabe778b
Merge pull request #109733 from terloo/master
...
Unified v1/event NewREST function with other
2022-05-15 06:06:16 -07:00
terloo
8d09083101
Unified v1/event NewREST function with other
2022-05-15 12:44:59 +08:00
Kubernetes Prow Robot
dfee09a27d
Merge pull request #109651 from ash2k/ash2k/spdy-cleanup
...
Fix issues in SPDY RoundTripper
2022-05-14 21:00:16 -07:00
Kubernetes Prow Robot
8fb2b901ad
Merge pull request #110050 from cpanato/prombot
...
Update publishing-bot rules for Go 1.17.10
2022-05-14 14:57:17 -07:00
Kubernetes Prow Robot
8dc9bd3efb
Merge pull request #110021 from RaunakShah/updatecrd
...
Update snapshot CRDs to v6 in add on folder
2022-05-14 10:59:17 -07:00
cpanato
0f553fcda2
Update publishing-bot rules for Go 1.17.10
...
Signed-off-by: cpanato <ctadeu@gmail.com>
2022-05-14 15:25:44 +02:00
Kubernetes Prow Robot
b11ac8be28
Merge pull request #110047 from pacoxu/kubeadm-docker
...
kubeadm: container runtime is by default docker in kubelet v1.23
2022-05-14 05:01:17 -07:00
Paco Xu
ab51557a0c
kubeadm: container runtime is by default docker in kubelet v1.23
...
- can be removed in v1.26
2022-05-14 18:31:48 +08:00
Kubernetes Prow Robot
28ab02df19
Merge pull request #110043 from cpanato/go118
...
[GO] Update Go to 1.18.2
2022-05-14 00:37:18 -07:00
Raunak Pradip Shah
43bd5f8648
Add OneOf
2022-05-14 11:54:37 +05:30
cpanato
90871a0b2f
Update Go to 1.18.2
...
Signed-off-by: cpanato <ctadeu@gmail.com>
2022-05-14 00:57:15 +02:00
Kubernetes Prow Robot
bbdcce6a9e
Merge pull request #109880 from Jefftree/patch-4
...
Remove warning log for crd merging
2022-05-13 15:31:54 -07:00
Kubernetes Prow Robot
3441850891
Merge pull request #109987 from gnufied/fix-ephemeral-volume-expansion
...
Fix resizing of ephemeral volumes
2022-05-13 14:24:06 -07:00
Kubernetes Prow Robot
00f829b352
Merge pull request #109824 from my-git9/kubectlurl
...
update kubectl doc url
2022-05-13 14:23:55 -07:00
Kubernetes Prow Robot
47bb8c6d0c
Merge pull request #108777 from pjo256/recursive-rollout-status
...
feat(kubectl rollout): support multiple resources for rollout status
2022-05-13 13:15:55 -07:00
Jefftree
fad5353ef8
Integration test for openapi scale & status
2022-05-13 11:45:31 -07:00
Kubernetes Prow Robot
30adcd0b6c
Merge pull request #110025 from stevekuznetsov/skuznets/skuznets-reviews-storage
...
apiserver/storage: add myself to the reviewers list
2022-05-13 08:52:01 -07:00
Kubernetes Prow Robot
f7857f0846
Merge pull request #109830 from AllenZMC/fix_test
...
fix defer in loop, maybe resource leak
2022-05-13 08:51:49 -07:00
Kubernetes Prow Robot
1a6adee3d6
Merge pull request #109753 from matthyx/109577
...
do not install docker with curl
2022-05-13 07:33:49 -07:00
Matthias Bertschy
d42321dc05
recommend containerd instead of docker, cleanup
2022-05-13 15:25:15 +02:00
Kubernetes Prow Robot
9720d130e4
Merge pull request #110030 from wojtek-t/clean_shutdown_2
...
Minor cleanups in integration test shutdown
2022-05-13 03:43:48 -07:00
Wojciech Tyczyński
492e7111a0
Minor cleanup of apply tests
2022-05-13 11:37:22 +02:00
Wojciech Tyczyński
89549142c0
Stop leaking apiserver in tracing test
2022-05-13 09:47:24 +02:00
Kubernetes Prow Robot
9d85e18ec0
Merge pull request #110022 from neolit123/1.25-handle-kubelet-flags-without-dockershim
...
kubeadm: perform dockershim cleanup for 1.25
2022-05-13 00:14:00 -07:00
Kubernetes Prow Robot
340ba56567
Merge pull request #109989 from tallclair/image-type
...
Use typed ImageID for imageutils images
2022-05-13 00:13:48 -07:00
Steve Kuznetsov
0d616946c0
apiserver/storage: add myself to the reviewers list
...
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
2022-05-12 15:40:45 -07:00
Kubernetes Prow Robot
2d08104ee3
Merge pull request #110013 from enj/enj/i/remove_azure_gcp_auth_plugins
...
Remove gcp and azure auth plugins
2022-05-12 14:57:55 -07:00
Kubernetes Prow Robot
46469f62db
Merge pull request #109971 from stevekuznetsov/skuznets/isolate-continue
...
storage: move continue token definition to storage
2022-05-12 14:57:48 -07:00
Kubernetes Prow Robot
0e567664ed
Merge pull request #110009 from azylinski/fix-create-cr-scope
...
Fix requests scope classification
2022-05-12 13:47:48 -07:00
Jeffrey Ying
b1e9162182
Remove warning log for merging meta and scale type
2022-05-12 13:11:45 -07:00
Kubernetes Prow Robot
1be1ec4aa3
Merge pull request #109970 from stevekuznetsov/skuznets/isolate-versioner
...
storage: move the APIObjectVersioner definition to storage
2022-05-12 12:32:44 -07:00
Kubernetes Prow Robot
6e04ca634d
Merge pull request #109729 from MikeSpreitzer/wrap-weighted-histograms
...
Wrap weighted histograms
2022-05-12 12:32:32 -07:00
Steve Kuznetsov
e50cb6c8d3
storage: move test utiltiies out of test files
...
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
2022-05-12 11:52:40 -07:00
Lubomir I. Ivanov
6efdcfd15b
kubeadm: perform dockershim cleanup for 1.25
...
Given kubeadm 1.25 only supports kubelet 1.25 and 1.24,
1.23 related logic around dockershim can be removed.
- Don't clean the directories
/var/lib/dockershim, /var/runkubernetes, /var/lib/cni
- Pass the CRISocket directly to the kubelet
--container-runtime-endpoint flag without extra handling
of dockershim
- No longer apply the --container-runtime=remote flag
as that is the only possible value in 1.24 and 1.25
- Update unit tests
Note: we are still passing --pod-infra-container-image
to avoid the pause image to be GCed by the kubelet.
2022-05-12 21:38:17 +03:00
Raunak Pradip Shah
20e77209f1
Update snapshot CRDs to v6
2022-05-12 23:47:39 +05:30
Tim Allclair
ab29782d24
Use typed ImageID for imageutils images
2022-05-12 08:51:07 -07:00
Kubernetes Prow Robot
dd1a7893d4
Merge pull request #109997 from aojea/downward_e2e
...
don't skip Feature:EphemeralStorage based on skipper
2022-05-12 08:09:26 -07:00
Kubernetes Prow Robot
3688442c75
Merge pull request #108115 from haircommander/cadvisor-pod-stats
...
kubelet/stats: update cadvisor stats provider with new log location
2022-05-12 08:09:13 -07:00
Mike Spreitzer
d23254b7ea
More revisions after review
2022-05-12 10:27:58 -04:00
Monis Khan
916cf16cf1
Remove gcp and azure auth plugins
...
Signed-off-by: Monis Khan <mok@vmware.com>
2022-05-12 10:06:54 -04:00
Kubernetes Prow Robot
976a940f4a
Merge pull request #109978 from wojtek-t/remove_storage_tracking
...
Cleanup no-longer used storage cleanup method
2022-05-12 06:31:25 -07:00
Kubernetes Prow Robot
7e083ba2a0
Merge pull request #109968 from kerthcet/feature/optimize-apifield-comment
...
cleanup: modify the comments of NodeInclusionPolicy
2022-05-12 06:31:14 -07:00
Artur Żyliński
690c912369
Fix requests scope classification
...
create (POST) custom resources should be scope:resource
2022-05-12 14:27:51 +02:00
Mike Spreitzer
c87cd36d3e
Finish making Gauge and TimingHistogram implement the same interface
2022-05-12 08:00:54 -04:00
Kubernetes Prow Robot
076168b84d
Merge pull request #109990 from tnqn/fix-netpol-error
...
Correct errors in the netpol test suite
2022-05-12 03:43:26 -07:00
Kubernetes Prow Robot
9254f94da1
Merge pull request #109413 from lzhecheng/flexible-internal-static-ip
...
[e2e][azure] Make internalStaticIP flexible
2022-05-12 03:43:14 -07:00