Commit Graph

98676 Commits

Author SHA1 Message Date
Uwe Krueger
2355ceb79a simplier fix + test for race condition 2021-03-06 14:42:59 +01:00
Uwe Krueger
932f98acaf add comment describing the race condition + TODO for appropriate test 2021-03-05 17:59:36 +01:00
Uwe Krueger
d8ee8e427e fix sync problem in streamwatcher
The streamwatcher has a synchronization problem that may lead to
a go routine blocking forever when closing a stream watch.

This occasionally happens, when informers are cancelled together with the
watch request using the stop channel, which leads to an increaing
number of blocked go routines, if imformers are dynamicaly created and deleted
again.

The function `receive` checks under a lock whether the watch has been stopped,
before an error is reported to the result channel.
The problem here is, that in between the watcher might be stopped by
calling the `Stop` method. In the actual code this is done by the
`cache.Reflector` using the streamwatcher by a defer which is executed after
the caller already stopped reading from the result channel.
As a result the stopping flag might be set after the check
and trying to send the error event blocks this send operation forever,
because there will never be a receiver again.

The fix introduces a dedicated local stop channel that is closed by the
`Stop` method and used in a select statement together with the send
operation to finally abort the loop.
2021-03-05 17:14:32 +01:00
Kubernetes Prow Robot
8306eeab75
Merge pull request #99837 from aojea/revertgce
Revert "fix a bug where only service with less than 100 ports can hav…
2021-03-05 07:46:22 -08:00
Kubernetes Prow Robot
feab32b220
Merge pull request #99817 from liggitt/zero-value
Fix zero-value custom resource validation with go1.16
2021-03-05 06:44:23 -08:00
Kubernetes Prow Robot
55f255208a
Merge pull request #83730 from claudiubelu/windows/containerd-etc-hosts
Windows: Fixes /etc/hosts file mounting support for containerd
2021-03-05 05:08:22 -08:00
Kubernetes Prow Robot
9067b5691d
Merge pull request #97818 from damemi/remove-util-node-dep
Scheduler: remove direct dependency for k8s.io/kubernetes/pkg/util/node
2021-03-05 04:06:32 -08:00
Kubernetes Prow Robot
f2c189b54f
Merge pull request #78648 from mrkm4ntr/unify-is-ephemeral-volume
Unify determination of whether a volume is ephemeral
2021-03-05 04:06:21 -08:00
Antonio Ojea
e08a46cafa Revert "fix a bug where only service with less than 100 ports can have GCE load balancer"
This reverts commit be7ee01f2f.
2021-03-05 12:30:43 +01:00
Kubernetes Prow Robot
066600f105
Merge pull request #99525 from kagaya85/fix-staticcheck
fix staticcheck for k8s.io/apiserver/pkg/endpoints
2021-03-05 01:56:34 -08:00
Kubernetes Prow Robot
7863e8f891
Merge pull request #99248 from pandaamanda/kubelet_duplicate_default_value
remove duplicate default message for some flag
2021-03-05 01:56:22 -08:00
Kubernetes Prow Robot
66cbf0196b
Merge pull request #98277 from XudongLiuHarold/add-loadbalancerclass-field
Add LoadBalancerClass field in service
2021-03-04 23:56:21 -08:00
Kubernetes Prow Robot
7a49140145
Merge pull request #98127 from mortent/AddConditionsToPDBs
Add conditions to PDB status
2021-03-04 22:30:21 -08:00
Shintaro Murakami
fe7a862c2d Unify determination of whether a volume is ephemeral 2021-03-05 14:49:09 +09:00
Kubernetes Prow Robot
96be00df69
Merge pull request #99749 from pacoxu/nodecache-1.17.0
update node local dns to 1.17.0 for IPv6 support/hosts/trace plugins
2021-03-04 20:32:43 -08:00
Kubernetes Prow Robot
af703cf86c
Merge pull request #99743 from freehan/firewall-fix
fix a bug where only service with less than 100 ports can have GCE LB
2021-03-04 20:32:34 -08:00
Kubernetes Prow Robot
d8311ea0ad
Merge pull request #99703 from claudiubelu/tests/new-httpd-nginx
tests: Uses newly promoted httpd and nginx images
2021-03-04 20:32:21 -08:00
Jordan Liggitt
b02b3c5828 Add test for zero-value custom resource validation 2021-03-04 22:57:26 -05:00
Kubernetes Prow Robot
31fe241c6e
Merge pull request #99456 from dabaooline/dabaooline-patch-1
Update Staging's README.md
2021-03-04 19:32:33 -08:00
Kubernetes Prow Robot
6499f20d21
Merge pull request #98749 from pandaamanda/kubectl_patch_error
fix kubectl patch command error message
2021-03-04 19:32:21 -08:00
xiongzhongliang
99f0369f9d fix kubectl patch command error message 2021-03-05 17:05:10 +08:00
Jordan Liggitt
5515157f82 Update k8s.io/kube-openapi 2021-03-04 22:15:21 -05:00
Morten Torkildsen
b08eb95168 generated 2021-03-04 19:03:00 -08:00
Morten Torkildsen
1e2a7f381f Add conditions to PDB status 2021-03-04 18:52:02 -08:00
Kubernetes Prow Robot
466e730259
Merge pull request #99816 from BenTheElder/no-shellcheck-failures
banish .shellcheck_failures
2021-03-04 18:35:12 -08:00
Kubernetes Prow Robot
9cea3f88ef
Merge pull request #99810 from BenTheElder/fix-junit-deps
disable colors in zeitgeist so as not to break shell2junit
2021-03-04 18:35:03 -08:00
Kubernetes Prow Robot
292bdbf8a6
Merge pull request #99797 from voutcn/patch-1
Fix the image path of resource-consumer in README.
2021-03-04 18:34:56 -08:00
Kubernetes Prow Robot
110b9272f2
Merge pull request #99782 from liggitt/race-tests
Fix or remove tests that don't work in race mode
2021-03-04 18:34:48 -08:00
Kubernetes Prow Robot
48f1b8fb28
Merge pull request #99293 from chymy/e2e-kubectl
Remove unused field in test/e2e/kubectl/kubectl.go
2021-03-04 18:34:41 -08:00
Kubernetes Prow Robot
a4025a8462
Merge pull request #98986 from gjkim42/fix-runtime-assert
kubelet: Make the test fail if (*FakeRuntime).Assert fails
2021-03-04 18:34:33 -08:00
Kubernetes Prow Robot
4eea987722
Merge pull request #98590 from chymy/kctl-toppod-0130
Condition is always 'false' because 'err' is always 'nil' in top_pod.go
2021-03-04 18:34:21 -08:00
Kubernetes Prow Robot
379773630f
Merge pull request #97037 from neiljerram/calico-ip-autodetect
Calico: set IP=autodetect so preempted nodes learn new IP
2021-03-04 17:32:21 -08:00
Xudong Liu
72da0b1bb0 Add LoadBalancerClass field in service
KEP-1959: https://github.com/kubernetes/enhancements/tree/master/keps/sig-cloud-provider/1959-service-lb-class-field
2021-03-04 17:11:50 -08:00
Benjamin Elder
60d50f4ce8 banish .shellcheck_failures
we've eliminated these. don't allow any regression.
this should also be much faster now.
2021-03-04 16:32:17 -08:00
Kubernetes Prow Robot
4293a6329b
Merge pull request #99805 from bobbypage/shutdown-test
Fixes to node shutdown e2e test
2021-03-04 16:06:35 -08:00
Kubernetes Prow Robot
9f451c03e9
Merge pull request #97979 from danwinship/pod-ip-family
Make podIPs order match node IP family preference
2021-03-04 16:06:22 -08:00
Benjamin Elder
fbfbe289c4 use sed to drop escape codes from zeitgeist output 2021-03-04 14:59:52 -08:00
Kubernetes Prow Robot
ba0817b746
Merge pull request #99789 from alculquicondor/indexed-job-unit
Test for removal of invalid and repeated indexes
2021-03-04 14:41:29 -08:00
Kubernetes Prow Robot
2975ef7c55
Merge pull request #99737 from alculquicondor/indexed-job-e2e
Integration and e2e tests for Indexed job
2021-03-04 14:41:21 -08:00
Kubernetes Prow Robot
a6bfc7d7a9
Merge pull request #99646 from rajansandeep/remove-kube-dns
[kubeadm]: Remove the deprecated kube-dns as an option in kubeadm
2021-03-04 14:41:12 -08:00
Kubernetes Prow Robot
d1fb9fda24
Merge pull request #99523 from gavinfish/sched-nodeaff-todo
Scheduler: remove outdated TODO in node_affinity.go
2021-03-04 14:41:03 -08:00
Kubernetes Prow Robot
03d242665d
Merge pull request #99012 from jpbetz/apply-client-go-builders2
Apply Builders for client-go's typed client
2021-03-04 14:40:55 -08:00
Kubernetes Prow Robot
a2157b36b7
Merge pull request #98806 from rikatz/remove-extension-prune
Remove extensions v1beta1 from addon manager and kubectl prune
2021-03-04 14:40:47 -08:00
Kubernetes Prow Robot
413ff6751b
Merge pull request #98365 from odinuge/cgroup-v2-systemd
Fix cgroup handling for systemd with cgroup v2
2021-03-04 14:40:34 -08:00
Kubernetes Prow Robot
ae4f2ac43d
Merge pull request #98018 from ii/service-status-life-cycle-test
Write Service Status Life Cycle test - +4 endpoint coverage
2021-03-04 14:40:22 -08:00
Benjamin Elder
c54bfc4adf disable colors in zeitgeist so as not to break shell2junit 2021-03-04 13:58:13 -08:00
Kubernetes Prow Robot
2d9cb74bc7
Merge pull request #99798 from freehan/test-fix
Mark ingress neg test as flaky
2021-03-04 13:40:14 -08:00
Kubernetes Prow Robot
4f1bf2558a
Merge pull request #99796 from swetharepakula/remove-nodeName-gate
Remove EndpointSliceNodeName feature gate logic
2021-03-04 13:40:04 -08:00
Kubernetes Prow Robot
d11582b44b
Merge pull request #99795 from robscott/endpointslice-ports-validation
Increasing maximum number of ports allowed in EndpointSlice
2021-03-04 13:39:56 -08:00
Kubernetes Prow Robot
68f48693c1
Merge pull request #99794 from robscott/windowsendpointsliceproxying-beta
Graduating WindowsEndpointSliceProxying feature gate to beta
2021-03-04 13:39:48 -08:00