Commit Graph

474 Commits

Author SHA1 Message Date
Tim Hockin
3f0e7e790b Less verbose logging for "normal" things.
Don't log things that we expect to happen every sync loop, unless the user
asks for --v > 0.
2014-06-24 22:05:25 -07:00
Daniel Smith
7403b2335c Merge pull request #240 from thockin/glog
Default --logtostderr=true
2014-06-24 21:40:17 -07:00
Tim Hockin
a570b81220 Default --logtostderr=true
This retains compatibility with existing logging to stderr, until we can agree
on log dirs for each cmd.
2014-06-24 21:29:53 -07:00
Daniel Smith
546600371e Merge pull request #221 from thockin/glog
Use glog for logging
2014-06-24 20:58:47 -07:00
Tim Hockin
9f9e75f508 Switch to glog for logging, bridge logging to glog.
1) imported glog to third_party (previous commit)
2) add support for third_party/update.sh to update just one pkg
3) search-and-replace:
  s/log.Printf/glog.Infof/
  s/log.Print/glog.Info/
  s/log.Fatalf/glog.Fatalf/
  s/log.Fatal/glog.Fatal/
4) convert glog.Info.*, err into glog.Error*

Adds some util interfaces to logging and calls them from each cmd, which
will set the default log output to write to glog.  Pass glog-wrapped
Loggers to etcd for logging.

Log files will go to /tmp - we should probably follow this up with a
default log dir for each cmd.

The glog lib is sort of weak in that it only flushes every 30 seconds, so
we spin up our own flushing goroutine.
2014-06-24 20:51:57 -07:00
Tim Hockin
381ac4328c bump(github.com/golang/glog): d1c4472bf2efd3826f2b5bdcc02d8416798d678c 2014-06-24 20:20:03 -07:00
brendandburns
b2a7d19798 Merge pull request #239 from jjhuff/dead_code
Remove extractMultipleFromReader and extractSingleFromReader.
2014-06-24 19:32:12 -07:00
Justin Huff
ddf0fd18f0 Remove extractMultipleFromReader and extractSingleFromReader. Unused now after improvements in #212 and #213 2014-06-24 18:59:57 -07:00
Daniel Smith
c3da356cd6 Merge pull request #237 from brendandburns/tests
Added some tests
2014-06-24 18:04:32 -07:00
brendandburns
8b44f34e0f Merge pull request #213 from lavalamp/fix_manifest
Better fix of #212
2014-06-24 17:42:22 -07:00
Brendan Burns
60ce1296d4 Added some tests 2014-06-24 17:41:30 -07:00
Daniel Smith
f7968ce00b Make integration test the manifest url feature. Make kubelet's docker pull command testable. 2014-06-24 16:57:35 -07:00
Daniel Smith
cfa1ef3c4c Merge pull request #229 from brendandburns/fix
Several small fixes.
2014-06-24 15:35:50 -07:00
brendandburns
19fa068de4 Merge pull request #232 from lavalamp/master
Make minion printing prettier; standardize on MinionList.Items
2014-06-24 15:34:06 -07:00
Brendan Burns
84e5c37f74 Several small fixes. 2014-06-24 15:30:14 -07:00
Daniel Smith
2cc038298b Make minion printing prettier; standardize on MinionList.Items like the other list types. 2014-06-24 15:29:17 -07:00
Daniel Smith
86b5cfd4ed Merge pull request #218 from thockin/logging
Logging cleanup in Kubelet
2014-06-24 15:20:20 -07:00
Daniel Smith
fd66a8b59b Readability fixes & address review comments. 2014-06-24 15:16:21 -07:00
Daniel Smith
6900431b13 Add kubelet testing to integration test. Test that kubelet makes the requested containers. Check that the url manifest feature works. 2014-06-24 15:14:40 -07:00
Daniel Smith
9d8a16f180 Make manifest url reader accept both single and multiple manifests. 2014-06-24 15:13:18 -07:00
Daniel Smith
e4c47f0219 Merge pull request #231 from brendandburns/hooks
Fixed the boilerplate hook to work on OS X, where apparently wc add's spaces
2014-06-24 15:12:25 -07:00
Daniel Smith
4f81008ab9 Merge pull request #230 from thockin/cleanups
Slightly friendlier pre-commit errors.
2014-06-24 15:11:08 -07:00
Brendan Burns
2c404aba0f Fixed the boilerplate hook to work on OS X, where apparently wc add's spaces 2014-06-24 15:02:48 -07:00
Tim Hockin
b6d5faf276 Slightly friendlier pre-commit errors.
Make the pre-commit check spit out cut-and-paste commands and be more
obvious about errors.  Tested by making an invalid change and observing the
message generated.
2014-06-24 15:01:08 -07:00
Daniel Smith
75e37c133f Merge pull request #228 from brendandburns/master
Remove an erroneous debug statement.
2014-06-24 14:04:30 -07:00
Tim Hockin
c705593b62 Logging cleanup in Kubelet
Make it easier to see the signal when looking at kubelet logs.  Make the
signal more consistent and legible.
2014-06-24 13:50:08 -07:00
Daniel Smith
cf041acc29 Merge pull request #227 from thockin/cleanups
Rename Kubelet.Client -> EtcdClient
2014-06-24 13:26:59 -07:00
Brendan Burns
20ba523266 Remove an erroneous debug statement. 2014-06-24 13:23:58 -07:00
Tim Hockin
7622bb871b Rename Kubelet.Client -> EtcdClient
All the other *Client members are so named.  Makes easier reading.
2014-06-24 13:17:38 -07:00
Daniel Smith
dec3e09aa7 Merge pull request #226 from gottwald/TestYAMLPrinter
Add test for YAMLPrinter
2014-06-24 13:16:51 -07:00
Ingo Gottwald
79a9e0d849 Add test for YAMLPrinter 2014-06-24 21:44:39 +02:00
Tim Hockin
aa4434c53b Merge pull request #225 from jjhuff/ignore_dotfiles
Ignore files that start with '.' when processing a config dir.
2014-06-24 12:26:31 -07:00
Justin Huff
4f714dd0fe Ignore files that start with '.' when processing a config dir. 2014-06-24 12:02:49 -07:00
Daniel Smith
568631e765 Merge pull request #217 from brendandburns/demo
Create a proxy server using cloudcfg.  Useful for demos
2014-06-24 12:01:04 -07:00
Daniel Smith
3813cfd1f5 Merge pull request #224 from lavalamp/fix
Fix duplicated path.
2014-06-24 11:53:39 -07:00
Daniel Smith
07a431f713 Fix duplicated path. 2014-06-24 11:51:14 -07:00
Brendan Burns
8b50e45dcc Update the proxy server. 2014-06-24 11:25:45 -07:00
Brendan Burns
5756189f0d Added a proxy server to cloudcfg 2014-06-24 11:15:08 -07:00
brendandburns
b94ceffbed Merge pull request #205 from lavalamp/api2
Small client refactor; interpret 202 responses
2014-06-24 11:12:10 -07:00
Daniel Smith
56bf47bbf8 Merge pull request #219 from thockin/netctr
Escape manifest IDs when hunting the network container.
2014-06-24 10:38:06 -07:00
Daniel Smith
175e998258 Fix nil/[]byte{} consistency, and other review comments. 2014-06-24 10:07:51 -07:00
Tim Hockin
8c2a8b65c3 Escape manifest IDs when hunting the network container.
This makes it possible to have manifests with _ in the ID.  I'm not sure we
want to allow this, but we do for now.  I hope to follow this up with a deeper
change to make this a bit more robust.
2014-06-24 09:52:43 -07:00
Daniel Smith
dccfe8046a Remove dead code 2014-06-24 09:38:22 -07:00
Daniel Smith
72809f8e67 catch 202 early 2014-06-24 09:38:22 -07:00
Daniel Smith
5ce54bb77b Use new method. 2014-06-24 09:38:22 -07:00
Daniel Smith
61a494d303 First step of combination. 2014-06-24 09:38:22 -07:00
brendandburns
e811e24b23 Merge pull request #216 from thockin/logging
Minor: log cleanups
2014-06-23 22:38:06 -07:00
Tim Hockin
60ad86c972 Minor: Log cleanups
Clean up log messages to be more obvious. Fix a typo (exit -> exist).
2014-06-23 22:11:18 -07:00
Daniel Smith
55be74ae36 Merge pull request #215 from thockin/cleanups
Clarify config file code to be clear that it handles directories, too.  ...
2014-06-23 21:28:30 -07:00
Tim Hockin
7218a4d165 Clarify config file code to be clear that it handles directories. ...
… Add a check for IsRegular() before reading a config path.  Add a comment
about exec.Command("hostname", "-f").
2014-06-23 21:14:15 -07:00