Commit Graph

6473 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
4891eaa3ad Merge pull request #77170 from smarterclayton/delay_queue_reentrant
DelayingQueue.ShutDown() should be reentrant
2019-05-17 20:26:34 -07:00
Kubernetes Prow Robot
df8e241fb9 Merge pull request #76346 from caesarxuchao/delete-admission-objects
Sending existing object to the webhook for the DELETE verb
2019-05-17 20:26:22 -07:00
Kubernetes Prow Robot
b6f51d16d8 Merge pull request #78041 from yastij/fix-lastTimeObserved
update LastObservedTime instead of eventTime
2019-05-17 18:57:54 -07:00
Kubernetes Prow Robot
7809732e30 Merge pull request #78040 from tedyu/evt-broadcast
Use lock in eventBroadcasterImpl#refreshExistingEventSeries
2019-05-17 18:57:42 -07:00
Kubernetes Prow Robot
0f8009b96d Merge pull request #78029 from liggitt/crd-watch
Terminate custom resource watches when storage is destroyed
2019-05-17 18:57:17 -07:00
Kubernetes Prow Robot
ddfa49b039 Merge pull request #77987 from apelisse/dont-fail-on-failures
fieldManager: Ignore conversion errors to internal types
2019-05-17 18:57:06 -07:00
Clayton Coleman
d2f7eb5235 DelayingQueue.ShutDown() should be reentrant
All queue ShutDown() calls should be able to be invoked multiple times.

```
Observed a panic: "close of closed channel" (close of closed channel)
/go/src/github.com/openshift/cluster-version-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:76
/go/src/github.com/openshift/cluster-version-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:65
/go/src/github.com/openshift/cluster-version-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:51
/usr/local/go/src/runtime/asm_amd64.s:573
/usr/local/go/src/runtime/panic.go:502
/usr/local/go/src/runtime/chan.go:333
/go/src/github.com/openshift/cluster-version-operator/vendor/k8s.io/client-go/util/workqueue/delaying_queue.go:137
```

Use sync.Once to guarantee a single close.
2019-05-17 16:56:30 -04:00
Jordan Liggitt
ea464235a8 Add CRD integration test for dropping watches 2019-05-17 13:34:15 -04:00
Yassine TIJANI
c6b224b16c update LastObservedTime instead of eventTime
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
2019-05-17 18:56:38 +02:00
Chao Xu
7bb4a3bace Run deleteValidation at the storage layer so that it will be retried on
conflict.

Adding unit test verify that deleteValidation is retried.

adding e2e test verifying the webhook can intercept configmap and custom
resource deletion, and the existing object is sent via the
admissionreview.OldObject.

update the admission integration test to verify that the existing object
is passed to the deletion admission webhook as oldObject, in case of an
immediate deletion and in case of an update-on-delete.
2019-05-17 09:54:11 -07:00
yue9944882
34c4a6e057 Cherrypicking #66535
validate deletion admission object

backward compatibility: add validation for direct storage delete calls

apply nil validation to existing tests

revert behavior changes in deleteCollection call

fixes validation on wiring graceful deletion

remove nil validation check

continue admission check on not found error
2019-05-17 09:50:16 -07:00
Ted Yu
32241b0751 Use lock in eventBroadcasterImpl#refreshExistingEventSeries 2019-05-17 09:30:55 -07:00
Jordan Liggitt
d304c9ecbb Terminate watchers when watch cache is destroyed 2019-05-17 10:21:24 -04:00
Kubernetes Prow Robot
e67c266a72 Merge pull request #65782 from yastij/eventv2-eventf
Implementing logic for v1beta1.Event API
2019-05-17 07:00:10 -07:00
Kubernetes Prow Robot
3193e78a2f Merge pull request #77333 from sttts/sttts-structural-crd-pruning
apiextensions: implement structural schema CRD pruning
2019-05-17 05:38:05 -07:00
Kubernetes Prow Robot
27410955e2 Merge pull request #77952 from liggitt/delete-on-update
Handle updates removing remaining finalizers on deleted objects
2019-05-17 02:04:32 -07:00
Yassine TIJANI
464a994a10 Implementing logic for v1beta1.Event API
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
2019-05-17 10:50:58 +02:00
Dr. Stefan Schimanski
d10f8c1ad3 Update generated files 2019-05-17 09:35:10 +02:00
Dr. Stefan Schimanski
77bfddacfd apiextensions: add pruning integration tests 2019-05-17 09:35:10 +02:00
Dr. Stefan Schimanski
3f3ed79484 apiextensions: only prune correct GroupKind 2019-05-17 09:35:10 +02:00
Dr. Stefan Schimanski
70ee02725f apiextensions: wire pruning into handler 2019-05-17 09:35:10 +02:00
Dr. Stefan Schimanski
52577aa908 apiextensions: low-level pruning algorithms 2019-05-17 09:35:10 +02:00
Dr. Stefan Schimanski
32d05973f5 apiextensions: add structural schema validation if preserveUnknownFields=false 2019-05-17 09:35:10 +02:00
Dr. Stefan Schimanski
7484892009 apiextensions: add preserveUnknownFields API 2019-05-17 09:35:10 +02:00
Kubernetes Prow Robot
e0f28e5d0f Merge pull request #77945 from michaelfig/client-go-namespaced-dynamicinformer
Honour NewFilteredDynamicSharedInformerFactory namespace argument
2019-05-17 00:26:31 -07:00
Kubernetes Prow Robot
a6b546eb72 Merge pull request #77936 from liggitt/shorten-cert-wait
Interrupt WaitForCertificate if desired kubelet serving cert changes
2019-05-17 00:26:19 -07:00
Kubernetes Prow Robot
56683a2f1f Merge pull request #77925 from liggitt/icc-tokenfile
honor overridden tokenfile, add InClusterConfig override tests
2019-05-16 20:39:51 -07:00
Antoine Pelisse
4e32d183d0 fieldManager: Ignore conversion errors to internal types
Errors on updates are bad because they usually come from controllers and
it's very hard to take actions on them. We also don't want to start
breaking kubernetes clusters if something in a schema happens a way we
didn't foresee (even though we've tried to be diligent and test as much
as possible, these can still happen).

Log an identifiable error when they happen. Ideally people can look in
the logs to find these and report them, or providers can look for these
in logs and make sure they don't happen.

Only conversion to internal types are going to be logged and ignored.

It means that we're still failing for:
- Version conversions. If we can't convert the object from one version
  to another,
- Unions. If we can't normalize the union,
- Invalid MangedFields sent in the object. If something has changed the
  ManagedFields to an invalid value.
- Failure to serialize the manager information, this really shouldn't
  happen.
- Encoding the ManagedFields
2019-05-16 12:37:25 -07:00
Jordan Liggitt
739a75fc32 Interrupt WaitForCertificate if desired kubelet serving cert changes 2019-05-16 15:14:47 -04:00
Kubernetes Prow Robot
6a9ecf71fd Merge pull request #77912 from andyzhangx/fix-azuredisk-lun-error
Fix incorrect azuredisk lun error
2019-05-16 08:48:54 -07:00
Kubernetes Prow Robot
5a233ccb84 Merge pull request #77906 from feiskyer/az-no-authz
Allow Kubelet to run with no Azure identity
2019-05-16 08:48:12 -07:00
Kubernetes Prow Robot
730bc968b9 Merge pull request #77874 from yuchengwu/fix-CVE-2019-11244
fix CVE-2019-11244: `kubectl --http-cache=<world-accessible dir>` cre…
2019-05-16 06:06:13 -07:00
Kubernetes Prow Robot
c2847e8b68 Merge pull request #77585 from andyxning/fix_leader_election_start
enhance leader election doc
2019-05-16 01:09:55 -07:00
Jordan Liggitt
fba885a0d2 Handle updates removing remaining finalizers on deleted objects 2019-05-15 17:17:39 -04:00
Kubernetes Prow Robot
c50ff35a55 Merge pull request #77839 from mcrute/migrate-fake-cp
Staging legacy fake cloud provider
2019-05-15 12:32:23 -07:00
Michael FIG
2ed3272a5e Honour NewFilteredDynamicSharedInformerFactory namespace argument 2019-05-15 11:51:34 -06:00
Kubernetes Prow Robot
6a40ed1005 Merge pull request #77751 from baasbank/fix-lint-errors-staging/src/k8s.io
Fix lint errors staging/src/k8s.io
2019-05-15 07:06:26 -07:00
Jordan Liggitt
7306fb7a89 honor overridden tokenfile, add InClusterConfig override tests 2019-05-15 08:15:02 -04:00
Andy Xie
95f33ce399 enhance leader election doc 2019-05-15 18:50:51 +08:00
andyzhangx
4213f4d797 fix azure disk lun error 2019-05-15 08:32:03 +00:00
Pengfei Ni
b13d80a59a Allow Kubelet to run with no Azure identity
useInstanceMetadata should be enabled and Kubelet would use IMDS to get
node's information.
2019-05-15 15:12:29 +08:00
Kubernetes Prow Robot
fd64b83c63 Merge pull request #77837 from davidz627/fix/pdFSType
Translate StorageClass object instead of parameters. Add GCE PD Storage class translation logic.
2019-05-14 20:36:54 -07:00
Kubernetes Prow Robot
5c4b6528c2 Merge pull request #77613 from mikedanese/fixinclusterconfig
BoundServiceAccountTokenVolume: fix InClusterConfig
2019-05-14 20:36:16 -07:00
Kubernetes Prow Robot
4036097edb Merge pull request #75990 from mcrute/remove-regions
Remove hard-coded region list from AWS cloud provider
2019-05-14 18:24:42 -07:00
Kubernetes Prow Robot
1ae09a371f Merge pull request #70929 from mikedanese/cmp
migrate everything to unify diff.Diff method using cmp
2019-05-14 18:24:30 -07:00
Kubernetes Prow Robot
0b6ad8bc3f Merge pull request #77563 from jpbetz/admission-webhook-options
Pass {Operation}Options to Webhooks
2019-05-14 15:34:19 -07:00
Mike Crute
7d62316f8f Migrate fake cloud provider to staging 2019-05-14 13:32:18 -07:00
David Zhu
6aea7fcd83 Added topology translation and backward compatible access modes 2019-05-14 12:40:03 -07:00
Mike Danese
76f683a8f3 vendor github.com/google/go-cmp 2019-05-14 12:24:07 -07:00
Mike Danese
1e9ce46f0a migrate k8s.io/apimachinery/pkg/util/diff to cmp 2019-05-14 12:24:07 -07:00