Commit Graph

90757 Commits

Author SHA1 Message Date
mattjmcnaughton
49fc82f7ab
Ensure we only run the cadvisor/docker init in !dockerless
We do not want to run the `cadvisor/docker` init when we are using the
dockerless build tags. We can ensure this by isolating into a separate
file with the proper build tag constraints.
2020-05-07 17:18:51 -04:00
mattjmcnaughton
29fa1f4566
Fix the verify job
Small changes to fix the verify job. Add the proper headers, fix lint
errors, etc...
2020-05-07 17:18:50 -04:00
mattjmcnaughton
4a8da5e7b4
Add typecheck-dockerless
Ensure that k8s still passes the typecheck when the `dockerless` tag is
enabled. We perform a similar verify step for `providerless`.
2020-05-07 17:18:50 -04:00
mattjmcnaughton
b36f637f0d
Add dockerless tags to all files in dockershim
As the final step, add the `dockerless` tags to all files in the
dockershim. Using `-tags=dockerless` in `go build`, we can compile
kubelet without the dockershim.

Once cadvisor no longer depends on `docker/docker`, compiling with
`-tags=dockerless` should be sufficient to compile the Kubelet w/o a
dependency on `docker/docker`.
2020-05-07 17:18:50 -04:00
mattjmcnaughton
7fb6c51822
Move DockerLegacyService interface out of pkg/kubelet/dockershim
DockerLegacyService interface is used throughout `pkg/kubelet`.
It used to live in the `pkg/kubelet/dockershim` package. While we
would eventually like to remove it entirely, we need to give users some form
of warning.

By including the interface in
`pkg/kubelet/legacy/logs.go`, we ensure the interface is
available to `pkg/kubelet`, even when we are building with the `dockerless`
tag (i.e. not compiling the dockershim).
While the interface always exists, there will be no implementations of the
interface when building with the `dockerless` tag. The lack of
implementations should not be an issue, as we only expect `pkg/kubelet` code
to need an implementation of the `DockerLegacyService` when we are using
docker. If we are using docker, but building with the `dockerless` tag, than
this will be just one of many things that breaks.

`pkg/kubelet/legacy` might not be the best name for the package... I'm
very open to finding a different package name or even an already
existing package.
2020-05-07 17:18:49 -04:00
mattjmcnaughton
34c8f51dcb
Remove all uses of dockershim from cmd/kubelet
We can remove all uses of `dockershim` from `cmd/kubelet`, by just
passing the docker options to the kubelet in their pure form, instead of
using them to create a `dockerClientConfig` (which is defined in
dockershim). We can then construct the `dockerClientConfig` only when we
actually need it.
2020-05-07 17:18:49 -04:00
mattjmcnaughton
e0e6d54cdf
Extract running Dockershim into own file
Extract a `runDockershim` function into a file outside of `kubelet.go`.
We can use build tags to compile two separate functions... one which
actually runs dockershim and one that is a no-op.
2020-05-07 17:18:48 -04:00
mattjmcnaughton
53adde65ce
Remove ExperimentalDockershim from kubelet
Remove one of two uses of Dockershim in `cmd/kubelet`. The other is for
creating a docker client which we pass to the Kubelet... we will handle
that refactor in a separate diff.

I'm fairly confident, though need to double check, that no one is
actually using this experimental dockershim behavior. If they are, I
think we will want to find a new way to support it (that doesn't require
using the Kubelet only to launch Dockershim).
2020-05-07 17:18:48 -04:00
Kubernetes Prow Robot
eec809aa93
Merge pull request #90779 from thockin/umask-for-builds
Set umask 0022 when building
2020-05-07 14:01:57 -07:00
Kubernetes Prow Robot
b24eba019d
Merge pull request #90563 from cici37/traint
Copy RemoveTaintOffNode logic to k8s.io/cloud-provider
2020-05-07 14:01:42 -07:00
Kubernetes Prow Robot
af67408c17
Merge pull request #90818 from wojtek-t/fix_retry_watcher
Request for bookmarks in RetryWatcher
2020-05-07 07:35:29 -07:00
Kubernetes Prow Robot
c5be566b14
Merge pull request #90707 from jherrera123/fix-issue-88132
Make flexvolume e2e tests runnable again.
2020-05-07 07:35:15 -07:00
Kubernetes Prow Robot
9f76518c40
Merge pull request #90804 from dims/new-go-runner-image-for-distroless
New go-runner image for distroless scenarios
2020-05-07 03:03:08 -07:00
wojtekt
7a65760f6e Request for bookmarks in RetryWatcher 2020-05-07 10:26:28 +02:00
Kubernetes Prow Robot
be02fe5785
Merge pull request #90782 from justaugustus/base-images
base-images: Use new debian-iptables:v12.1.0
2020-05-06 22:23:22 -07:00
Kubernetes Prow Robot
7f78048594
Merge pull request #90781 from msau42/increase-timeout
Increase timeout waiting for driver to start on nodes
2020-05-06 22:23:08 -07:00
Davanum Srinivas
393e0952e9
New go-runner image for distroless scenarios
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-05-06 21:29:46 -04:00
Kubernetes Prow Robot
b144eec878
Merge pull request #90778 from msau42/update-mock
Update sidecars for csi mock driver
2020-05-06 17:57:08 -07:00
Anago GCB
8c4e3faed3 CHANGELOG: Update directory for v1.15.12 release 2020-05-06 20:40:38 +00:00
Kubernetes Prow Robot
3416442e4b
Merge pull request #90644 from tanjunchen/remove-controller-dependency
test/e2e/framework:remove the direct dependency for k8s.io/kubernetes/pkg
2020-05-06 11:47:12 -07:00
Stephen Augustus
8e8a1a4038 build: Update guidance for updating base image tags and digests
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-05-06 13:38:19 -04:00
Kubernetes Prow Robot
0a6c826d3e
Merge pull request #90715 from jsafrane/gluster-ignore-notfound
Ignore NotFound error when cleaning up Gluster tests
2020-05-06 05:25:09 -07:00
Kubernetes Prow Robot
c30da3839c
Merge pull request #90148 from deads2k/force-beta-to-have-tags
enforce prerelease-lifecycle generation for beta APIs
2020-05-06 01:19:08 -07:00
Kubernetes Prow Robot
4d813c1360
Merge pull request #90749 from andyzhangx/dangling-error
fix: azure disk dangling attach issue on VMSS which would cause API throttling
2020-05-05 23:43:09 -07:00
Stephen Augustus
aa79da2696 deps: Update dependents to use debian-iptables:v12.1.0
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-05-06 01:14:01 -04:00
Kubernetes Prow Robot
fecc66aa1f
Merge pull request #90755 from Huang-Wei/refine-schedQueue-test
Refine schedulerQueue test to avoid unneeded locks
2020-05-05 20:03:22 -07:00
Kubernetes Prow Robot
14eb291084
Merge pull request #90751 from yliaog/windep
Removed leftover comments for the deleted function Get_MgmtSubnet
2020-05-05 20:03:09 -07:00
Michelle Au
fc08f74157 Increase timeout waiting for driver to start on nodes to reduce test flakiness
Change-Id: Id553943e4473b387bf0ae14a18a90cb3a1bcd5c1
2020-05-05 18:10:10 -07:00
Kubernetes Prow Robot
d8a513ef99
Merge pull request #90697 from justaugustus/base-images
base-images: Use new debian-base:v2.1.0 and build new debian-iptables:v12.1.0
2020-05-05 18:01:23 -07:00
Kubernetes Prow Robot
8e3766f2a8
Merge pull request #90215 from jasimmons/pr_agnhost_netexec_http
Adds HTTPS logic to agnhost netexec
2020-05-05 18:01:09 -07:00
cici37
32411016cc Copy RemoveTaintOffNode logic to k8s.io/cloud-provider 2020-05-05 16:47:09 -07:00
Tim Hockin
dff449ee9e Set umask 0022 when building
Some binaries now run as non-root (kube-scheduler).  When umask is 0027,
for example, the container image we build has the binary 0750, which is
not executable by the non-root UID.
2020-05-05 16:28:43 -07:00
Michelle Au
b34ad7e8ad Update sidecars for csi mock driver
Change-Id: Ica8ca20404fd15dcfdbb912602934a5b9f24e4c6
2020-05-05 16:21:19 -07:00
Kubernetes Prow Robot
68cbb35ebc
Merge pull request #90737 from jiahuif/node-lifecyecle-controller-shutdown-order
CloudNodeLifecycleController: check node existence before shutdown status
2020-05-05 14:31:09 -07:00
Kubernetes Prow Robot
27f06962d8
Merge pull request #90744 from prameshj/kubedns-version
Bump up the kube-dns version to 1.15.10
2020-05-05 12:39:22 -07:00
Kubernetes Prow Robot
ff45f0d311
Merge pull request #90742 from jiahuif/remove-cloud-node-addresses-todo
remove obsolete TODO item of NodeAddresses
2020-05-05 12:39:09 -07:00
Stephen Augustus
d95dcc61f3 cluster/images/etcd: Bump etcd image tags for new debian-base
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2020-05-05 15:16:38 -04:00
Anago GCB
dac4f810f5 CHANGELOG: Update directory for v1.19.0-alpha.3 release 2020-05-05 16:40:14 +00:00
Kubernetes Prow Robot
a441f869d9
Merge pull request #90729 from wojtek-t/reduce_cache_size
Update duration to be kept in watchcache
2020-05-05 08:59:08 -07:00
Indeed
3117b6a084 fix case where node exists but shutdown. 2020-05-05 08:57:58 -07:00
Indeed
78ace24670 check node existence before shutdown status. 2020-05-05 08:57:58 -07:00
Indeed
84dfaace5d add test about shutdown but non-existing node. 2020-05-05 08:51:21 -07:00
David Eads
d9d6b5804a remove unnecessary removed tags since they can be auto-applied via policy 2020-05-05 09:49:34 -04:00
David Eads
24af2ed592 Revert "add prerelease lifecycle tags to apiregistration.k8s.io"
This reverts commit 823baa1fd0.
2020-05-05 09:48:21 -04:00
David Eads
1aee03f8c8 add prerelease lifecycle tags to apiregistration.k8s.io 2020-05-05 09:48:21 -04:00
David Eads
8e43b5e5ea add prerelease-lifecycle verification to all beta APIs 2020-05-05 09:47:31 -04:00
Kubernetes Prow Robot
b48f5af260
Merge pull request #90603 from deads2k/beta-annotations-13-policy
add prerelease lifecycle tags to policy
2020-05-05 05:59:08 -07:00
andyzhangx
05d7570713 fix: azure disk dangling attach issue
fix: change parsing of vmas providerID

fix GetNodeNameByProviderID

fix spelling
2020-05-05 12:34:02 +00:00
Wei Huang
8c2a540cdc
Refine schedulerQueue test to avoid unneeded locks
- revert PR 88331
- remove createAndRunPriorityQueue()
- PriorityQueue is created and not run by default
- flushXYZ() is called on demand by manipulating FakeClock and Step()
2020-05-05 00:11:04 -07:00
Kubernetes Prow Robot
de66c643c4
Merge pull request #85564 from MorrisLaw/document-import-boss
create a file to hold documentation of import-boss in one place
2020-05-04 22:07:08 -07:00