Commit Graph

70337 Commits

Author SHA1 Message Date
Hannes Hörl
6330cee9ea Add tests for csiDriverClient
As #69219 outlines the unit tests in `csi_client_test.go` where not
testing the actual implementation of the `csiDriverClient` but was
testing the fake.

To fix this, we changed the `csiDriverClient` to use a
`nodeClientCreator` which is responsible for creating a new
`NodeClient`, a real one in prod and a fake one in the tests.

The setup of the gRPC connection has been pushed into that creator. The
node client uses that connection; that's transparent to the driver
client. It's the responsibility of the driver client to close the
connection when it is done with the node client. To achieve this, we
have the node client creator return a closer which handles the
connection teardown.

In the tests we now also check if the driver client actually calls
this closer, thus closing the gRPC connection.

Closes: #69219

Co-authored-by: Rosie Bloxsom <rbloxsom@pivotal.io>
Co-authored-by: Maria Ntalla <mntalla@pivotal.io>
2018-10-15 20:55:37 +01:00
k8s-ci-robot
db1d1c8674
Merge pull request #68700 from Huang-Wei/schedulingQ-graceful-shutdown
shutdown schedulingQueue gracefully
2018-09-28 00:46:14 -07:00
k8s-ci-robot
6b49423a8e
Merge pull request #68585 from immutableT/blocking-kms-plugin-connect
kube-apiserver should wait/block for kms-plugin to start.
2018-09-27 22:31:28 -07:00
k8s-ci-robot
932e657d5d
Merge pull request #69180 from dims/remove-extra-debugging-log-status-for-go-install
Remove extra debugging log::status call
2018-09-27 20:52:20 -07:00
k8s-ci-robot
8fd28eface
Merge pull request #69167 from apelisse/kubectl-diff
Move `diff` command from alpha sub-command to root cmd
2018-09-27 20:52:11 -07:00
k8s-ci-robot
a59474f756
Merge pull request #69132 from seans3/rollout-pause-resume-fix
kubectl remove internal version of resource for rollout pause/resume
2018-09-27 20:52:02 -07:00
k8s-ci-robot
79fa559d6a
Merge pull request #68324 from cheftako/lintClean
Cleaned up lint errors in pkg/kubeapiserver/server.
2018-09-27 20:51:51 -07:00
k8s-ci-robot
c79ad5a65b
Merge pull request #68875 from Huang-Wei/minor-scheduler-cleanup
cleanup duplicate assignment logic in scheduler
2018-09-27 18:29:39 -07:00
Anago GCB
1636fed8c5 Update CHANGELOG-1.12.md for v1.12.0. 2018-09-27 23:04:39 +00:00
k8s-ci-robot
7b9f6df068
Merge pull request #69163 from MrHohn/gce-cloud-beta-ds-mock
Add mock for UpdateBetaBackendService
2018-09-27 15:53:46 -07:00
k8s-ci-robot
f31cec4174
Merge pull request #69149 from mkumatag/update-auth-images
Update authenticated-image-pulling with fat manifest image
2018-09-27 15:53:37 -07:00
k8s-ci-robot
9505330dc8
Merge pull request #69030 from zhangmingld/fixlocalup
fix allow-priviledge not work in local-up-cluster
2018-09-27 15:53:28 -07:00
k8s-ci-robot
01379fe61e
Merge pull request #69022 from k82cn/k8s_68987
Got allocatable GPUs.
2018-09-27 15:53:19 -07:00
k8s-ci-robot
6e36efc4b7
Merge pull request #68980 from derekwaynecarr/kubelet-restart-policy
Kubelet should not create a new pod sandbox if all containers are done
2018-09-27 15:53:08 -07:00
k8s-ci-robot
e5964b3fcc
Merge pull request #69162 from apelisse/kubectl-dry-run-diff
Use dry-run patch to get the merged version of the object
2018-09-27 14:41:53 -07:00
Davanum Srinivas
a89242b7fd
Remove extra debugging log::status call
Introduced by mistake in:
d9cfd77149

Change-Id: I71ddf7131c47e74dddfa1f8ccc69cc980eeefb94
2018-09-27 17:36:44 -04:00
Wei Huang
be661fddb4
shutdown schedulingQueue gracefully
- add Close() to interface SchedulingQueue
- implement Close() for FIFO and PriorityQueue
- add unit test
2018-09-27 14:32:58 -07:00
Antoine Pelisse
e1eadc5031 Move diff command to root rather than alpha
New command is now `kubectl diff` rather than `kubectl alpha diff` since
it's moving out of alpha soon, and will be using dry-run apply to
produce the diff rather than the custom merge logic.
2018-09-27 13:11:43 -07:00
Antoine Pelisse
2d3f7795c8 Use dry-run patch to get the merged version of the object 2018-09-27 13:06:12 -07:00
k8s-ci-robot
3c43f089b2
Merge pull request #69155 from mooncak/fix_duplicate_words
remove duplicate words in files
2018-09-27 12:21:46 -07:00
k8s-ci-robot
aa3993abc6
Merge pull request #69102 from x13n/test-fix
Fix Stackdriver custom metrics tests
2018-09-27 12:21:36 -07:00
k8s-ci-robot
587914c29d
Merge pull request #69055 from fabriziopandini/kubeadm-remove-v1alpha2
Kubeadm remove v1alpha2 api
2018-09-27 12:21:26 -07:00
k8s-ci-robot
2220780614
Merge pull request #67401 from lathama/lathama-examples
from #61246 note removed examples and regression for master
2018-09-27 12:21:16 -07:00
Wei Huang
56fcfc5fee
cleanup duplicate assignment logic in scheduler 2018-09-27 11:38:05 -07:00
Derek Carr
5f473bc8e1 Kubelet should not create a new pod sandbox if all containers are done 2018-09-27 14:21:50 -04:00
k8s-ci-robot
34860dafe2
Merge pull request #69150 from soltysh/issue69144
Fix panic in kubectl rollout commands
2018-09-27 11:07:56 -07:00
k8s-ci-robot
58102b7517
Merge pull request #69077 from feiskyer/az-ip
Add fallbacks for getting node IP from Azure IMDS
2018-09-27 11:07:46 -07:00
Zihong Zheng
c9c39eef9c Add mock for UpdateBetaBackendService 2018-09-27 10:57:26 -07:00
Sean Sullivan
71e60225a0 kubectl remove internal version of resource for rollout pause/resume 2018-09-27 10:26:35 -07:00
k8s-ci-robot
0787715978
Merge pull request #69124 from tanshanshan/httpcode
replace 200 with http.StatusOK
2018-09-27 09:51:48 -07:00
k8s-ci-robot
96965705a1
Merge pull request #69121 from seans3/editoptions-small-fix
Replaces dependency on internal version of resource with external ver…
2018-09-27 09:51:38 -07:00
k8s-ci-robot
63930183e0
Merge pull request #69119 from seans3/diff-small-fix
Replace internal reference of last-applied-config with external refer…
2018-09-27 09:51:29 -07:00
k8s-ci-robot
53fe9e2a30
Merge pull request #69118 from seans3/apply-small-fix
Replace internal dependency on last-applied-configuration with extern…
2018-09-27 09:51:20 -07:00
k8s-ci-robot
2588ad5f36
Merge pull request #69089 from soltysh/kubectl_issue539
Deduplicate list of directories
2018-09-27 09:51:06 -07:00
immutablet
07cbf2545f Lazily dial kms-plugin. 2018-09-27 09:12:31 -07:00
mooncake
9c561d0c68 remove duplicate words in files 2018-09-27 22:58:47 +08:00
k8s-ci-robot
8e6172dec2
Merge pull request #69062 from dghubble/add-configmap-get
Add configmap get to system:kube-controller-manager
2018-09-27 07:18:50 -07:00
k8s-ci-robot
b25bf81573
Merge pull request #69044 from enj/enj/i/gv_remove_pointers
Remove pointer receivers from schema structs
2018-09-27 07:18:40 -07:00
k8s-ci-robot
05196d752b
Merge pull request #69043 from deads2k/auth-01-logging
make sure that log includes user information
2018-09-27 07:18:31 -07:00
k8s-ci-robot
f0311b52b3
Merge pull request #69042 from rramkumar1/fake-gce-1
Expose public function to init fake GCECloud + add common hooks
2018-09-27 07:18:22 -07:00
k8s-ci-robot
2662ca309d
Merge pull request #69037 from shubheksha/fix/68964-simplify-run-method-kube-scheduler-server
Simplify kube-scheduler's run() method
2018-09-27 07:18:11 -07:00
Maciej Szulik
96d01da215
Fix panic in kubectl rollout commands 2018-09-27 15:10:52 +02:00
k8s-ci-robot
25607dea8c
Merge pull request #69027 from vainu-arto/aws-add-has-cluster-tags-tests
AWS: Add tests for awsTagging.hasClusterTag
2018-09-27 06:06:58 -07:00
k8s-ci-robot
3f01e09afe
Merge pull request #68970 from yue9944882/fixes-bsd-sed-compatibility
Fixes bsd / gnu sed compatibility for local-up-cluster script
2018-09-27 06:06:49 -07:00
k8s-ci-robot
12787275f4
Merge pull request #68929 from FengyunPan2/fix-memoryLimit
Configure resource-only container with memory limit
2018-09-27 06:06:39 -07:00
k8s-ci-robot
4215774643
Merge pull request #68634 from seans3/remove-internal-version
Replace internal version of resource with external version for tests
2018-09-27 06:06:30 -07:00
k8s-ci-robot
2adecd040d
Merge pull request #63485 from lovejoy/addPodAgeToDescribeNode
add pod age to describe node
2018-09-27 06:06:20 -07:00
Manjunath A Kumatagi
7b9833ce56 Update authenticated-image-pulling with fat manifest image 2018-09-27 17:43:15 +05:30
k8s-ci-robot
807eb6b24b
Merge pull request #69003 from dims/ensure-reproducible-builds-pass-epoch-env-var
Ensure reproducible builds - support for SOURCE_DATE_EPOCH with docke…
2018-09-27 04:49:10 -07:00
k8s-ci-robot
43a9e08e02
Merge pull request #68990 from carlisia/c-pauseversion
Change pause version value to a constant for image
2018-09-27 04:48:59 -07:00