Commit Graph

105411 Commits

Author SHA1 Message Date
Patrick Ohly
798bdab3d0 kubectl: add integration test for result reporting
This currently covers two cases:
- "kubectl list" (the regression from https://github.com/kubernetes/kubernetes/issues/107012)
- "kubectl get pods/no-such-pod" (no particular reason except that the output
should be deterministic)

In contrast to some other tests that check for strings inside the
output (run_deprecated_api_tests) or compare after
sorting (run_kubectl_version_tests), stdout, stderr and the return code must
match exactly.

This ensures that there is no extra, unexpected output and that the right
output stream is used.
2022-01-11 09:04:56 +01:00
Patrick Ohly
a5d2d6fec3 cli: let kubectl handle error printing
cli.Run was an attempt to elliminate error handling in Kubernetes
commands. However, it had to rely on heuristics that are not necessarily right
for all commands.

kubectl is one example which has its own error printing code that should be
used in all cases after a command failure. It now gets used also for
`--warnings-as-errors`. Previously, that caused the following message to be
logged at the end:

  E0110 16:56:01.987555  202060 run.go:120] "command failed" err="1 warning received"

Now it ends with:

 error: 1 warning received
2022-01-10 17:09:30 +01:00
Patrick Ohly
8fc7a9bce9 cli: avoid logging command line errors in more cases
"kubectl list" should print a plain text explanation ("Unknown command "list"
for kubectl. ...") without treating that multi-line error as a log message.

The previous heuristic didn't work here because the command itself was not
found. A better one is to check that command execution really started.

This is still not perfect: what if a command hasn't started logging yet or
never uses logging for its output and then returns an error? That works in
kubectl because it does its own error checking at runtime and then doesn't
return, but a more robust solution might be an explicit parameter that prevents
using klog.
2021-12-15 09:50:45 +01:00
Kubernetes Prow Robot
770847e6b0
Merge pull request #106992 from hakman/ipv6_skip_load-balancer
Skip LB test for IPv6 clusters
2021-12-13 03:09:58 -08:00
Ciprian Hacman
574f788711 Skip LB test for IPv6 clusters 2021-12-13 11:43:06 +02:00
Kubernetes Prow Robot
ba200841fd
Merge pull request #106366 from cyclinder/evictions_number_stable
adding evictions_total metric and marking evictions_number deprecated
2021-12-12 23:19:59 -08:00
cyclinder
b88b51c6e5 adding evictions_total metric and marking evictions_number deprecated
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-12-13 10:36:02 +08:00
Kubernetes Prow Robot
909bada3f4
Merge pull request #106628 from tkashem/apf-httplog-seats
apf: track initial and final seats in httplog and metrics
2021-12-12 18:19:58 -08:00
Abu Kashem
bb15bdf15c
apf: add a metric to count seat samples 2021-12-11 20:50:27 -05:00
Abu Kashem
be085b6345
apf: add initial and final seats to httplog 2021-12-11 20:50:27 -05:00
Kubernetes Prow Robot
0cae5f5006
Merge pull request #106744 from BinacsLee/binacs/fix-race-condition-in-scheduler-eventhandler
scheduler: fix race condition during cache refresh
2021-12-11 00:31:59 -08:00
Kubernetes Prow Robot
030c3fbd58
Merge pull request #106936 from sbangari/windowsserviceflappingfix
Skip creating HNS loadbalancer with empty endpoints
2021-12-10 22:41:57 -08:00
Kubernetes Prow Robot
aed75bf2ed
Merge pull request #106880 from ii/promote-proxy-301-redirect
Promote Pod- & ServiceProxy Test to Conformance - +12 endpoint coverage
2021-12-10 21:31:57 -08:00
Kubernetes Prow Robot
0ae6ef69b8
Merge pull request #106827 from tkashem/apf-exempt-note
apf: ensure exempt request is noted with classification
2021-12-10 19:44:32 -08:00
Kubernetes Prow Robot
8b9e1d78f6
Merge pull request #106964 from ncdc/portable-code-generation
Code generation outside GOPATH
2021-12-10 17:48:32 -08:00
Kubernetes Prow Robot
c7ff5758db
Merge pull request #106922 from cheftako/anp-release
Bump konnectivity network proxy to v0.0.27.
2021-12-10 14:11:21 -08:00
Andy Goldstein
60d2481b88
Bump k8s.io/gengo to v0.0.0-20211115164449-b448ea381d54
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
2021-12-10 14:30:53 -05:00
Kubernetes Prow Robot
9629ac6d2f
Merge pull request #106906 from tsmetana/k8s-fix-azure-subpath
mount-utils: Detect potential stale file handle
2021-12-10 11:05:22 -08:00
Kubernetes Prow Robot
4ea2448be2
Merge pull request #106956 from cpanato/gco1175
[go1.17] Update to go1.17.5
2021-12-10 10:03:10 -08:00
Abu Kashem
8b2dd74c27
apf: ensure exempt request notes the classification 2021-12-10 11:54:10 -05:00
Kubernetes Prow Robot
b0eb3e1ec2
Merge pull request #106949 from cpanato/update-golang-xnet
dependencies: Update golang.org/x/net to v0.0.0-20211209124913-491a49abca63
2021-12-10 08:13:11 -08:00
Carlos Panato
4bda9697ee
[go1.17] Update to go1.17.5
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
2021-12-10 16:58:29 +01:00
Kubernetes Prow Robot
1d66302c42
Merge pull request #106458 from dims/lint-yaml-in-owners-files
Lint/Beautify yaml in OWNERS files
2021-12-10 06:39:12 -08:00
BinacsLee
1027b8de40 scheduler: fix race condition during cache refresh 2021-12-10 20:46:12 +08:00
Kubernetes Prow Robot
1b0d83f1d6
Merge pull request #106599 from klueska/fix-numa-bug
Fix Bugs in CPUManager distribute NUMA policy option
2021-12-10 04:41:12 -08:00
Carlos Panato
37dda91186
dependencies: Update golang.org/x/net to v0.0.0-20211209124913-491a49abca63
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
2021-12-10 12:54:55 +01:00
Kubernetes Prow Robot
cc6f12583f
Merge pull request #106921 from dims/update-x/tools-to-v0.1.8
Update golang.org/x/tools to a specific tag (v0.1.8) and avoid SHA
2021-12-09 21:31:10 -08:00
Sravanth Bangari
26be8d6890 Skip creating HNS loadbalancer with empty endpoints 2021-12-09 20:03:21 -08:00
Kubernetes Prow Robot
15e5f2a19a
Merge pull request #106291 from sbs2001/fix_invalid_comment
Remove invalid comment in legacyregistry
2021-12-09 19:03:10 -08:00
Davanum Srinivas
c89299a890
Temporarily comment out untrusted user
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-12-09 21:31:32 -05:00
Davanum Srinivas
9405e9b55e
Check in OWNERS modified by update-yamlfmt.sh
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-12-09 21:31:26 -05:00
Davanum Srinivas
a5c670102c
Cleanup owners files to make parsing automatable
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-12-09 21:31:03 -05:00
Kubernetes Prow Robot
b5a610064c
Merge pull request #106920 from neolit123/1.24-update-kubeadm-owners
kubeadm: update OWNERS for 1.24
2021-12-09 18:01:22 -08:00
Kubernetes Prow Robot
ab4448dd2f
Merge pull request #104177 from DangerOnTheRanger/e2e-resize-node-flake-fix
Fix node resizing E2E test flake
2021-12-09 18:01:11 -08:00
Kubernetes Prow Robot
481459d12d
Merge pull request #106872 from calvin0327/fix-kubeadm-kubelet-constant
kubeadm: amend constant to kubelet.
2021-12-09 16:29:22 -08:00
Kubernetes Prow Robot
461dc9e371
Merge pull request #104640 from lizhuqi/fluentd-1-17
Remove stackdriver version variable
2021-12-09 16:29:10 -08:00
Kubernetes Prow Robot
747f3c8fd9
Merge pull request #106901 from bobbypage/graceful-shutdown-fix-master
kubelet: set failed phase during graceful shutdown
2021-12-09 14:39:04 -08:00
David Porter
95264a418d kubelet: set failed phase during graceful shutdown
Revert to previous behavior in 1.21/1.20 of setting pod phase to failed
during graceful node shutdown.

Setting pods to failed phase will ensure that external controllers that
manage pods like deployments will create new pods to replace those that
are shutdown. Many customers have taken a dependency on this behavior
and it was breaking change in 1.22, so this change reverts back to the
previous behavior.

Signed-off-by: David Porter <david@porter.me>
2021-12-09 13:17:40 -08:00
Kubernetes Prow Robot
12b4bef7bd
Merge pull request #106852 from wojtek-t/remove_legacy_leader_election
Remove support for Endpoints and ConfigMaps lock from leader election
2021-12-09 12:21:03 -08:00
Walter Fender
b869d5550c Bump konnectivity network proxy to v0.0.27.
/kind feature

Includes fixes for a few resource leaks.
Set the dependency chain to K/K v0.0.21.

Fixes # N/A

```release-note
NONE
```

```docs
NONE
```
2021-12-09 11:56:20 -08:00
Davanum Srinivas
627c50661e
Update golang.org/x/tools to a specific tag and avoid SHA
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-12-09 14:23:55 -05:00
Lubomir I. Ivanov
0290eb63b6 kubeadm: update OWNERS for 1.24 2021-12-09 21:07:56 +02:00
Kubernetes Prow Robot
8cc7d14588
Merge pull request #106859 from knight42/refactor/remove-apiserver-insecure-port
refactor(apiserver): remove the insecure flags
2021-12-09 09:48:30 -08:00
Kubernetes Prow Robot
cbec2a936b
Merge pull request #105517 from tkashem/apf-metrics
apf: add new label for request_execution_seconds metric
2021-12-09 09:48:18 -08:00
Kubernetes Prow Robot
bfeabe894f
Merge pull request #106892 from ncdc/improve-path-recorder-duplicate-registration-info
Improve pathrecorder duplicate registration info
2021-12-09 08:06:28 -08:00
Kubernetes Prow Robot
cb0e11a296
Merge pull request #106860 from knight42/refactor/remove-ctrlmgr-insecure-port
refactor: remove the insecure flags in controller-manager
2021-12-09 08:06:16 -08:00
Kubernetes Prow Robot
c16b2afc1d
Merge pull request #106850 from MadhavJivrajani/deprecate-clock-pkg
Deprecate types in k8s.io/apimachinery/util/clock
2021-12-09 06:06:10 -08:00
Madhav Jivrajani
1e1ff064c0 clock: Deprecate types to use k8s.io/utils/clock
* Each exposed type/func is aliased to an equilvalent in
  k8s.io/utils/clock.
* Adds deprecation notices to each type.
* This package should be completely deleted in 1.25.
* The test file is deleted since types are now references
  to k8s.io/utils/clock

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2021-12-09 16:16:44 +05:30
Madhav Jivrajani
4ca13e6f0e Bump k8s.io/utils
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2021-12-09 16:16:27 +05:30
Kubernetes Prow Robot
e3c83c6134
Merge pull request #106658 from wpedrak/even-more-resilient-version.txt
Even more resilient version.txt
2021-12-09 02:08:11 -08:00