This patch splits declaration and assignment for local variables where
shellcheck triggers risk of shadowing warnings. Some missing exports
also added, and an unused variable was removed.
Signed-off-by: Joakim Roubert <joakim.roubert@axis.com>
We will have two layers of the validation.
- the first part of the validation logic will be implemented under the
`ValidateKubeletConfiguration` method
- the second one that requires knowledge about machine topology and
node allocatable resources will be implemented under the memory manager.
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
The new flag will parse the `--reserved-memory` flag straight forward
to the []kubeletconfig.MemoryReservation variable instead of parsing
it to the middle map representation.
It gives us possibility to get rid of a lot of unneeded code and use the single
presentation for the reserved-memory.
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
Move the fakeTopologyManagerWithHint and all related methods
from the topology manager package to the memory manager static policy unittests.
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
With the memory manager static policy:
- start multiple guaranteed pods and verify that pods succeeded to start
- start workload pod on each NUMA node to load the memory and start the
pod that requested more memory than each NUMA node have, the pod should fail
to start with the admission error, because no single NUMA node has enough
memory to start the pod and also each NUMA node already used for single
NUMA node allocation
The test requires at least two NUMA nodes
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
Provides basic tests e2e to verify that pod succeeds
to start with MemoryManager enabled.
Verifies both MemoryManager policies and when the node has
multiple NUMA nodes it will verify the memory pinning.
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
The commit rename state structs and some fields under these structs.
- NodeMap -> NUMANodeMap
- NodeState -> NUMANodeState
- NUMANodeState.Nodes -> NUMANodesState.Cells
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
Calculate the total amount of reserved memory only for NUMA nodes
that are existing under the machine.
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
- The `Allocate` method will try to allocate the memory according to the affinity hints
saved under the `TopologyManager` store. If the store does not have any hints for the memory
it will call `getDefaultHint` to get the default hint. If the affinity does not satisfy
the memory request, it will call `extendTopologyManagerHint` to extend the topology hint to
satisfy the memory request. Once it has the preferred hint, it will allocate the memory and
update the the memory manager state accordingly.
- The `RemoveContainer` will release the allocated memory and update the memory manager state accordingly.
- The `GetTopologyHints` method will try to re-generate topology hints when the container already presents
under the memory manager state. If it does not present it will call `calculateHints` to get topology hints.
The `calculateHints` uses an approach similar to the one used under the CPU manager:
1. If the container memory request can be satisfied by the single NUMA node, it will not allocate the memory from
more than one NUMA node and it will set only single NUMA hints as the preferred one.
It can affect the density, but it gives us guarantees regarding the NUMA alignment.
2. The NUMA node used in the multi NUMA assignment can not be used in the single NUMA assignment.
And the NUMA node used in the single NUMA assignment can not be used in the multi NUMA assignment.
3. Only hints with NUMA node that have enough memory will be returned.
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
Reserved memory of all kinds (and over all
NUMA nodes) must be equal to the values determined
by Node Allocatable feature.
Signed-off-by: Cezary Zukowski <c.zukowski@samsung.com>
Pass memory manager flags to the container manager and call all relevant memory manager
methods under the container manager.
Signed-off-by: Byonggon Chun <bg.chun@samsung.com>
