Commit Graph

111531 Commits

Author SHA1 Message Date
Jan Safranek
9a98f7318b Increase verbosity of volume reconstruction messages
Add volume reconstruction logs to V(2) to see initial kubelet
ActualStateOfWorld after kubelet start. Kubelet logs SetUp / TearDown
events at V(2) already, so we can track the whole volume mount state in
V(2) logs.
2022-11-07 11:05:27 +01:00
Jan Safranek
286e19c460 Add node name parameter
Add nodeName to MarkVolumeAsAttached. MarkVolumeAsAttached implementation
in kubelet does not use the parameter, but it could do that in the future.
2022-11-07 10:50:23 +01:00
Jan Safranek
20c5cc0a39 Add unit test for failed mount after reconstruction
To preserve fix in https://github.com/kubernetes/kubernetes/pull/110670,
add an unit test that check a volume is *uncertain* even after final mount
error when it was reconstructed.

And actually fix a regression introduced in the previous patch.
2022-11-04 12:25:21 +01:00
Jan Safranek
6d810f2cd4 Add unit tests 2022-11-03 17:54:58 +01:00
Jan Safranek
3a79466ddd Reshuffle functions between reconstruct and reconstruc_common
Move common functions to reconstruc_common.go and functions used only for
the current (old) reconstruction to reconstruct.go
2022-11-03 16:55:13 +01:00
Jan Safranek
44b72d0348 Move new reconciler logic into reconciler_new.go
Move reconciler logic from reconstruct{new}.go to:
- reconciler.go - only the functionality used by the current (old)
  reconciler.
- reconciler_new.go - only the functionality used by the new reconciler.
- reconciler_common.go - common functions.
2022-11-03 16:55:13 +01:00
Jan Safranek
fc245b339b Refactor ConstructVolumeSpec
Return a struct from ConstructVolumeSpec to be able to add more fields to
it later.
2022-11-03 16:55:13 +01:00
Jan Safranek
2dc8cc13a4 Remove SyncReconstructedVolume call
With the new reconstruction, AWS.MarkVolumeAsMounted will update outer spec
name with the correct value from Pod.
2022-11-03 16:55:12 +01:00
Jan Safranek
e0f3e5c457 Rework volume reconstruction
Subsequent SELinux work (see http://kep.k8s.io/1710) will need
ActualStateOfWorld populated around the time kubelet starts mounting
volumes.

Therefore reconstruct volumes before starting reconciler, but do not depend
on the desired state of world populated nor node.status - both need a
working API server, which may not be available at that time.

All reconstructed volumes are marked as Uncertain and reconciler will sort
them out - call SetUp to ensure the volume is really mounted when a pod
needs the volume or call TearDown then there is no such pod.

Finish the reconstruction when the API server becomes available:
- Clean up volumes that failed reconstruction and are not needed.

- Update devicePath of reconstructed volumes from node.status. Make sure
  not to overwrite devicePath that may have been updated when the volume
  was mounted by reconcile().

Hiding all this rework behind SELinuxMountReadWriteOncePod FeatureGate,
just to make sure we have a way back if this commit is buggy.
2022-11-03 16:55:12 +01:00
Jan Safranek
989e391d08 Move all volume reconstruction code into separate files
There is no code change, just moving code around and preparing for the
subsequent commit.
2022-11-02 15:58:21 +01:00
Kubernetes Prow Robot
07315d10b3
Merge pull request #113513 from dims/fix-sample-apiserver-e2e-image-build-failure
Fix sample-apiserver E2E image build failure
2022-11-02 06:47:27 -07:00
Kubernetes Prow Robot
c4a8d3e9e4
Merge pull request #113462 from chendave/reset_test
kubeadm: add testcases for `kubeadm reset`
2022-11-02 06:47:15 -07:00
Kubernetes Prow Robot
548d135ea6
Merge pull request #113185 from everpeace/update-agnhost-e2e-image-for-supplementalgroups
test/images/agnhost: Adds a test user and group in the image for a E2E test case of SupplementalGroups with pre-defined group in the image
2022-11-02 03:58:47 -07:00
Kubernetes Prow Robot
ccf57ba09d
Merge pull request #113523 from seans3/content-type-response
Get response content-type
2022-11-01 22:52:45 -07:00
Kubernetes Prow Robot
e17a4f64d7
Merge pull request #113518 from logicalhan/custom-collectors
add support for parsing custom collectors from the stability framework
2022-11-01 20:00:04 -07:00
Kubernetes Prow Robot
26c88ccee2
Merge pull request #113514 from oscr/update-shellcheck-version
Update shellcheck version (0.7.1 -> 0.7.2) and fix findings
2022-11-01 19:59:57 -07:00
Kubernetes Prow Robot
5899432f92
Merge pull request #113481 from rphillips/fixes/77063
kubelet: fix pod log line corruption when using timestamps and long lines
2022-11-01 19:59:50 -07:00
Kubernetes Prow Robot
9bbd0fbdb2
Merge pull request #113476 from marosset/hpc-to-stable
Promoting WindowsHostProcessContainers to stable
2022-11-01 19:59:43 -07:00
Kubernetes Prow Robot
d377a1fc7b
Merge pull request #113455 from ii/promote-resourcequota-status-test
Promote test for ResourceQuota status to Conformance +3 Endpoints
2022-11-01 19:59:37 -07:00
Kubernetes Prow Robot
9313a1f2a6
Merge pull request #113452 from brianpursley/DBG2
Allow DBG=1 to be used with make release-images and make quick-release-images
2022-11-01 19:59:30 -07:00
Kubernetes Prow Robot
114a54c098
Merge pull request #113450 from neogopher/pv-controller-fix-log-message
docs: Correct the log message for pv controller to make it more accurately descriptive
2022-11-01 19:59:19 -07:00
Kubernetes Prow Robot
7b84436168
Merge pull request #113408 from dashpole/kubelet_context
Plumb context to Kubelet CRI calls
2022-11-01 19:59:08 -07:00
Kubernetes Prow Robot
5c8e3a423f
Merge pull request #113296 from claudiubelu/retrigger-test-images
test images: Retrigger failing images
2022-11-01 19:58:56 -07:00
Kubernetes Prow Robot
4a0bb39d2a
Merge pull request #113282 from xmcqueen/master
Image Version Bump in Manifest for Node Perf Test tf-wide-deep
2022-11-01 19:58:45 -07:00
Sean Sullivan
4ca128d71a Get response content-type 2022-11-02 01:26:04 +00:00
Kubernetes Prow Robot
3edbebe348
Merge pull request #110268 from danwinship/minimize-iptables-changes
minimize iptables-restore input
2022-11-01 18:06:46 -07:00
Kubernetes Prow Robot
b7f5de17ae
Merge pull request #113206 from marseel/fix/fix_estimator_for_serviceaccount_tokens
Fix APF width estimate for creating service account's token
2022-11-01 16:56:45 -07:00
Han Kang
26b7e3a1e9 refactor static analysis code
Change-Id: I888585cc151e97fee08889a57fc20118733a60a5
2022-11-01 15:56:25 -07:00
Kubernetes Release Robot
303e7cbdb0 CHANGELOG: Update directory for v1.26.0-alpha.3 release 2022-11-01 22:49:09 +00:00
Oscar Utbult
421f142ffc Update shellcheck version (0.7.1 -> 0.7.2) and fix findings 2022-11-01 23:10:44 +01:00
Kubernetes Prow Robot
2452a95bd4
Merge pull request #112796 from SataQiu/clean-kubelet-20220930
kubelet: remove the unused constant AnnotationInvalidReason since sysctl annotations are deprecated and migrated to fields
2022-11-01 14:56:45 -07:00
Mark Rossetti
498d065cc5
Promoting WindowsHostProcessContainers to stable
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
2022-11-01 14:06:25 -07:00
Han Kang
12d58d0875 update documentation with custom collector metrics
Change-Id: I78f2ca39bb4750e9596fba171136ffbe3ad35538
2022-11-01 13:57:10 -07:00
Han Kang
c2f67ac141 add support for parsing custom collectors from the stability framework
Change-Id: I1053b9f6956de571700c95b96e05c4377806a3cc
2022-11-01 13:56:57 -07:00
Kubernetes Prow Robot
9b72f20156
Merge pull request #112373 from loktev-d/k8s_109717
Add unit tests for active_deadline.go
2022-11-01 12:54:44 -07:00
Davanum Srinivas
f82e98c5fc
Fix sample-apiserver E2E image build failure
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2022-11-01 15:41:25 -04:00
Kubernetes Prow Robot
1a41cb8985
Merge pull request #113021 from rphillips/fixes/112936
kubelet: fix nil crash in allocateRemainingFrom
2022-11-01 10:46:45 -07:00
Brian Pursley
8a1b48046d Allow DBG=1 to be used with make release-images and make quick-release-images 2022-11-01 13:23:16 -04:00
Kubernetes Prow Robot
e6060f2780
Merge pull request #111220 from giuseppe/drop-superfluous-function
kubelet: remove superfluous function
2022-11-01 09:34:45 -07:00
Kubernetes Prow Robot
2ab2698e4c
Merge pull request #113490 from oscr/add-makefile-target-lint
Add Makefile target lint
2022-11-01 08:24:56 -07:00
Kubernetes Prow Robot
9b5fa57654
Merge pull request #113358 from mengjiao-liu/fix-StatefulSetAutoDeletePVC
StatefulSet: fix kube-controller-manager panic due to StatefulSetPersistentVolumeClaimRetentionPolicy being nil
2022-11-01 08:24:45 -07:00
Ryan Phillips
ddae396ce3 kubelet: fix pod log line corruption when using timestamps and long lines 2022-11-01 09:22:30 -05:00
Kubernetes Prow Robot
7a2984fddf
Merge pull request #113431 from SataQiu/kube-aggregator-20221028
kube-aggregator: remove redundant Scheme registration logic
2022-11-01 07:06:44 -07:00
Kubernetes Prow Robot
2d14d50b31
Merge pull request #113406 from jsafrane/fix-selinux-check-of-mounted
Fix SELinux check of mounted volumes
2022-11-01 04:14:45 -07:00
Kubernetes Prow Robot
22f3e64039
Merge pull request #113320 from chendave/test
kubeadm: simply struct of `joinOptions` by removing `joinControlPlane`
2022-11-01 02:48:45 -07:00
Kubernetes Prow Robot
76ccb69cc1
Merge pull request #113484 from logicalhan/docs
update documentation for stability framework
2022-10-31 21:14:44 -07:00
Dave Chen
3ddedf00e5 kubeadm: add testcases for kubeadm reset
For parity with `init` and `join`, the test file only
covers some basic scenarios and is expected to be expanded
when the config file for `kubeadm reset` is ready.

Signed-off-by: Dave Chen <dave.chen@arm.com>
2022-11-01 11:34:53 +08:00
Kubernetes Prow Robot
7d9c0e0a78
Merge pull request #113411 from jsafrane/fix-selinux-context-mount
Fix SELinux context mount with unknown context
2022-10-31 17:00:44 -07:00
Oscar Utbult
0564fcce0f Add Makefile target lint 2022-10-31 23:57:01 +01:00
Kubernetes Prow Robot
4c657e5014
Merge pull request #110403 from claudiubelu/unittests-3
unittests: Fixes unit tests for Windows (part 3)
2022-10-31 15:52:44 -07:00