Commit Graph

53056 Commits

Author SHA1 Message Date
Jamie Hannaford
abedc49b71 Feature-gate self-hosted secrets 2017-08-16 20:01:01 +02:00
Kubernetes Submit Queue
bc2f049067 Merge pull request #50332 from ianchakeres/local-e2e-mntpnt
Automatic merge from submit-queue (batch tested with PRs 50670, 50332)

e2e test for local storage mount point

**What this PR does / why we need it**:

We discovered that kubernetes can treat local directories and actual mountpoints differently. For example, https://github.com/kubernetes/kubernetes/issues/48331. The current local storage e2e tests use directories.

This PR introduces a test that creates a tmpfs and mounts it, and runs one of the local storage e2e tests.

**Which issue this PR fixes**: fixes https://github.com/kubernetes/kubernetes/issues/49126

**Special notes for your reviewer**:

I cherrypicked PR https://github.com/kubernetes/kubernetes/pull/50177, since local storage e2e tests are broken in master on 2017-08-08 due to "no such host" error. This PR replaces NodeExec with SSH commands.

You can run the tests using the following commands:
``` 
$ NUM_NODES=1 KUBE_FEATURE_GATES="PersistentLocalVolumes=true" go run hack/e2e.go -- -v --up
$ go run hack/e2e.go -- -v --test --test_args="--ginkgo.focus=\[Feature:LocalPersistentVolumes\]"
```

Here are the summary of results from my test run:
```
Ran 9 of 651 Specs in 387.905 seconds
SUCCESS! -- 9 Passed | 0 Failed | 0 Pending | 642 Skipped PASS

Ginkgo ran 1 suite in 6m29.369318483s
Test Suite Passed
2017/08/08 11:54:01 util.go:133: Step './hack/ginkgo-e2e.sh --ginkgo.focus=\[Feature:LocalPersistentVolumes\]' finished in 6m32.077462612s
```

**Release note**:
`NONE`
2017-08-16 01:38:08 -07:00
Kubernetes Submit Queue
ba110e9f08 Merge pull request #50670 from sttts/sttts-verbose-unclean-diff
Automatic merge from submit-queue

Make kube::util::ensure_clean_working_dir more verbose in log files

Makes it easier to understand why files seem to be changed during CI build, especially
autogenerated files like conversions.
2017-08-16 01:04:57 -07:00
Dr. Stefan Schimanski
f763fdc3c1 Make kube::util::ensure_clean_working_dir more verbose in log files 2017-08-16 08:31:07 +02:00
Kubernetes Submit Queue
1d633b7fdd Merge pull request #50116 from MrHohn/fix-healthcheck-nodeport-allocation
Automatic merge from submit-queue

Use nodePortOp for allocating healthCheck nodePort

**What this PR does / why we need it**: Allocate healthCheck nodePort via nodePortOp so that we won't leak port on failure.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49999

**Special notes for your reviewer**:
/assign @xiangpengzhao @thockin 


**Release note**:

```release-note
NONE
```
2017-08-15 21:03:38 -07:00
Kubernetes Submit Queue
da00e92f87 Merge pull request #50514 from mwielgus/ca-0.6.1
Automatic merge from submit-queue

Bump Cluster Autoscaler to 0.6.1

Couple minor bugfixes and godep refresh.

Do not merge until I complete the tests.

```release-note
Cluster Autoscaler - fixes issues with taints and updates kube-proxy cpu request.
```
2017-08-15 17:53:03 -07:00
Marcin Wielgus
aac6f40f4e Bump Cluster Autoscaler to 0.6.1 2017-08-16 02:02:57 +02:00
Kubernetes Submit Queue
a7c69bd5fe Merge pull request #50219 from zhangxiaoyu-zidif/fix-statefulset-test-err-print
Automatic merge from submit-queue

Fix error message of statefulset test

**What this PR does / why we need it**:
Fix error message of statefulset test
It should be 0 replocas in the error message.
And fix typo from Falied to Failed

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes https://github.com/kubernetes/kubernetes/issues/50592

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
2017-08-15 17:00:01 -07:00
Kubernetes Submit Queue
f6929fc089 Merge pull request #50702 from enj/enj/r/inject_policy_hook
Automatic merge from submit-queue (batch tested with PRs 50694, 50702)

Allow injection of policy in RBAC post start hook

This change allows the RBAC PostStartHook logic to be reused with different policy data when bootstrapping the cluster.  Thus any changes to the bootstrap logic are separated from the policy data.

Signed-off-by: Monis Khan <mkhan@redhat.com>

```release-note
NONE
```

@kubernetes/sig-auth-pr-reviews
2017-08-15 14:28:27 -07:00
Kubernetes Submit Queue
c743e68fb1 Merge pull request #50694 from dims/fix-make-cross-problem-with-helpers
Automatic merge from submit-queue (batch tested with PRs 50694, 50702)

Fix make cross build failure

**What this PR does / why we need it**:

had to fix the method getSecurityOpts in helpers_windows.go to
match the implementation in helpers_linux.go from commit:
bf01fa2f00


**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

Fixes #50675

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
2017-08-15 14:28:24 -07:00
Kubernetes Submit Queue
df8287c91d Merge pull request #47998 from danehans/kubeadm_boot
Automatic merge from submit-queue

Adds IPv6 test case to kubeadm bootstrap

**What this PR does / why we need it**:
Adds IPv6 test cases in support of kubeadm bootstrap functionality. It's needed to ensure test cases cover IPv6 related networking scenarios.

**Which issue this PR fixes**
This PR is in support of Issue #1443 and Issue #47666

**Special notes for your reviewer**:
Additional PR's will follow to ensure kubeadm fully supports IPv6.

**Release note**:
```NONE
```

/area ipv6
2017-08-15 13:11:22 -07:00
Kubernetes Submit Queue
4d409a4d9e Merge pull request #48432 from chandanmad/kubectl-set-service-account
Automatic merge from submit-queue (batch tested with PRs 50198, 49051, 48432)

New kubectl command: `kubectl set service-account`

**What this PR does / why we need it**:
Adds a command to update serviceaccount of resources with pod template

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
fixes #45147
**Special notes for your reviewer**:

**Release note**:

```
NONE
```
2017-08-15 12:18:20 -07:00
Kubernetes Submit Queue
21812547f9 Merge pull request #49051 from mtaufen/move-kc-type
Automatic merge from submit-queue (batch tested with PRs 50198, 49051, 48432)

move KubeletConfiguration out of componentconfig API group

I'm splitting #44252 into more manageable steps. This step moves the types and updates references.

To reviewers: the most important changes are the removals from pkg/apis/componentconfig and additions to pkg/kubelet/apis/kubeletconfig. Almost everything else is an import or name update.

I have one unanswered question: Should I create a whole new api scheme for Kubelet APIs rather than register e.g. a kubeletconfig group with the default runtime.Scheme instance? This feels like the right thing, as the Kubelet should be exposing its own API, but there's a big fat warning not to do this in `pkg/api/register.go`. Can anyone answer this?
2017-08-15 12:18:18 -07:00
Kubernetes Submit Queue
722d217e5a Merge pull request #50198 from xiangpengzhao/e2e-nw
Automatic merge from submit-queue (batch tested with PRs 50198, 49051, 48432)

Add prefix to common networking e2e tests

**What this PR does / why we need it**:
Common networking e2e tests shared by node and cluster suites should also have prefix `[sig-network]`.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
Umbrella issue #49161

**Special notes for your reviewer**:
/cc @bowei 

**Release note**:

```release-note
NONE
```
2017-08-15 12:18:15 -07:00
Davanum Srinivas
493ee8b285 Fix make cross build failure
had to fix the method getSecurityOpts in helpers_windows.go to
match the implementation in helpers_linux.go from commit:
bf01fa2f00

Fixes #50675
2017-08-15 14:25:35 -04:00
Monis Khan
751741df59
Allow injection of policy in RBAC post start hook
This change allows the RBAC PostStartHook logic to be reused with
different policy data when bootstrapping the cluster.  Thus any
changes to the bootstrap logic are separated from the policy data.

Signed-off-by: Monis Khan <mkhan@redhat.com>
2017-08-15 14:25:11 -04:00
Kubernetes Submit Queue
039f898c07 Merge pull request #50639 from simo5/setheader
Automatic merge from submit-queue (batch tested with PRs 50023, 50639)

Extend SetHeader Requests method ito accept multiple values

This allows to set headers that are multivalued directly.
The headers variable is not directly accessible and currently
SetHeaders allows to set only one value.

```release-note
NONE
```
2017-08-15 11:23:55 -07:00
Kubernetes Submit Queue
efe47a3988 Merge pull request #50023 from tcharding/kubectl-options
Automatic merge from submit-queue (batch tested with PRs 50023, 50639)

Correct case for starting character of option string

**What this PR does / why we need it**:

Kubectl-conventions.md states:

   "Flag descriptions should start with an uppercase letter and not have a period at the end of a sentence"

There are numerous cases where this is violated in `kubectl/cmd`. This PR is the result of an audit of all source files under `kublet/cmd` and corrects the case of the initial Flag description character.

/sig cli
/kind cleanup
/kind documentation

**Release note**:
```release-note
NONE
```
2017-08-15 11:23:53 -07:00
Kubernetes Submit Queue
6a644c25f8 Merge pull request #50460 from vladimirvivien/set_fakeHost_node_labels_for_test
Automatic merge from submit-queue (batch tested with PRs 50626, 50683, 50679, 50684, 50460)

Specify node labels for fakeVolumeHost

**What this PR does / why we need it**:
Adds ability to set arbitrary node labels to type `fakeVolumeHost`.
Allows creation of tests of code that depends on reading node labels using `fakeVolumeHost.GetNodeLabels() `.

**Release note**:

```release-note
NONE
```
2017-08-15 10:28:30 -07:00
Kubernetes Submit Queue
9d732080f1 Merge pull request #50684 from sttts/sttts-deepcopy-calls-registry
Automatic merge from submit-queue (batch tested with PRs 50626, 50683, 50679, 50684, 50460)

registries: simplify deepcopy calls
2017-08-15 10:28:28 -07:00
Kubernetes Submit Queue
4498ccafc0 Merge pull request #50679 from aknuds1/fluentd-systemd
Automatic merge from submit-queue (batch tested with PRs 50626, 50683, 50679, 50684, 50460)

Base Fluentd image off debian:stretch-slim for systemd with LZ4

To avoid having to copy libsystemd from host system, base off image with LZ4 capable systemd.

Fixes #50242.

```release-notes
fluentd-elasticsearch addon: change the fluentd base image to fix crashes on systems with non-standard systemd installation
```
2017-08-15 10:28:25 -07:00
Kubernetes Submit Queue
eba54ef037 Merge pull request #50683 from sttts/sttts-deepcopy-calls-apiextensions
Automatic merge from submit-queue (batch tested with PRs 50626, 50683, 50679, 50684, 50460)

apiextensions: simplify deepcopy calls
2017-08-15 10:28:23 -07:00
Kubernetes Submit Queue
d72fc055ee Merge pull request #50626 from luxas/kubeadm_separate_apiclient
Automatic merge from submit-queue (batch tested with PRs 50626, 50683, 50679, 50684, 50460)

kubeadm: Centralize client create-or-update logic in one package

**What this PR does / why we need it**:

Moves all Create-or-Update logic into one package instead of duplicating that logic all around in the codebase.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:

This PR depends on https://github.com/kubernetes/kubernetes/pull/50214.
Note that commit 2 is the only one that needs reviewing.
This PR is required for https://github.com/kubernetes/kubernetes/pull/48899 (kubeadm upgrade)

**Release note**:

```release-note
NONE
```
@kubernetes/sig-cluster-lifecycle-pr-reviews @mattmoyer @fabriziopandini
2017-08-15 10:28:21 -07:00
Kubernetes Submit Queue
2d5624bb2c Merge pull request #50681 from sttts/sttts-deepcopy-calls-apiserver
Automatic merge from submit-queue

apiserver: simplify deepcopy calls
2017-08-15 08:31:07 -07:00
Michael Taufen
24bab4c20f move KubeletConfiguration out of componentconfig API group 2017-08-15 08:12:42 -07:00
Kubernetes Submit Queue
28a5ecb91b Merge pull request #50682 from sttts/sttts-deepcopy-calls-apimachinery
Automatic merge from submit-queue (batch tested with PRs 50577, 50682)

apimachinery: simplify deepcopy calls
2017-08-15 07:39:09 -07:00
Arve Knudsen
7e3b8a59dc Base Fluentd image off debian:stretch-slim for systemd with LZ4 2017-08-15 15:55:13 +02:00
Kubernetes Submit Queue
3211d4dde6 Merge pull request #50577 from crassirostris/audit-graceful-shotdown
Automatic merge from submit-queue

advanced audit: shutdown batching audit webhook gracefully

Follow-up of https://github.com/kubernetes/kubernetes/pull/50439

When the `stopCh` passed to the batching audit webhook is closed, it stops accepting new events and when `Shutdown` method is called afterwards, it blocks until the last request to the webhook has finished.

/cc @tallclair @soltysh
2017-08-15 06:54:57 -07:00
Dr. Stefan Schimanski
4df0eec4df registries: simplify deepcopy calls 2017-08-15 15:49:52 +02:00
Lucas Käldström
8c5c3ca197
autogenerated bazel 2017-08-15 15:52:49 +03:00
Lucas Käldström
d725fe2c2c
kubeadm: Centralize client create-or-update logic in one package 2017-08-15 15:52:37 +03:00
Dr. Stefan Schimanski
05e10eb3fb apiextensions: simplify deepcopy calls 2017-08-15 14:42:29 +02:00
Dr. Stefan Schimanski
e7424b64ce apimachinery: simplify deepcopy calls 2017-08-15 14:29:28 +02:00
Mik Vyatskov
7798d32fc7 Implement batching audit webhook graceful shutdown 2017-08-15 14:21:09 +02:00
Dr. Stefan Schimanski
b2442224e7 apiserver: simplify deepcopy calls 2017-08-15 14:19:21 +02:00
Kubernetes Submit Queue
6dc567abb9 Merge pull request #50327 from sttts/sttts-unify-network-types
Automatic merge from submit-queue

Drop extensions internal Network* types

Fixes #46626
2017-08-15 04:57:42 -07:00
Kubernetes Submit Queue
1268c1a1e0 Merge pull request #50638 from nikhita/feature-gates-doc
Automatic merge from submit-queue

FeatureGate: update comments

The godoc - https://godoc.org/k8s.io/apiserver/pkg/util/feature - does not contain descriptions of the functions. This PR adds them.

**Release note**:

```release-note
NONE
```

/cc @sttts
2017-08-15 03:58:23 -07:00
Kubernetes Submit Queue
55160e7cc1 Merge pull request #49322 from bsalamat/priority_admission
Automatic merge from submit-queue

Add Priority admission controller

**What this PR does / why we need it**: Add Priority admission controller. This admission controller checks creation and update of PriorityClasses. It also resolves a PriorityClass name of a pod to its integer value.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
Add Priority admission controller for monitoring and resolving PriorityClasses.
```

ref/ #47604
ref/ #48646
2017-08-15 03:13:15 -07:00
Dr. Stefan Schimanski
6bc9f3fba6 Update generated files 2017-08-15 11:56:46 +02:00
Dr. Stefan Schimanski
b0b5de6eaf Port internal extensions/Network* to networking.k8s.io API group 2017-08-15 11:56:46 +02:00
Kubernetes Submit Queue
4d6db7466c Merge pull request #50439 from sttts/sttts-shutdown-apiservers
Automatic merge from submit-queue

apiservers: add synchronous shutdown mechanism on SIGTERM+INT

This is used to shutdown the auditing backend in order not to drop any pending events on the floor.
2017-08-15 02:27:06 -07:00
Kubernetes Submit Queue
ef0f723bfd Merge pull request #50316 from shashidharatd/flake-fix
Automatic merge from submit-queue

[Federation] Fix flake in TestUpdateClusterRace

**What this PR does / why we need it**:
Fix #50262

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #50262

**Special notes for your reviewer**:
Although we do locking/unlocking while using protected data in ClusterController, there are chances that `clusterClient` can be deleted as it is a pointer. Also its better to lock/unlock once for the function `UpdateClusterStatus` instead of multiple locks/unlocks.

**Release note**:
```
NONE
```

/assign @madhusudancs 
/cc @dminh @kubernetes/sig-federation-bugs
2017-08-15 01:33:51 -07:00
Kubernetes Submit Queue
f59b04b82d Merge pull request #48739 from yguo0905/fix-dup-metrics
Automatic merge from submit-queue

Remove the status of the terminated containers in the summary endpoint

Ref: https://github.com/kubernetes/kubernetes/issues/47853

- When building summary, a container is considered to be terminated if it has an older creation time and no CPU instantaneous or memory RSS usage.
- We remove the terminated containers in the summary by grouping the containers with the same name in the same pod, sorting them in each group by creation time, and skipping the oldest ones with no usage in each group. Let me know if there's simpler way.

**Release note**:
```
None
```
/assign @yujuhong
2017-08-15 00:47:28 -07:00
Dr. Stefan Schimanski
11b25366bc apiservers: add synchronous shutdown mechanism on SIGTERM+INT 2017-08-15 09:17:18 +02:00
Kubernetes Submit Queue
3537f8fa34 Merge pull request #49454 from dixudx/cleanup_DaemonSet_templateGeneration
Automatic merge from submit-queue

Cleanup DaemonSet templateGeneration

**What this PR does / why we need it**:

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49336 

**Special notes for your reviewer**:

/cc @janetkuo @foxish 

~~Depends on #49071~~ (Merged) 

**Release note**:

```release-note
None
```
2017-08-15 00:01:06 -07:00
Kubernetes Submit Queue
cc27673aa9 Merge pull request #50649 from yguo0905/image-desc
Automatic merge from submit-queue (batch tested with PRs 49842, 50649)

Allow passing image description from e2e node test config

Ref: https://github.com/kubernetes/kubernetes/issues/42926

This is the follow up of https://github.com/kubernetes/kubernetes/pull/50479. In https://github.com/kubernetes/kubernetes/pull/50479, we added the tests for cos-m60 with docker 1.12.6. Those tests use the same image name as the existing ones (cos-m60 with docker 1.13.1). So we are not  distinguish them on node-perf-dash, which categories the tests by image names.

This PR fixes the issue by passing image description to the test.

Examples:

https://storage.googleapis.com/ygg-gke-dev-bucket/e2e-node-test/ci-kubernetes-node-kubelet-benchmark/22/artifacts/performance-cpu-cos-docker112-resource2-resource_35.json

https://storage.googleapis.com/ygg-gke-dev-bucket/e2e-node-test/ci-kubernetes-node-kubelet-benchmark/22/artifacts/performance-cpu-cos-resource2-resource_35.json

**Release note**:

```
None
```

/assign @Random-Liu
2017-08-14 23:14:04 -07:00
Kubernetes Submit Queue
bb1e3b09eb Merge pull request #49842 from clairew/v1helper-OpaqueIntResourceName-unit-tests
Automatic merge from submit-queue (batch tested with PRs 49842, 50649)

Add Unit Test: opaque int resource name

**What this PR does / why we need it**: https://github.com/kubernetes/kubernetes/issues/49384, adding unit tests for functions related to the prefix OpaqueIntResourceName in /pkg/api/v1helper

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
2017-08-14 23:14:01 -07:00
Kubernetes Submit Queue
b28b2deed2 Merge pull request #50617 from irfanurrehman/kubefed-doc-fix
Automatic merge from submit-queue (batch tested with PRs 50302, 50573, 50500, 50633, 50617)

[Federation] Kubefed doc fix

Fixes https://github.com/kubernetes/kubernetes/issues/50615
@kubernetes/sig-federation-bugs 
@madhusudancs, would it be of any reason to have separate code for kubefed for the version and options subcommands (rather then using ```kubectl.NewCmdVersion()``` and ```kubectl.NewCmdOptions```). I dont see the need, but I might be missing something. 

**What this PR does / why we need it**:
Fixes https://github.com/kubernetes/kubernetes/issues/50615

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:

**Release note**:

```NONE
```
2017-08-14 20:42:25 -07:00
Kubernetes Submit Queue
7097b64308 Merge pull request #50633 from Cynerva/gkk/fix-labels-flake
Automatic merge from submit-queue (batch tested with PRs 50302, 50573, 50500, 50633, 50617)

Fix kubernetes-worker charm hook failure when applying labels

**What this PR does / why we need it**:

This fixes a failure that can occur in the kubernetes-worker charm when trying to apply node labels.

The failure is rare, and can occur in two situations that I've seen:
1. kube-apiserver is not up yet
2. kubelet has not registered itself as a node yet

Rather than give up right away, let's give the services a minute to come up.

**Release note**:

```release-note
Fix kubernetes-worker charm hook failure when applying labels
```
2017-08-14 20:42:23 -07:00
Kubernetes Submit Queue
a12cf94432 Merge pull request #50500 from shiywang/sortby
Automatic merge from submit-queue (batch tested with PRs 50302, 50573, 50500, 50633, 50617)

add cmd-test for sort-by command

this follow up : https://github.com/kubernetes/kubernetes/pull/48659
/assign @pwittrock 
as your suggestion, cmd-test added, ptal

```release-note
NONE
```
2017-08-14 20:42:20 -07:00