Commit Graph

48059 Commits

Author SHA1 Message Date
Kubernetes Submit Queue
c924414b1f Merge pull request #45548 from justinsb/fix_typo_ss_controller
Automatic merge from submit-queue (batch tested with PRs 45826, 45747, 45548, 45606, 41766)

Fix typo in name of ss controller
2017-05-15 11:39:24 -07:00
Kubernetes Submit Queue
b3031c2c15 Merge pull request #45747 from derekwaynecarr/owner-ref-block-kubelet
Automatic merge from submit-queue (batch tested with PRs 45826, 45747, 45548, 45606, 41766)

OwnerReferencesPermissionEnforcement ignores pods/status

**What this PR does / why we need it**:
It makes the `OwnerReferencesPermissionEnforcement` admission plug-in ignore pods/status operations.  If a cluster has version skew with its master (1.6) and nodes (1.6-N), the kubelet is doing a pods/status operation and that code path is causing an error because ownerRef has new fields unknown to kubelet.

**Release note**:
```release-note
OwnerReferencesPermissionEnforcement admission plugin ignores pods/status.
```
2017-05-15 11:39:21 -07:00
Kubernetes Submit Queue
e9a98cb42b Merge pull request #45826 from deads2k/api-11-ownerreferences
Automatic merge from submit-queue (batch tested with PRs 45826, 45747, 45548, 45606, 41766)

prevent pods/status from touching ownerreferences

pods/status updates touching ownerreferences causes new fields to be dropped.

I think we really want to protect our metatdata by default with something like https://github.com/kubernetes/kubernetes/pull/45552 .  This fixes the immediate problem.

```release-note
prevent pods/status from touching ownerreferences
```

@derekwaynecarr @eparis
2017-05-15 11:39:18 -07:00
Kubernetes Submit Queue
3f054a03a9 Merge pull request #42471 from timchenxiaoyu/resourceytpo
Automatic merge from submit-queue

fix resource typo
2017-05-15 10:39:06 -07:00
Anthony Yeh
729cfda8f3 Merge pull request #45761 from enisoc/v1.6.3-known-issues
CHANGELOG: Add Known Issues for v1.6.3
2017-05-15 12:23:54 -05:00
Kubernetes Submit Queue
885399ca31 Merge pull request #45778 from robermorales/patch-1
Automatic merge from submit-queue

Fix the outdated link to the Helm Charts repo

**What this PR does / why we need it**:

It is only a link fix, the repo URL has changed

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
```
2017-05-15 09:45:25 -07:00
Kubernetes Submit Queue
69eb18d685 Merge pull request #45354 from omeid/patch-1
Automatic merge from submit-queue

docs:examples:guestbook: don't advice untagged image

Using untagged images means no version at all, this can cause weird problems.
Right now, `redis:latest` is no longer compatible with the redis version used in the slave service of the example.
2017-05-15 09:45:17 -07:00
Kubernetes Submit Queue
4c2d900be2 Merge pull request #45814 from CaoShuFeng/unit-test-find
Automatic merge from submit-queue (batch tested with PRs 45807, 45814)

Fix invalid bash script in unit test.

This change fix such error when we run "make test":
    "find: invalid expression; you have used a binary operator '-o' with
     nothing before it."

@deads2k 

**Release note**:

```release-note
```
2017-05-15 09:44:44 -07:00
Kubernetes Submit Queue
330efc10f6 Merge pull request #45807 from xingzhou/typo-fix
Automatic merge from submit-queue (batch tested with PRs 45807, 45814)

Fix typo.
2017-05-15 09:44:41 -07:00
Derek Carr
c20a33c5bd OwnerReferencesPermissionEnforcement ignores pods/status 2017-05-15 12:21:23 -04:00
Kubernetes Submit Queue
161ba1c9a0 Merge pull request #45789 from zhangxiaoyu-zidif/vars-cronjob-sheduledjob-strategy
Automatic merge from submit-queue (batch tested with PRs 45070, 45821, 45732, 45494, 45789)

Rename vars scheduledJob to cronJob

**What this PR does / why we need it**:
Rename vars scheduledJob to cronJob

**Special notes for your reviewer**:
refer to #45480

**Release note**:

```release-note
NONE
```
2017-05-15 07:50:04 -07:00
Kubernetes Submit Queue
fd5146f193 Merge pull request #45494 from ktsakalozos/bug/fix-lint
Automatic merge from submit-queue (batch tested with PRs 45070, 45821, 45732, 45494, 45789)

Fix lint errors in juju kubernetes master and e2e charms

**What this PR does / why we need it**: Fixes style error in the Juju charms

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:

**Release note**:

```
Code style fixes in Juju charms
```
2017-05-15 07:49:57 -07:00
Kubernetes Submit Queue
958bbaaa44 Merge pull request #45732 from sdminonne/apiextension-test
Automatic merge from submit-queue (batch tested with PRs 45070, 45821, 45732, 45494, 45789)

apiextesions-server integration tests: test multiple registration

**What this PR does / why we need it**:
Add integration test for Multiple registrations XREF: #45511

**Special notes for your reviewer**:
@deads2k my first plan was to submit one single PR for both tests but I'm facing one issue with resources deregistration. Get in touch via slack
2017-05-15 07:49:54 -07:00
Kubernetes Submit Queue
9ddd51f476 Merge pull request #45821 from shyamjvs/minor-km-fix
Automatic merge from submit-queue (batch tested with PRs 45070, 45821, 45732, 45494, 45789)

Minor fix in run-gcloud-compute-with-retries output piping

To work with older versions of bash.

cc @wojtek-t @gmarek
2017-05-15 07:49:51 -07:00
Kubernetes Submit Queue
9590b94f7c Merge pull request #45070 from alindeman/container-heap
Automatic merge from submit-queue

Uses container/heap for DelayingQueue

The current implementation of DelayingQueue doesn't perform very well when a large number of items (at random delays) are inserted. The original authors seemed to be aware of this and noted it in a `TODO` comment. This is my attempt at switching the implementation to use a priority queue based on `container/heap`.

Benchmarks from before the change:
```
╰─ go test -bench=. -benchmem | tee /tmp/before.txt
BenchmarkDelayingQueue_AddAfter-8         300000            256824 ns/op             520 B/op          3 allocs/op
PASS
ok      k8s.io/kubernetes/staging/src/k8s.io/client-go/util/workqueue   77.237s
```

After:
```
╰─ go test -bench=. -benchmem | tee /tmp/after.txt
BenchmarkDelayingQueue_AddAfter-8         500000              3519 ns/op             406 B/op          4 allocs/op
PASS
ok      k8s.io/kubernetes/staging/src/k8s.io/client-go/util/workqueue   2.969s
```

Comparison:
```
╰─ benchcmp /tmp/before.txt /tmp/after.txt
benchmark                             old ns/op     new ns/op     delta
BenchmarkDelayingQueue_AddAfter-8     256824        3519          -98.63%

benchmark                             old allocs     new allocs     delta
BenchmarkDelayingQueue_AddAfter-8     3              4              +33.33%

benchmark                             old bytes     new bytes     delta
BenchmarkDelayingQueue_AddAfter-8     520           406           -21.92%
```

I also find the `container/heap`-based code a bit more easy to understand. The implementation of the PriorityQueue is based on the documentation for `container/heap`.

Feedback definitely welcomed. This is one of my first contributions.

```release-note
NONE
```
2017-05-15 07:06:03 -07:00
deads2k
b630e44dee prevent pods/status from touching ownerreferences 2017-05-15 10:05:07 -04:00
Kubernetes Submit Queue
5a1ec9bf6f Merge pull request #45804 from nilebox/nilebox/apiextensions-delegate-handler
Automatic merge from submit-queue

kube-apiextensions-server: Fix potential SEGV with null delegate handler

**What this PR does / why we need it**:
In the kube-apiextensions-server there is a fallback value for `null` delegate to `http.NotFoundHandler()` in handling group and versions discovery, but no fallback for custom resources endpoint.
It leads to SEGV when running with `genericapiserver.EmptyDelegate`.
2017-05-15 06:20:45 -07:00
Kubernetes Submit Queue
337c5390fe Merge pull request #45741 from DirectXMan12/bug/incorrect-autoscaling-discovery-version
Automatic merge from submit-queue

Fix discovery version for autoscaling to be v1

The order of the storage setup blocks in the setup for the autoscaling
API group was accidentally inverted, meaning that if the v2alpha1 API
group was turned on, it would be set to the preferred API group-version
for discovery.

This was unintentional; the latest stable version should (v1) should be
preferred instead.

**Release note**:
```release-note
Ensure that autoscaling/v1 is the preferred version for API discovery when autoscaling/v2alpha1 is enabled.
```
2017-05-15 05:35:49 -07:00
Salvatore Dario Minonne
992544a30c apiextesions-server integration tests: test multiple registration 2017-05-15 13:50:59 +02:00
Shyam Jeedigunta
87cde074f8 Minor fix in run-gcloud-compute-with-retries output piping 2017-05-15 13:39:10 +02:00
Kubernetes Submit Queue
f038c5494e Merge pull request #45798 from shashidharatd/federated-service
Automatic merge from submit-queue

[Federation] Fix federated service reconcilation issue due to addition of External…

…TrafficPolicy field to v1.Service

**What this PR does / why we need it**:
New fields (ExternalTrafficPolicy) are introduced to v1.Service by this PR #41162. If this field is not specified in service spec, the service controller will assign default and updates the service spec.
In federation, the service spec is not updated and we continuously try to reconcile as the federated service and the service in federated cluster do not match.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #45795


**Special notes for your reviewer**:

**Release note**:
```
NONE
```

cc @kubernetes/sig-federation-bugs @madhusudancs
2017-05-15 00:47:17 -07:00
Cao Shufeng
726d720c78 Fix invalid bash script in unit test.
This change fix such error when we run "make test":
    "find: invalid expression; you have used a binary operator '-o' with
     nothing before it."
2017-05-15 15:36:27 +08:00
Kubernetes Submit Queue
885ddcc138 Merge pull request #45601 from dcbw/fix-iptables-crossbuild
Automatic merge from submit-queue

util/iptables: fix cross-build failures due to syscall.Flock()

Fixes: https://github.com/kubernetes/kubernetes/issues/45554
Related: https://github.com/kubernetes/kubernetes/pull/44895

@luxas @k82cn @danwinship
2017-05-14 23:03:43 -07:00
Xing Zhou
a2e68e96cb Fix typo.
Fixed typo.
2017-05-15 14:01:30 +08:00
shashidharatd
d22527522f Fix federated service reconcilation issue due to addition of ExternalTrafficPolicy field to v1.Service 2017-05-15 10:30:51 +05:30
Dan Williams
a4624a0e75 util/iptables: fix cross-build failures due to syscall.Flock()
Fixes: https://github.com/kubernetes/kubernetes/issues/45554
2017-05-14 23:37:52 -05:00
Nail Islamov
0e79b7c91b Fix potential SEGV with null delegate handler 2017-05-15 13:36:51 +10:00
Kubernetes Submit Queue
ad6a9bb78e Merge pull request #44950 from xilabao/use-StringArrayVar-for-ResourceName
Automatic merge from submit-queue

use StringArrayVar for ResourceName

ref to https://github.com/kubernetes/kubernetes/pull/43903

```release-note
`kubectl create role` and `kubectl create clusterrole` no longer allow specifying multiple resource names as comma-separated arguments. Use repeated `--resource-name` arguments to specify multiple resource names. 
```
2017-05-14 19:39:52 -07:00
Kubernetes Submit Queue
c873e4a814 Merge pull request #45694 from nikhiljindal/verifyFedScripts
Automatic merge from submit-queue

Adding missing verify-*.sh scripts for autogenerated federation docs

Fixes https://github.com/kubernetes/kubernetes/issues/41866
2017-05-14 18:49:53 -07:00
nikhiljindal
49b6899232 Autogenerated changes from update-federation-api-reference-docs.sh 2017-05-14 17:20:24 -07:00
nikhiljindal
b3d2e244ea Adding verify-federation-api-reference-docs.sh 2017-05-14 17:20:24 -07:00
nikhiljindal
174e92b24f Adding verify-federation-generated-swagger-docs.sh 2017-05-14 17:20:24 -07:00
nikhiljindal
283e820596 Autogenerated changes from update-federation-swagger-spec.sh 2017-05-14 17:20:23 -07:00
nikhiljindal
2e194763ac Adding verify-federation-swagger-spec.sh 2017-05-14 17:15:41 -07:00
Kubernetes Submit Queue
3227f44157 Merge pull request #45793 from nikhita/add-plural-name
Automatic merge from submit-queue

Add plural name for CustomResources example

**What this PR does / why we need it**: Adds plural name for CustomResources example.

There is no field called `name` for CustomResources. Instead it is `plural`. This will also fail validation (https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kube-apiextensions-server/pkg/apis/apiextensions/validation/validation.go#L33) while executing the instructions mentioned here: https://github.com/kubernetes/kubernetes/issues/45510.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*:

**Special notes for your reviewer**:

**Release note**:

```
NONE
```
@sttts
2017-05-14 11:56:59 -07:00
Nikhita Raghunath
738c6f0d3f
Add plural name for CustomResources example 2017-05-14 23:13:40 +05:30
zhangxiaoyu-zidif
fae13eeec3 Rename vars scheduledJob to cronJob 2017-05-14 22:49:09 +08:00
Kubernetes Submit Queue
4807e6cadf Merge pull request #45430 from vishh/kubelet-gpu-e2e
Automatic merge from submit-queue

Add support for continuous testing of GPU node e2es in GCP.

This PR adds support for testing Nvidia GPUs on Ubuntu 14.04 base image.
2017-05-13 18:12:47 -07:00
Vishnu kannan
d1b4dba440 adding support for gpus in node e2e
Signed-off-by: Vishnu kannan <vishnuk@google.com>
2017-05-13 16:35:54 -07:00
Andy Lindeman
dad64459a9
Uses container/heap 2017-05-13 21:21:11 +00:00
Rober Morales-Chaparro
f21a1919ec Fix the outdated link to the Helm Charts repo 2017-05-13 23:17:24 +02:00
Andy Lindeman
21ca6c498a
Adds benchmark test 2017-05-13 20:35:35 +00:00
Kubernetes Submit Queue
98b5e9d57b Merge pull request #45580 from heartlock/cri-logpath
Automatic merge from submit-queue

Add LogPath for container status in CRI

In order to get log path of container from CRI runtime, we need to add `LogPath` to `ContainerStatus` in CRI.
@Random-Liu @feiskyer
2017-05-12 23:42:29 -07:00
heartlock
8e702347ad set LogPath in dockershim
Signed-off-by: heartlock <21521209@zju.edu.cn>
2017-05-13 03:24:44 +00:00
heartlock
c3b52267ca add LogPath for container status in CRI Interface
Signed-off-by: heartlock <21521209@zju.edu.cn>
2017-05-13 03:20:17 +00:00
Anthony Yeh
76a00fa828
CHANGELOG: Add Known Issues for v1.6.3 2017-05-12 18:51:16 -07:00
Kubernetes Submit Queue
ce4f010b01 Merge pull request #45553 from jcbsmpsn/init-certificate-manager-no-client
Automatic merge from submit-queue (batch tested with PRs 42759, 45553)

Allow certificate manager to be initialized with client.

Add test coverage to the certificate manager covering the initialization
scenario where it is initialized with no Certificate Request Signing
client, then the client is added later. This matches how it will be used
when the Certificate Request Signing client is also the consumer of the
certificate manager.
2017-05-12 17:48:39 -07:00
Kubernetes Submit Queue
3619c33350 Merge pull request #42759 from mtaufen/kubelet-apis-reorg
Automatic merge from submit-queue

Reorganize kubelet tree so apis can be independently versioned

@yujuhong @lavalamp @thockin @bgrant0607 
This is an example of how we might reorganize `pkg/kubelet` so the apis it exposes can be independently versioned. This would also provide a logical place to put the `KubeletConfiguration` type, which currently lives in `pkg/apis/componentconfig`; it could live in e.g. `pkg/kubelet/apis/config` instead.

Take a look when you have a chance and let me know what you think. The most significant change in this PR is reorganizing `pkg/kubelet/api` to `pkg/kubelet/apis`, the rest is pretty much updating import paths and `BUILD` files.
2017-05-12 17:43:22 -07:00
Kubernetes Submit Queue
abaffb243e Merge pull request #45692 from caesarxuchao/limit-client-go-package-import-2
Automatic merge from submit-queue (batch tested with PRs 44748, 45692)

Limiting client go packages visibility, round 3

Continue the work in the merged PR https://github.com/kubernetes/kubernetes/pull/45258

These packages in client-go will be gone after #44065 is fixed:
pkg/api/helper, pkg/api/util, internal version of api groups, API install packages. 

This PR removes the dependency on these packages and add bazel visibility rules to prevent relapse.
2017-05-12 16:04:37 -07:00
Kubernetes Submit Queue
521badc4b7 Merge pull request #44748 from zhangxiaoyu-zidif/cleancode-1-graph_builder
Automatic merge from submit-queue

cleancode: graph_builder.go

It make the code clean and light.
2017-05-12 15:35:42 -07:00