Commit Graph

128842 Commits

Author SHA1 Message Date
YamasouA
6d291ddc21 fix lint 2025-02-13 23:41:00 +09:00
YamasouA
a9ee6bdf81 use *e.tCtx 2025-02-13 23:33:13 +09:00
YamasouA
cc87cb54ab delete unneccesary define 2025-02-13 23:13:57 +09:00
YamasouA
3ce36b3b3c rename doXXX to runXXX 2025-02-13 23:11:43 +09:00
YamasouA
d202a683f5 rename workloadExecutor member name 2025-02-13 23:04:54 +09:00
YamasouA
c40e69bb4c remove double comments 2025-02-13 23:02:41 +09:00
Rodrigo Campos
3725c6f765 pkg/kubelet: Make newTestKubeletWithImageList allocate a userns manager
When switching the feature flag to on by default, this test was failing:

	I0213 14:42:45.311186  341895 factory.go:193] Registered Plugin "containerd"
	I0213 14:42:45.315673  341895 plugins.go:615] "Loaded volume plugin" pluginName="fake"
	I0213 14:42:45.315750  341895 kubelet_pods.go:1165] "Clean up pod workers for terminated pods"
	I0213 14:42:45.315759  341895 kubelet_pods.go:1215] "Clean up probes for terminated pods"
	I0213 14:42:45.315764  341895 kubelet_pods.go:1219] "Clean up orphaned pod statuses"
	I0213 14:42:45.315768  341895 kubelet_pods.go:1223] "Clean up orphaned pod user namespace allocations"
	--- FAIL: TestKubelet_HandlePodCleanups (0.00s)
	    --- FAIL: TestKubelet_HandlePodCleanups/missing_pod_is_requested_for_termination_with_short_grace_period (0.00s)
	panic: runtime error: invalid memory address or nil pointer dereference [recovered]
		panic: runtime error: invalid memory address or nil pointer dereference
	[signal SIGSEGV: segmentation violation code=0x1 addr=0x38 pc=0x2b14d7e]

	goroutine 142 [running]:
	testing.tRunner.func1.2({0x30b5260, 0x5cfa1e0})
		/usr/lib/go-1.23/src/testing/testing.go:1632 +0x230
	testing.tRunner.func1()
		/usr/lib/go-1.23/src/testing/testing.go:1635 +0x35e
	panic({0x30b5260?, 0x5cfa1e0?})
		/usr/lib/go-1.23/src/runtime/panic.go:785 +0x132
	k8s.io/kubernetes/pkg/kubelet/userns.(*UsernsManager).CleanupOrphanedPodUsernsAllocations(0x0, {0x5d90f80, 0x0, 0x0?}, {0xc0006a1d50, 0x1, 0x0?})
		/home/rodrigo/src/kinvolk/kubernetes/kubernetes/pkg/kubelet/userns/userns_manager.go:474 +0x9e
	k8s.io/kubernetes/pkg/kubelet.(*Kubelet).HandlePodCleanups(0xc00067c808, {0x3b876b0, 0x5d90f80})
		/home/rodrigo/src/kinvolk/kubernetes/kubernetes/pkg/kubelet/kubelet_pods.go:1224 +0x618
	k8s.io/kubernetes/pkg/kubelet.TestKubelet_HandlePodCleanups.func35(0xc0001349c0)
		/home/rodrigo/src/kinvolk/kubernetes/kubernetes/pkg/kubelet/kubelet_pods_test.go:6415 +0x72d
	testing.tRunner(0xc0001349c0, 0xc0009801b0)
		/usr/lib/go-1.23/src/testing/testing.go:1690 +0xf4
	created by testing.(*T).Run in goroutine 141
		/usr/lib/go-1.23/src/testing/testing.go:1743 +0x390
	exit status 2
	FAIL	k8s.io/kubernetes/pkg/kubelet	0.029s

The issue is that no userns manager is allocated in the FakeKubelet.
Let's allocate one.

Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
2025-02-13 15:00:07 +01:00
Rodrigo Campos
96c2b81670 features: Enable user namespaces by default
The feature gate UserNamespacesSupport is enabled by default now
(KEP 127): https://github.com/kubernetes/enhancements/pull/5118.

Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
2025-02-13 15:00:07 +01:00
Kubernetes Prow Robot
e62ce1c9db
Merge pull request #129489 from elizabeth-dev/replace-network-e2e-replicationcontrollers
test(network): replace jig.CreateRC with jig.CreateDeployment
2025-02-13 05:58:22 -08:00
Patrick Ohly
447c74ca2c DRA E2E: fix race between container start and check
Previously, "env" ran as the command inside the container and its log output
was checked. That suffered from a race because even though the pod might be
reported as running, there's no guarantee that the command has really produced
output and that this output has been captured.

Instead, explicitly running the command inside the pause container is safer
because it ensures that the full output of the command gets returned.
2025-02-13 14:49:38 +01:00
Elizabeth Martin Campos
4724870b97
test: remove implicit inclusion of "name" label in utils functions 2025-02-13 12:48:30 +01:00
Akihiro Suda
d6a6dda2fa
KEP-3857: Recursive Read-only (RRO) mounts: promote to GA
Discussed in kubernetes/enhancements PR 5157

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2025-02-13 20:43:35 +09:00
Kubernetes Release Robot
2642d8222d CHANGELOG: Update directory for v1.32.2 release 2025-02-13 09:39:00 +00:00
Kubernetes Release Robot
976eae5ee7 CHANGELOG: Update directory for v1.31.6 release 2025-02-13 08:29:30 +00:00
Kubernetes Release Robot
fc219cd384 CHANGELOG: Update directory for v1.29.14 release 2025-02-13 08:29:18 +00:00
Kubernetes Release Robot
08ea6ca8da CHANGELOG: Update directory for v1.30.10 release 2025-02-13 08:26:27 +00:00
Kubernetes Prow Robot
11ec99f7ff
Merge pull request #130127 from carlory/fix-metrics
GetRandomReadySchedulableNode does not return MetricsGrabbingDisabledError
2025-02-13 00:12:20 -08:00
Kubernetes Prow Robot
ea50baedcd
Merge pull request #129875 from pohly/golangci-lint-strict-removal
golangci-lint: remove "strict" checking
2025-02-12 20:26:20 -08:00
carlory
93a88f5518 GetRandomReadySchedulableNode nerver return MetricsGrabbingDisabledError
Signed-off-by: carlory <baofa.fan@daocloud.io>
2025-02-13 12:00:42 +08:00
Kubernetes Prow Robot
215a9101a7
Merge pull request #130123 from marosset/windows-unit-test-skip-ippvs-test-cases
skipping InPlacePodVerticleScaling unit tests on Windows
2025-02-12 17:10:20 -08:00
Mark Rossetti
ec165ca560
fixing k8s.io/kubernetes/pkg/kubelet/eviction unit tests on Windows
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
2025-02-12 16:57:19 -08:00
Mark Rossetti
df1e9eeeb8
skipping InPlacePodVerticleScaling unit tests on Windows
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
2025-02-12 15:57:20 -08:00
Mark Rossetti
569eb41f23
fixing k8s.io/kubernetes/pkg/kubelet/cm/memorymanager unit tests on Windows
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
2025-02-12 15:27:58 -08:00
Kubernetes Prow Robot
d7db75ce91
Merge pull request #130039 from p0lyn0mial/upstream-fake-client-improve-unit-test
fake/clientset: improve TestNewSimpleClientset
2025-02-12 15:16:27 -08:00
Kubernetes Prow Robot
f38fca82dc
Merge pull request #130024 from sivchari/propagate-context
Propagate cotnext to avoid goroutine leak
2025-02-12 15:16:19 -08:00
Kubernetes Prow Robot
fbdf8905ea
Merge pull request #130058 from gjkim42/add-disableLegacySidecarContainers
Add LegacySidecarContainers feature gate
2025-02-12 13:16:27 -08:00
Kubernetes Prow Robot
5d57d0c110
Merge pull request #129845 from bitoku/fix-flake
Reduce the number of processes used in e2e to prevent unexpected OOM
2025-02-12 13:16:20 -08:00
Kubernetes Prow Robot
5e1c31b9db
Merge pull request #130053 from iholder101/bugfix/swap-resource-metrics-e2e-bug
[KEP-2400] [failing-test] resource metrics e2e tests: expect swap node and container level stats
2025-02-12 12:02:28 -08:00
Kubernetes Prow Robot
cd2959b798
Merge pull request #127525 from scott-grimes/patch-1
fix: pods meeting qualifications for static placement when cpu-manager-policy=static should not have cfs quota enforcement
2025-02-12 12:02:21 -08:00
Kubernetes Prow Robot
be80fec686
Merge pull request #130102 from marosset/bump-windows-pause-image-base
Bump windows pause image base to mcr.microsoft.com/oss/kubernetes/windows-pause-image-base:v0.4.1
2025-02-12 10:48:27 -08:00
Kubernetes Prow Robot
f77a1728be
Merge pull request #130009 from kannon92/fix-runtime-class-flake
aim to fix runtime class error
2025-02-12 10:48:20 -08:00
Lucas Rattz
f8728b6222 Bump konnectivity-client to v0.31.2 2025-02-12 18:47:51 +00:00
Ayato Tokubi
dbb34a04cc Reduce the number of processes used in e2e to prevent unexpected OOM
Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
2025-02-12 17:39:56 +00:00
Kubernetes Prow Robot
75909b8920
Merge pull request #130113 from AwesomePatrol/129931-fix-3
Make ResourceQuota LIST requests only when Informer is not synced
2025-02-12 07:24:06 -08:00
Kubernetes Prow Robot
a62752db51
Merge pull request #130110 from neolit123/1.33-remove-from-test-owners
sig-cl: update owners for 1.33
2025-02-12 05:22:06 -08:00
Aleksander Mistewicz
b346ac0f8e Limit ResourceQuota LIST requests to times when informer is not synced
This should reduce the number of slow (100ms) LIST requests when there
are no ResourceQuota objects present in the namespace. The behavior
stays virtually the same.
2025-02-12 13:46:09 +01:00
Swati Sehgal
def9520217 node: topology-mgr: Add metadata to logs
Ensure that if possible, we provide sufficient metadata in logs.

Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
2025-02-12 12:25:40 +00:00
Kubernetes Prow Robot
48812f0fc4
Merge pull request #130106 from cpanato/update-rules
update publishing rules to use go1.22.12 for some active release branches
2025-02-12 04:00:07 -08:00
Gunju Kim
f2f4634bd3 Add LegacySidecarContainers feature gate
This adds LegacySidecarContainers feature gate that enables the legacy
code path that predates the SidecarContainers feature to safely remove
the code.

This temporary feature gate is disabled by default, only available in
v1.33, and will be removed in v1.34.
2025-02-12 20:15:49 +09:00
Lubomir I. Ivanov
54e2416210 update sig cl owners in k/k 2025-02-12 11:04:11 +02:00
carlory
da2f36be58 remove NodeOSDistroIs from test/e2e/framework/pod 2025-02-12 15:33:37 +08:00
cpanato
358afb38f5
update publishing rules to use go1.22.12 for some active release branches
Signed-off-by: cpanato <ctadeu@gmail.com>
2025-02-11 23:19:45 -06:00
carlory
c83a5e0ad2 HonorPVReclaimPolicy: add more e2e tests
Signed-off-by: carlory <baofa.fan@daocloud.io>
2025-02-12 11:01:39 +08:00
Dan Winship
e31a3989fc Make kubelet always canonicalize the PodIPs 2025-02-11 21:46:15 -05:00
Dan Winship
6512de76ce Make EndpointSlice mirroring controller always canonicalize the IPs it writes out
(Also rearrange some code to avoid parsing the IP twice.)
2025-02-11 21:46:15 -05:00
Dan Winship
29be52b3f7 Make EndpointSlice controller always canonicalize the IPs it writes out 2025-02-11 21:46:15 -05:00
Dan Winship
7259742e23 Make Endpoints controller always canonicalize the IPs it writes out
Also, fix the unit tests to not sometimes generate alleged pod IPs
like "1.2.3.999".
2025-02-11 21:46:13 -05:00
Mark Rossetti
26fe80855d
Update build/pause/Makefile
pin windows-pause-image-base to specific manifest digest

Co-authored-by: Benjamin Elder <bentheelder@google.com>
2025-02-11 16:55:05 -08:00
Mark Rossett
faa23642f5
Bump windows pause image base to mcr.microsoft.com/oss/kubernetes/windows-pause-image-base:v0.4.1
Signed-off-by: Mark Rossett <marosset@microsoft.com>
2025-02-11 15:47:20 -08:00
Dan Winship
1bd3d34d6f Remove some dead code in the Endpoints controller
There was code to deal with upgrades from pre-dual-stack-aware
apiservers, with a note to "remove when the possibility of upgrading
from a cluster that does not support dual stack is nil".

(This requires fixing the unit tests to fill in
service.Spec.IPFamilies like a modern apiserver would do.)
2025-02-11 18:11:56 -05:00