Patrick Ohly
d685064ff7
DRA API: search/replace v1alpha3 -> v1beta1
2024-11-06 13:03:18 +01:00
Patrick Ohly
f1e5616f05
DRA API: verbatim copy of v1alpha3 -> v1beta1
2024-11-06 13:03:18 +01:00
Patrick Ohly
99acb67c68
DRA API: enhance validation testing
...
The line coverage is now at 98.5% and several more corner cases are
covered. The remaining lines are hard or impossible to reach.
The actual validation is the same as before, with some small tweaks to the
generated errors.
When failures are not as expected, it is useful to show what the expected and
actual failures look like to a user. Perhaps even better would be to put the
expected texts into the test files instead of the error structs. That would
be easier to review and shorter.
2024-11-06 13:03:18 +01:00
Patrick Ohly
51d5992335
DRA API: fix some comments
...
Wording in one case was wrong. The tombstone comment should use
the same field definition as before the removal.
2024-11-06 11:05:05 +01:00
Patrick Ohly
7b3a9afca3
DRA kubelet: add v1beta1 gRPC API
...
The v1beta1 API is identical to the previous v1alpha4, which erroneously was
still called "v1alpha3" in a few places, including the gRPC interface
definition itself.
The only reason for v1beta1 is to document the increased maturity of this API.
To simplify the transition, kubelet supports both v1alpha4 and v1beta1, picking
the more recent one automatically. All that DRA driver authors need to do to
implement v1beta1 is to update to the latest
k8s.io/dynamic-resource-allocation/kubeletplugin: it will automatically
register both API versions unless explicitly configured otherwise, which is
mostly just for testing.
DRA driver authors may replace their package import of v1alpha4 with v1beta1,
but they don't have to because the types in both packages are the same.
2024-11-06 11:05:05 +01:00
Kubernetes Prow Robot
f451aec237
Merge pull request #128296 from AnishShah/kubectl-resize
...
[FG:InPlacePodVerticalScaling] Remove restrictions on subresource flag in kubectl commands
2024-11-06 10:01:45 +00:00
Kubernetes Prow Robot
833ee8502e
Merge pull request #128194 from AnishShah/extended-resource
...
test: refactor logic to add/remove extended resources
2024-11-06 10:01:37 +00:00
Kubernetes Prow Robot
0fad78930f
Merge pull request #127904 from towca/jtuznik/dra-autoscaling
...
DRA: allow Cluster Autoscaler to integrate with DRA scheduler plugin
2024-11-06 10:01:29 +00:00
Kubernetes Prow Robot
ab4b869b52
Merge pull request #128590 from benluddy/protobuf-storage-integration-test
...
Add integration test for per-resource storage encoding.
2024-11-06 08:51:44 +00:00
Kubernetes Prow Robot
89c1925e23
Merge pull request #128582 from pohly/dra-resourceslice-unit-test-fix
...
DRA resource slice controller: fix unit test flake
2024-11-06 08:51:36 +00:00
Kubernetes Prow Robot
3dcad5f0db
Merge pull request #128532 from neolit123/1.32-handle-custom-addreses-comp-readyz
...
kubeadm: use advertise address for WaitForAllControlPlaneComponents
2024-11-06 08:51:29 +00:00
Anish Shah
e1ca63489f
kubectl: remove subresource restrictions from all commands
...
Removing this restrictions will allow us to use these commands with the
new resize subresource.
2024-11-05 23:06:40 -08:00
Kubernetes Prow Robot
aafcf4e932
Merge pull request #128453 from tallclair/cacheless-pleg
...
Cleanup unused cacheless PLEG code
2024-11-06 06:59:35 +00:00
Kubernetes Prow Robot
648717cc74
Merge pull request #128266 from AnishShah/resize-subresource
...
[FG:InPlacePodVerticalScaling] Introduce /resize subresource to request pod resource resizing
2024-11-06 06:59:29 +00:00
Kubernetes Prow Robot
b631dae569
Merge pull request #128584 from thockin/compartmentalize_spew
...
Compartmentalize spew more
2024-11-06 04:19:51 +00:00
Kubernetes Prow Robot
a50b4e52a9
Merge pull request #128553 from thockin/master
...
Validation: merge TooLong and TooLongMaxLen
2024-11-06 04:19:43 +00:00
Kubernetes Prow Robot
5e0b818ff9
Merge pull request #128551 from tallclair/allocated-checkpoint
...
[FG:InPlacePodVerticalScaling] Don't checkpoint ResizeStatus
2024-11-06 04:19:36 +00:00
Kubernetes Prow Robot
bf75546494
Merge pull request #128432 from zhifei92/integrating-health-check
...
Integrate device plugin registration gRPC server health checks.
2024-11-06 04:19:29 +00:00
Ben Luddy
006146f58f
Add integration test for per-resource storage encoding.
2024-11-05 22:38:46 -05:00
Kubernetes Prow Robot
ce81cc70a6
Merge pull request #128403 from carlory/fix-128385
...
Fix failing test: PodRejectionStatus Kubelet should reject pod when the node didn't have enough resource
2024-11-06 02:29:36 +00:00
Kubernetes Prow Robot
8c5472ce66
Merge pull request #128189 from zylxjtu/bug
...
Fix the incorrect metrics setting/naming in nodeshutdown manager
2024-11-06 02:29:29 +00:00
Anish Shah
bfb0b83d45
update codegen
2024-11-06 01:43:50 +00:00
Anish Shah
e55bf09ca5
Fix unit tests
2024-11-06 01:33:16 +00:00
Anish Shah
5b5e4a87c3
apply feedback
2024-11-06 01:33:16 +00:00
Anish Shah
332d794559
remove redundant validation check for pod resize
2024-11-06 01:33:15 +00:00
Anish Shah
832d7f7dc2
apply feedback
2024-11-06 01:33:15 +00:00
Anish Shah
4c69bf2496
implement GetResetFieldsFilter
...
GetResetFieldsFilter returns a set of fields filter reset
by pod resize strategy. This is needed to make server-side apply
work correctly.
2024-11-06 01:33:15 +00:00
Anish Shah
0a80c5ecb7
better variable names
2024-11-06 01:33:15 +00:00
Anish Shah
79f45bce19
client-go: rename Resize to UpdateResize
2024-11-06 01:33:15 +00:00
Anish Shah
3b91edb660
unit tests to ensure pod metadata cannot be updated during resize.
2024-11-06 01:33:15 +00:00
Anish Shah
7ac302b47a
test: cleanup validation tests
2024-11-06 01:33:15 +00:00
Anish Shah
dc3c4ed559
pod resize support in LimitRanger admission plugin
2024-11-06 01:33:15 +00:00
Anish Shah
1b98fe6079
support for resize subresource in ResourceQuota admission.
2024-11-06 01:33:15 +00:00
Anish Shah
277edcdb48
update codegen
2024-11-06 01:33:15 +00:00
Anish Shah
7e3ae1060f
integration: RBAC tests for /resize request
...
The test confirms that the subject can successfully
resize the Pod resources but not the entire pod.
2024-11-06 01:33:14 +00:00
Anish Shah
ce0f4597d3
fix error message for pod resize validation failure
2024-11-06 01:33:14 +00:00
Anish Shah
07ca0b09bb
refactor logic to override pod fields
2024-11-06 01:33:14 +00:00
Anish Shah
878c54fc9a
test: add unit tests to verify the .status.resize field
2024-11-06 01:33:14 +00:00
Anish Shah
f1093962b6
integration tests for pod resize
2024-11-06 01:33:14 +00:00
Anish Shah
33a3d7578b
e2e: Use resize subresource in e2e tests
2024-11-06 01:33:14 +00:00
Anish Shah
d9a1d861f7
api: generate client code for resize subresource
2024-11-06 01:33:14 +00:00
Anish Shah
2bf1f2349c
validate resize request
...
We validate resize request by ensuring that pod QoS is unchanged and
only cpu and memory resources and resize policies are mutated.
2024-11-06 01:33:14 +00:00
Anish Shah
8f967c19b3
drop unrelated changes for /resize request
...
Since resize request takes the full pod object as the request type, drop
any unrelated changes. Only container resources and resize policy should
be validated.
2024-11-06 01:33:13 +00:00
Anish Shah
507ce443b0
introduce resize REST object
...
This commit introduces a basic REST object for resize subresource and
adds it to the pod storage.
2024-11-06 01:33:13 +00:00
Anish Shah
6191879999
apply feedback
2024-11-05 17:14:53 -08:00
Kubernetes Prow Robot
67a4d20970
Merge pull request #128505 from Jefftree/fix-cle-lock-acquisition
...
Fix CLE leader lock acquisition
2024-11-06 00:35:42 +00:00
Kubernetes Prow Robot
98b4ee6bfa
Merge pull request #126525 from dshebib/addSidecarE2EImgTest
...
Restart sidecar container when the image has changed
2024-11-06 00:35:35 +00:00
Kubernetes Prow Robot
2f3da71f99
Merge pull request #121206 from mochizuki875/fix_startup_probe_117153
...
Stop StartupProbe explicity when successThrethold is reached
2024-11-06 00:35:28 +00:00
Tim Allclair
ea53083c14
Don't checkpoint ResizeStatus
2024-11-05 15:48:35 -08:00
Tim Allclair
4a4748d23c
Determine resize status from state in handlePodResourcesResize
2024-11-05 15:41:49 -08:00
