Commit Graph

75619 Commits

Author SHA1 Message Date
Ismo Puustinen
ecb6d13253 hack/lib/util.sh: fix empty array expansion with bash 3. 2019-03-05 21:34:08 +02:00
Kubernetes Prow Robot
257205d656
Merge pull request #74811 from gnufied/fix-attachable-csi-mock-driver
When checking for pod info version, make volume attachable
2019-03-05 06:51:39 -08:00
Kubernetes Prow Robot
298b8869cf
Merge pull request #74800 from danielqsj/mgo
fix golint failures for some files under metrics k8s.io/metrics/pkg/apis
2019-03-05 06:51:20 -08:00
Kubernetes Prow Robot
e24e26fac8
Merge pull request #74647 from danielqsj/e2ein
Fix golint failures for e2e/instrumentation/...
2019-03-05 06:51:10 -08:00
Kubernetes Prow Robot
ad36156f14
Merge pull request #74638 from liucimin/fix_e2e_test_kubadm-
Typo fix in e2e test description  message: kubadm->kubeadm
2019-03-05 06:50:59 -08:00
Kubernetes Prow Robot
890b5c1d9a
Merge pull request #74582 from SataQiu/fix-golint-2019022602
fix some golint failures for plugin/pkg/admission/...
2019-03-05 06:50:46 -08:00
Kubernetes Prow Robot
6c31101257
Merge pull request #74283 from xing-yang/csi_crd_controller
CSINodeInfo and CSIDriver Controller Changes
2019-03-05 04:44:42 -08:00
Kubernetes Prow Robot
43616fc920
Merge pull request #74033 from bart0sh/PR0060-kubeadm-975-RequiredIPVSKernelModulesAvailable-warning-seems-confusing
kubeadm: fix RequiredIPVSKernelModulesAvailable warning message
2019-03-05 02:04:03 -08:00
Kubernetes Prow Robot
02bd34e7b0
Merge pull request #74531 from liggitt/ingress-rbac
Update RBAC roles for networking.k8s.io ingresses
2019-03-05 00:48:01 -08:00
Kubernetes Prow Robot
baf4eb67ac
Merge pull request #74257 from ipuustin/lib-util-sh
Fix shellcheck-reported errors in hack/lib/util.sh.
2019-03-04 23:11:59 -08:00
Kubernetes Prow Robot
f5574bf62a
Merge pull request #74603 from stevesloka/e2eImageList
Refactor to allow for a way to get list of e2e images
2019-03-04 19:27:47 -08:00
Kubernetes Prow Robot
9d0baa75f2
Merge pull request #74563 from vanduc95/fix-error-string
fix error string should not be capitalized
2019-03-04 19:27:36 -08:00
Kubernetes Prow Robot
35c9624fd6
Merge pull request #74500 from sandeeppsunny/fix-e2e-tests
Change to unblock e2e tests for vsphere provider
2019-03-04 19:27:25 -08:00
Kubernetes Prow Robot
e2f42845d1
Merge pull request #74487 from danielqsj/window
Fix golint failures for e2e/windows
2019-03-04 19:27:11 -08:00
Kubernetes Prow Robot
dba8300e52
Merge pull request #74391 from cofyc/fix71237-update-old
Update old local tests to use general host executor and local test resource manager
2019-03-04 19:27:00 -08:00
Kubernetes Prow Robot
95cd1d59e4
Merge pull request #74209 from monotek/fluentd-helm-readme
added production note about EFK stack to the readme
2019-03-04 17:55:12 -08:00
Xing Yang
d69e0ff3f0 Enable CSI test suite and fix test failures 2019-03-04 16:42:13 -08:00
Xing Yang
85867e5625 Modify node admission and node authorizer 2019-03-04 16:42:12 -08:00
Xing Yang
6265f4f78c CSINodeInfo/CSIDriver controller changes
This is the 2nd PR to move CSINodeInfo/CSIDriver APIs to
v1beta1 core storage APIs. It includes controller side changes.
It depends on the PR with API changes:
https://github.com/kubernetes/kubernetes/pull/73883
2019-03-04 16:41:58 -08:00
Aaron Crickenberger
feb0937fa4
Merge pull request #74902 from liggitt/regen-proto
Update generated protobuf files
2019-03-04 15:52:03 -08:00
danielqsj
ae7c1187bf fix init pattern 2019-03-05 07:21:55 +08:00
danielqsj
5cf1950ef8 Fix golint in test/e2e/instrumentation/logging 2019-03-05 07:10:39 +08:00
danielqsj
873fbf9112 Fix golint in test/e2e/instrumentation/monitoring 2019-03-05 07:07:06 +08:00
Kubernetes Prow Robot
79e8a29544
Merge pull request #74852 from dims/expand-reviewers-approvers-add-label
Expand reviewers/approvers and add labels for conformance image
2019-03-04 13:25:50 -08:00
Kubernetes Prow Robot
dddb13c690
Merge pull request #74711 from SataQiu/fix-golint-2019022802
Fix golint failures in staging/src/k8s.io/apiserver/pkg/storage/errors, staging/src/k8s.io/apiserver/pkg/storage/etcd
2019-03-04 13:25:38 -08:00
Kubernetes Prow Robot
5756eea804
Merge pull request #74700 from SataQiu/fix-golint-20190228
Fix golint failures in test/e2e/instrumentation, test/e2e_node/environment
2019-03-04 13:25:26 -08:00
Ismo Puustinen
f7e1058c98 shellcheck failures: remove hack/lib/util.sh 2019-03-04 23:23:20 +02:00
Ismo Puustinen
1e34d9df7d hack/lib/util.sh: replace sed with bash replace.
Test script:

  #!/bin/bash

  rev1="foo"
  rev2="\"bar\""
  rev3="'bar'"

  newrev1="${rev1//[\'\"]}"
  newrev2="${rev2//[\'\"]}"
  newrev3="${rev3//[\'\"]}"

  oldrev1=$(echo "${rev1}" | sed "s/['\"]//g")
  oldrev2=$(echo "${rev2}" | sed "s/['\"]//g")
  oldrev3=$(echo "${rev3}" | sed "s/['\"]//g")

  echo "$newrev1 vs. $oldrev1"
  echo "$newrev2 vs. $oldrev2"
  echo "$newrev3 vs. $oldrev3"

expected output:

  foo vs. foo
  bar vs. bar
  bar vs. bar
2019-03-04 23:23:20 +02:00
Ismo Puustinen
0078fce5bd hack/lib/util.sh: don't implicitly convert "find" results into array.
Also fix array item comparison. Test script for the comparison change:

  #!/bin/bash

  staging_apis=(extensions/v1beta1 extensions/v1 extensions/v1alpha)
  group_versions=(v1 extensions/v1beta1 extensions/v1 extensions.k8s.io/v1)

  for group_version in ${group_versions[@]}; do
    # original code
    if [[ " ${staging_apis[@]} " =~ " ${group_version/.*k8s.io/} " ]]; then
      echo "orig: vendor/k8s.io/api/${group_version/.*k8s.io/}"
    fi
    # new code
    for api in ${staging_apis[@]}; do
      if [[ "${api}" = "${group_version/.*k8s.io/}" ]]; then
        echo "new: vendor/k8s.io/api/${group_version/.*k8s.io/}"
      fi
    done
  done

Expected output:

  orig: vendor/k8s.io/api/extensions/v1beta1
  new: vendor/k8s.io/api/extensions/v1beta1
  orig: vendor/k8s.io/api/extensions/v1
  new: vendor/k8s.io/api/extensions/v1
  orig: vendor/k8s.io/api/extensions/v1
  new: vendor/k8s.io/api/extensions/v1
2019-03-04 23:23:20 +02:00
Ismo Puustinen
edd806330a hack/lib/util.sh: mark variables to be used in a sourcing context.
"Decorate" the variables with a no-op function to prevent shellcheck
from complaining that they are not being used. This method provides
visibility to which variables are supposed to be used in a sourcing
script compared to just disabling the warning.
2019-03-04 23:23:20 +02:00
Ismo Puustinen
24b5c67723 hack/lib/util.sh: various shellcheck-reported cleanups.
Use "command -v" instead of "which".  Also remove the redirections,
since "command -v" does not return an error message if the command isn't
found. Also use "read -r" instead of "read" and quote variables
properly. Do some error handling if "pushd" or "popd" fail. Read values
properly into arrays.

However, one shellcheck error is ignored in trap mechanism.  The logic
in trap_add function requires the trap command to be expanded when run.
Just storing the variable into trap doesn't work. Add a shellcheck
disable directive to ignore the error.

An alternative to ignoring could be tricking shellcheck with:

  trap ''"${new_cmd}" "${trap_add_name}"
2019-03-04 23:18:54 +02:00
Jordan Liggitt
f6f1d5abf5 Update generated protobuf files
Change-Id: Ie01ce38d25d05e90d79ddc6e80584a21cf7ff299
2019-03-04 20:14:55 +00:00
Kubernetes Prow Robot
d0c3b70802
Merge pull request #74804 from sttts/sttts-crd-validation-nullable
apiextensions: add nullable support to OpenAPI v3 validations
2019-03-04 10:43:30 -08:00
Hemant Kumar
2567d1b5dd Always make CSI driver attachable when checking for pod info
Fixes https://github.com/kubernetes/kubernetes/issues/74724
2019-03-04 12:35:16 -05:00
Kubernetes Prow Robot
8770e0cd39
Merge pull request #74664 from dims/prepare-publishing-bot-for-1.14-branch
Add 1.14 branches for the publishing-bot
2019-03-04 09:01:21 -08:00
Davanum Srinivas
5616e23b75
Add 1.14 branches for the publishing-bot
Change-Id: Id34d1f12361e587e02f7dba077a9600618737878
2019-03-04 08:43:41 -05:00
Kubernetes Prow Robot
b1d4d40679
Merge pull request #74668 from sttts/sttts-kube-apiserver-endpoints-when-ready
kube-apiserver: don't create endpoints before being ready
2019-03-04 01:57:41 -08:00
Kubernetes Prow Robot
3b4a9e4e71
Merge pull request #74869 from neolit123/fix-reset-fetch
kubeadm-reset: fetch init config only if client is non-nil
2019-03-04 00:25:57 -08:00
Lubomir I. Ivanov
269a07c077 kubeadm-reset: fetch init config only if client is non-nil 2019-03-04 04:14:51 +02:00
Kubernetes Prow Robot
37f0138278
Merge pull request #71874 from neolit123/fix-kubeconfig-path
kubeadm: use DefValue for the --kubeconfig flag
2019-03-03 17:28:44 -08:00
Kubernetes Prow Robot
1f6ea0455b
Merge pull request #74780 from pytimer/kubeadm-reduce
kubeadm: reduce some functions number of parameters
2019-03-03 04:23:24 -08:00
Kubernetes Prow Robot
d62de16fbe
Merge pull request #74857 from andyzhangx/azure-disk-lib
make some functions in azure cloud provider as public
2019-03-03 01:36:18 -08:00
pytimer
f600348006 kubeadm: reduce some functions number of parameters 2019-03-03 15:16:19 +08:00
Kubernetes Prow Robot
c54978a6cf
Merge pull request #74806 from mxinden/increase-bucket-resolution
src/k8s.io/apiserver: Increase cert expiration histogram resolution
2019-03-02 21:13:03 -08:00
Xing Yang
3260d3a7b5 Add generated files 2019-03-02 18:40:23 -08:00
Xing Yang
ba4ccfa8b1 Add review comments in the APIs 2019-03-02 18:40:22 -08:00
Kubernetes Prow Robot
125410aedc
Merge pull request #74834 from fabriziopandini/join-phases-texts
Improve join phases labels and help messages
2019-03-02 18:16:12 -08:00
andyzhangx
38f0908597 make funcs in azure cloud provider as public 2019-03-03 01:58:59 +00:00
Kubernetes Prow Robot
79ce30cc6a
Merge pull request #74851 from dims/apparently-conformance-tests-have-run-run-serially
Apparently conformance tests have to run serially
2019-03-02 12:59:11 -08:00
fabriziopandini
a3ed9f0c2c join-phases-texts 2019-03-02 21:52:04 +01:00