Commit Graph

123523 Commits

Author SHA1 Message Date
Patrick Ohly
ecbafb8de5 DRA: fix scheduler/resource claim controller race
There was a race caused by having to update claim finalizer and status in two
different operations:
- Resource claim controller removes allocation, does not yet
  get to remove the finalizer.
- Scheduler prepares an allocation, without adding the finalizer
  because it's there.
- Controller removes finalizer.
- Scheduler adds allocation.

This is an invalid state. Automatic checking found this during the execution of
the "with translated parameters on single node.*supports sharing a claim
sequentially" E2E test, but only when run stand-alone. When running in
parallel (as in the CI), the bad outcome of the race did not occur.

The fix is to check that the finalizer is still set when adding the
allocation. The apiserver doesn't check that because it doesn't know which
finalizer goes with the allocation result. It could check for "some finalizer",
but that is not guaranteed to be correct (could be some unrelated one).

Checking the finalizer can only be done with a JSON patch. Despite the
complications, having the ability to add multiple pods concurrently to
ReservedFor seems worth it (avoids expensive rescheduling or a local retry
loop).

The resource claim controller doesn't need this, it can do a normal update
which implicitly checks ResourceVersion.
2024-06-27 15:03:06 +02:00
Kubernetes Prow Robot
29defc15aa
Merge pull request #125756 from p0lyn0mial/upstream-improve-run-test-list
apiserver/storage: storagetesting.RunTestList validates RemainingItemCount
2024-06-27 05:25:16 -07:00
Kubernetes Prow Robot
95c7621ed0
Merge pull request #125755 from saschagrunert/named-param-service
Make CRI service interface function arguments consistent
2024-06-27 04:22:05 -07:00
Kubernetes Prow Robot
24478e0c4a
Merge pull request #125729 from p0lyn0mial/upstream-deflake-test-wait-until-fresh
storage/cacher/cacher_whitebox_test.go: deflake TestWaitUntilFreshAndListFromCache
2024-06-27 04:21:58 -07:00
Kubernetes Prow Robot
7210f2aa68
Merge pull request #125752 from SataQiu/fix-cmd-desc-20240627
kubeadm: update the long description about 'kubeadm config' command
2024-06-27 03:20:17 -07:00
Kubernetes Prow Robot
92e0db2bbf
Merge pull request #125640 from googs1025/resourceclaim_controller_log_fix1
added resourceclaim_controller log info
2024-06-27 03:20:10 -07:00
Kubernetes Prow Robot
e31d2cef71
Merge pull request #125736 from aojea/netpol_v0.4.0
update kube-network-policies to v0.4.0
2024-06-27 02:14:51 -07:00
Lukasz Szaszkiewicz
f9b15700fb apiserver/storage: storagetesting.RunTestList validates RemainingItemCount 2024-06-27 11:06:15 +02:00
Sascha Grunert
4411a070fc
Make CRI service interface function arguments consistent
The arguments should contain named parameters, which is now the case.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
2024-06-27 10:30:24 +02:00
SataQiu
6190152abd kubeadm: update the long description about 'kubeadm config' command 2024-06-27 15:54:42 +08:00
Kubernetes Prow Robot
d4c18e5454
Merge pull request #125709 from benluddy/test-fuzz-owners
Add OWNERS to test/fuzz.
2024-06-27 00:50:33 -07:00
Kubernetes Prow Robot
210ab3cbab
Merge pull request #124241 from chengjoey/fix/gce-base64
fix base64 invalid argument when running gce util.sh
2024-06-27 00:50:15 -07:00
Kubernetes Prow Robot
bffc02b955
Merge pull request #125738 from pohly/hack-local-up-cluster-cors-fix
hack/local-up-cluster.sh: adapt to stricter --cors-allowed-origins
2024-06-26 20:40:18 -07:00
Kubernetes Prow Robot
921b69b133
Merge pull request #125582 from chrischdi/pr-kubeadm-kep-4471
kubeadm: implement ControlPlaneKubeletLocalMode
2024-06-26 20:40:12 -07:00
joey
327324a25d
fix base64 invalid argument when running gce util.sh
Signed-off-by: joey <zchengjoey@gmail.com>
2024-06-27 10:39:18 +08:00
Kubernetes Prow Robot
480507464f
Merge pull request #125742 from siyuanfoundation/api-comp-ver1
Add KUBE_EMULATED_VERSION env variable to set the emulated-version of apiserver
2024-06-26 18:59:33 -07:00
Kubernetes Prow Robot
905fdda366
Merge pull request #125739 from seans3/ignore-portforward-leak
Ignore reported goroutine leak during SPDY shutdown
2024-06-26 17:57:14 -07:00
Kubernetes Prow Robot
152a0ca474
Merge pull request #125712 from benluddy/remove-cbor-test-skips
KEP-4222: Remove temporary mechanism for skipping CBOR tests.
2024-06-26 17:57:04 -07:00
Kubernetes Prow Robot
11446a394f
Merge pull request #125745 from BenTheElder/ping-ping
bump  github.com/moby/spdystream to v0.3.0
2024-06-26 15:15:41 -07:00
Kubernetes Prow Robot
9626cd34f4
Merge pull request #125741 from nilekhc/svm-crd-flake
[Storage Version Migrator] fix: increases timeout on CRD update check
2024-06-26 15:15:32 -07:00
Kubernetes Prow Robot
3084c15dd9
Merge pull request #125723 from p0lyn0mial/upstream-refactor-watch-list-kcm-units
kube-controller-manager: refactor watchlist unit tests
2024-06-26 15:15:22 -07:00
Kubernetes Prow Robot
a3a4f9658b
Merge pull request #125492 from Nordix/esotsal/123951
pod-resize-scheduler-tests: fix ci-kubernetes-e2e-ec2
2024-06-26 14:13:48 -07:00
Kubernetes Prow Robot
cd19796316
Merge pull request #125475 from AkihiroSuda/rro
KEP-3857: promote RecursiveReadOnlyMounts feature to beta
2024-06-26 14:13:39 -07:00
Kubernetes Prow Robot
c7e316374c
Merge pull request #125733 from wojtek-t/test_watch_semantics_flake
Fix test flakes for TestWatchSemantics
2024-06-26 13:09:45 -07:00
Quan Tian
59d90eb17e
Make the output of kubectl describe service more informative (#125117)
* kubectl: add internalTrafficPolicy to Service describer

* kubectl: add loadBalancer ipMode to Service describer

* kubectl: fix duplicate IP fields in Service describer

For a LoadBalancer Service, there were two "IP" fields in the output of
`kubectl describe service` if its loadBalancerIP is not empty, which
looks ambiguous.
2024-06-26 13:09:36 -07:00
Benjamin Elder
c5aa8fdc71 bump github.com/moby/spdystream to v0.3.0
picks up fix for data-race in Ping
2024-06-26 12:27:14 -07:00
Kubernetes Prow Robot
1d51766c7a
Merge pull request #125698 from pohly/dra-log-output
DRA: log output
2024-06-26 12:01:03 -07:00
Kubernetes Prow Robot
8637867c9c
Merge pull request #125422 from benluddy/cbor-disable-binarymarshaler
KEP-4222: Disable recognition of Binary(Unm|M)arshaler in CBOR serializer.
2024-06-26 12:00:54 -07:00
Kubernetes Prow Robot
25a43070ee
Merge pull request #123468 from ffromani/fix-mm-metrics-test
node: memory manager: fix the metrics tests
2024-06-26 12:00:45 -07:00
Ben Luddy
2d3e6f8762
Add OWNERS to test/fuzz. 2024-06-26 14:21:16 -04:00
Sotiris Salloumis
7dbc2a9ea8 pod-resize-scheduler-tests: fix ci-kubernetes-e2e-ec2 2024-06-26 20:20:13 +02:00
Siyuan Zhang
126a47d4b5 Add KUBE_EMULATED_VERSION env variable to set the emulated-version of apiserver.
Signed-off-by: Siyuan Zhang <sizhang@google.com>
2024-06-26 11:20:10 -07:00
Kubernetes Prow Robot
a4b8d0faa8
Merge pull request #125731 from dashpole/revert_otel
Revert "Update opentelemetry dependencies to the latest release."
2024-06-26 10:59:18 -07:00
Kubernetes Prow Robot
2b122bc5fa
Merge pull request #125650 from mjudeikis/mjudeikis/generic-controlplane
Generic Control Plane: Add Extra.DisableAvailableConditionController for kube-aggregator
2024-06-26 10:59:10 -07:00
Kubernetes Prow Robot
437f6e92ec
Merge pull request #125641 from nirs/sample-cli-plugin-help
Sample cli plugin help
2024-06-26 10:59:02 -07:00
Kubernetes Prow Robot
b29dce0757
Merge pull request #125627 from yt-huang/clean-up
drop deprecated PollWithContext and adopt PollUntilContextTimeout ins…
2024-06-26 10:58:55 -07:00
Kubernetes Prow Robot
e57f8ad80b
Merge pull request #125439 from Octopusjust/k8s-pr22
pkg/printers: drop deprecated pointer package
2024-06-26 10:58:48 -07:00
Nilekh Chaudhari
027630a0dc fix: increases timeout on CRD update check
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
2024-06-26 10:49:16 -07:00
Sean Sullivan
5ba8773126 Ignore reported goroutine leak during SPDY shutdown 2024-06-26 10:22:14 -07:00
Patrick Ohly
8cb4a19450 hack/local-up-cluster.sh: adapt to stricter --cors-allowed-origins
https://github.com/kubernetes/kubernetes/pull/112809 tightened what regular
expressions are allowed and now requires that they start matching with a double
dash.
2024-06-26 18:52:03 +02:00
Antonio Ojea
4bc461872f update kube-network-policies to v0.4.0 2024-06-26 16:27:12 +00:00
Wojciech Tyczyński
5081ba45f9 Fix test flakes for TestWatchSemantics 2024-06-26 17:49:54 +02:00
Kubernetes Prow Robot
44c1a0eec2
Merge pull request #124667 from linxiulei/trim
controlplane/apiserver: Trim managedFields off self-requested informers
2024-06-26 08:10:20 -07:00
David Ashpole
e89a2bf6ac
./hack/update-vendor.sh 2024-06-26 14:16:58 +00:00
David Ashpole
7bcb2a96f2
Revert "fix tracing integration test"
This reverts commit a3b7cb9374.
2024-06-26 14:14:26 +00:00
David Ashpole
8a62765d84
Revert "update go workspace"
This reverts commit 045554491a.
2024-06-26 14:14:18 +00:00
David Ashpole
56fdcf0837
Revert "update unwanted dependencies"
This reverts commit d65029f9bb.
2024-06-26 14:14:06 +00:00
David Ashpole
e94047c900
Revert "update OpenTelemetry dependencies"
This reverts commit 82e9ce79c7.
2024-06-26 14:13:33 +00:00
Kubernetes Prow Robot
66126bbdc6
Merge pull request #125721 from p0lyn0mial/upstream-cacher-tests-decrease-time
apiserver/storage: decrease running time of RunWatchSemantics
2024-06-26 06:28:28 -07:00
Kubernetes Prow Robot
7996836cce
Merge pull request #125717 from cpanato/update-rules
update publishing rules to use go1.22.4 for all branches
2024-06-26 06:28:21 -07:00