Commit Graph

105681 Commits

Author SHA1 Message Date
Lubomir I. Ivanov
f3f1332223 kubeadm: update the CRI socket detection logic
- Throw an error if there is more than one known socket on the host.
- Remove the special handling for docker+containerd.
- Remove the local instances of constants for endpoints for
Windows / Unix and use the defaultKnownCRISockets variable
which is populated from OS specific constants.
- Update error message in detectCRISocketImpl to have more
details.
- Make detectCRISocketImpl accept a list of "known" sockets
- Update unit tests for detectCRISocketImpl and make them
use generic paths such as "unix:///foo/bar.sock".
2022-01-12 17:15:45 +02:00
Lubomir I. Ivanov
ea2c948799 kubeadm: change the default CRI socket to containerd
Change the default container runtime CRI socket endpoint to the
one of containerd. Previously it was the one for Docker

- Rename constants.DefaultDockerCRISocket to DefaultCRISocket
- Make the constants files include the endpoints for all supported
container runtimes for Unix/Windows.
- Update unit tests related to docker runtime testing.
- In kubelet/flags.go hardcode the legacy docker socket as a check
to allow kubeadm 1.24 to run against kubelet 1.23 if the user
explicitly sets the criSocket field to "npipe:////./pipe/dockershim"
on Windows or "unix:///var/run/dockershim.sock" on Linux.
2022-01-12 17:15:45 +02:00
Lubomir I. Ivanov
936e12c930 kubeadm: do not special case Docker as a container runtime
crictl already works with the current state of dockershim.
Using the docker CLI is not required and the DockerRuntime
can be removed from kubeadm. This means that crictl
can connect at the dockershim (or cri-dockerd) socket and
be used to list containers, pull images, remove containers, and
all actions that the kubelet can otherwise perform with the socket.

Ensure that crictl is now required for all supported container runtimes
in checks.go. In the help text in waitcontrolplane.go show only
the crictl example.

Remove the check for the docker service from checks.go.
Remove the DockerValidor check from checks.go.
These two checks were special casing Docker as CR and compensating
for the lack of the same checks in dockershim. With the
extraction of dockershim to cri-dockerd, ideally cri-dockerd
should perform the required checks whether it can support
a given Docker config / version running on a host.
2022-01-05 21:27:24 +02:00
Kubernetes Prow Robot
e9fc23e31e Merge pull request #107221 from rikatz/kubectl/issue1159
Fix a panic when using invalid output format in kubectl create secret command
2022-01-05 10:34:08 -08:00
Kubernetes Prow Robot
a0d638bd79 Merge pull request #104819 from justinsb/less_cmp
Use utils string-slice comparison
2022-01-05 10:34:00 -08:00
Kubernetes Prow Robot
1943ca7cda Merge pull request #103311 from oz123/document-output-loctaion-of-build-artifacts
Build: improve documentation of build artifacts
2022-01-05 10:33:48 -08:00
Kubernetes Prow Robot
23ee308ed7 Merge pull request #107326 from MikeSpreitzer/apf-concurrentize-config-producer
Concurrentize pkg/registry/flowcontrol/ensurer/strategy.go
2022-01-05 09:23:34 -08:00
Kubernetes Prow Robot
940c096bac Merge pull request #107309 from yanghesong/remove_rundockershim
remove runDockershim #97252
2022-01-05 09:23:26 -08:00
Kubernetes Prow Robot
4f35d80f4e Merge pull request #107302 from pacoxu/fix/empty-dir-quota-monitoring
assignQuota checks if the underlying medium supports quotas and if so setting it
2022-01-05 09:23:18 -08:00
Kubernetes Prow Robot
adfc35d249 Merge pull request #107200 from pacoxu/test/cronjob-conflict-flake
flake: remove the error handler for cronjob integration test
2022-01-05 09:23:09 -08:00
Kubernetes Prow Robot
4bd7243c74 Merge pull request #106688 from kidlj/fix_obsolete_runtime_schema_comments
fix obsolete comments in runtime/schema struct
2022-01-05 09:23:00 -08:00
Kubernetes Prow Robot
e720bae30e Merge pull request #106215 from shawnhanx/apiserverinternal_validation
fix "k8s.io/apimachinery/pkg/util/validation" is imported more than once
2022-01-05 09:22:51 -08:00
Kubernetes Prow Robot
24a43bc6a6 Merge pull request #105598 from gy95/match
break the pointless loop when group matched
2022-01-05 09:22:38 -08:00
Kubernetes Prow Robot
25450b9521 Merge pull request #105389 from taku333/patch-1
Update sleep .5 ⇨ sleep 0.5
2022-01-05 09:22:26 -08:00
Kubernetes Prow Robot
afd254a18f Merge pull request #106756 from victory460/feature_helpers
code cleanup for container/helpers.go
2022-01-05 08:20:42 -08:00
Kubernetes Prow Robot
f2576efecd Merge pull request #106085 from wojtek-t/watch_support_9
P&F: enable mutating work estimator
2022-01-05 06:58:47 -08:00
Kubernetes Prow Robot
04f2beea8a Merge pull request #93709 from ash2k/ash2k/interruptible-sleep
Make RetryWatcher sleep interruptible
2022-01-05 06:58:34 -08:00
Kubernetes Prow Robot
454d56cfc8 Merge pull request #107328 from pacoxu/patch-7
Delete .staticcheck_failures
2022-01-05 05:44:33 -08:00
Kubernetes Prow Robot
b960f7a0e0 Merge pull request #106203 from 2014BDuck/test-priority-queue-activate
add test cases for scheduler/PriorityQueue.Activate
2022-01-05 02:22:32 -08:00
Kubernetes Prow Robot
c6f2102218 Merge pull request #105765 from mysunshine92/changelog-1.22
changelog-1.22:Fix notes of PR 101151
2022-01-05 01:18:33 -08:00
Kubernetes Prow Robot
5588d5c578 Merge pull request #107159 from mengjiao-liu/improve-unit-test-coverage-pv
Improve test coverage: pkg/api/persistentvolume
2022-01-05 00:16:32 -08:00
Paco Xu
22705c2420 Delete .staticcheck_failures 2022-01-05 15:45:56 +08:00
Kubernetes Prow Robot
885961cda8 Merge pull request #107314 from neolit123/1.24-fix-panic-in-runkubeletconfig
kubeadm: fix panic in runKubeletConfigPhase
2022-01-04 23:03:35 -08:00
Kubernetes Prow Robot
abfe397ceb Merge pull request #107166 from jsafrane/fix-pv-controller-tests
Fix PV controller unit test 5-7
2022-01-04 23:03:27 -08:00
Kubernetes Prow Robot
4eae933dc7 Merge pull request #106667 from SergeyKanzhelev/updateDeprecationMessages
updated deprecation messages from 1.23 to 1.24
2022-01-04 23:03:20 -08:00
Kubernetes Prow Robot
6d6ebfbe24 Merge pull request #106547 from astraw99/fix-log-typo
Fix log blank typo to avoid en/decode issues
2022-01-04 23:03:13 -08:00
Kubernetes Prow Robot
0f5e3d14bd Merge pull request #106421 from houjun41544/20211115-volume
Fix the wrong log
2022-01-04 23:03:05 -08:00
Kubernetes Prow Robot
a7905d76c7 Merge pull request #106397 from shawnhanx/core_validation
fix S1017 and S1002 in pkg/apis/core/validation/validation.go
2022-01-04 23:02:58 -08:00
Kubernetes Prow Robot
0e5cfcda02 Merge pull request #106375 from sayaoailun/master
fix commont of controller manager leadermigration filter
2022-01-04 23:02:51 -08:00
Kubernetes Prow Robot
d2969bd260 Merge pull request #106294 from gy95/continue
fix duplicate webhook insert operation
2022-01-04 23:02:43 -08:00
Kubernetes Prow Robot
19591a1324 Merge pull request #105829 from yuanchen8911/master
Fix and improve comments on kubelet metrics
2022-01-04 23:02:32 -08:00
Kubernetes Prow Robot
38f4968046 Merge pull request #103136 from takotakot/fix_changelog
Fix display of CHANGELOG-1.19.md by inserting newline
2022-01-04 21:42:32 -08:00
Kubernetes Prow Robot
a90961aac0 Merge pull request #97966 from saschagrunert/apparmor-init-unconfined
Remove AppArmor loaded profile validation
2022-01-04 20:24:32 -08:00
Mike Spreitzer
72403c8814 Concurrentize pkg/registry/flowcontrol/ensurer/strategy.go
Stop logging error messages when surprised by concurrent activity.
Concurrent activity is not an error, it is normal.
2022-01-04 22:55:21 -05:00
Kubernetes Prow Robot
1945829906 Merge pull request #104846 from andrewsykim/fix-internal-traffic-policy-validation
Stop defaulting Service internalTrafficPolicy when type is ExternalName
2022-01-04 17:40:32 -08:00
Paco Xu
3946e6c8c2 assignQuota checks if the underlying medium supports quotas and if so, sets 2022-01-05 09:33:07 +08:00
guoyao
d9f99489ee fix duplicate webhook insert operation
Signed-off-by: guoyao <1015105054@qq.com>
2022-01-05 08:59:13 +08:00
Kubernetes Prow Robot
84f1d6834f Merge pull request #106619 from chendave/ga
Graduate `PreferNominatedNode` to GA
2022-01-04 15:21:19 -08:00
Kubernetes Prow Robot
9e209efd65 Merge pull request #107104 from tkashem/apf-use-v1beta2
apf: use v1beta2 in registry package
2022-01-04 13:06:42 -08:00
Kubernetes Prow Robot
4d4d57fcf0 Merge pull request #106340 from SergeyKanzhelev/removeCriCtlTar
remove crictl tar
2022-01-04 13:06:34 -08:00
Kubernetes Prow Robot
710cc5c2a1 Merge pull request #106283 from SergeyKanzhelev/noMoreScalabilityTests
There are no more Feature:Performance tests any longer, removing the …
2022-01-04 13:06:26 -08:00
Kubernetes Prow Robot
833813c6c6 Merge pull request #105449 from kinvolk/invidian/fix-docs-for-apiserver
k8s.io/apiserver/pkg/server: fix name in APIServerHandler description
2022-01-04 13:06:19 -08:00
Kubernetes Prow Robot
661d75fbef Merge pull request #98771 from eltociear/patch-2
Fix typo in gci/README.md
2022-01-04 13:06:08 -08:00
Andrew Sy Kim
f68f478e66 core/v1: update unit tests to not expect internalTrafficPolicy when Service Type=ExternalName
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2022-01-04 14:48:04 -05:00
Andrew Sy Kim
438b90fbc4 core/v1: drop Service spec.internalTrafficPolicy on read when type is ExternalName
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2022-01-04 14:36:19 -05:00
Andrew Sy Kim
5d2702b0fd core/v1: add comments about why Service internalTrafficPolicy is not forbidden when type is ExternalName
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2022-01-04 14:36:19 -05:00
Andrew Sy Kim
99cb5d2f21 core/v1: add unit tests that allow internalTrafficPolicy field when type is ExternalName
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2022-01-04 14:36:19 -05:00
Andrew Sy Kim
60b38ee180 core/v1: add validation and defaulting unit tests for when internalTrafficPolicy is nil and Service type is ExternalName
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2022-01-04 14:36:19 -05:00
Andrew Sy Kim
3a927cc6b3 core/v1: stop defaulting Service internalTrafficPolicy when Type=ExternalName
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2022-01-04 14:36:19 -05:00
Lubomir I. Ivanov
076b19f0eb kubeadm: fix panic in runKubeletConfigPhase
The "nro" struct must be initialized before passing it to
GetNodeRegistration().
2022-01-04 21:28:13 +02:00