Refactor Healthz with Metrics Address for internal configuration of
kube-proxy adhering to the v1alpha2 version specifications as detailed
in https://kep.k8s.io/784.
Signed-off-by: Daman Arora <aroradaman@gmail.com>
Comment fix and removal of `skippedUnknownDevice`. That field was originally
meant to somehow influence how a failure to allocate gets reported, but in the
end that distinction was not implemented.
The internal "stop allocation" error was sometimes erroneously (pun intended)
returned as result of the allocation and then shown to users. No error and no
results should have been returned instead, which then is shown as "allocation
not possible".
Aborting allocation early is only correct if the device which cannot be
allocated is one of the "all" devices which were requested.
The code which pre-determined the set of "all" devices when using
"allocationMode: all" accidentally ignored the selector of the device class.
As a result, allocation worked correctly only when a node had only devices
matching the intended device class. When there were additional devices, things
went wrong:
- Unrelated devices allocated for a request.
- Claim allocation failed completely.
The util for checking on daemonstatus was checking once if the Status of
the daemonset was reporting that all the desired Pods are scheduled and
ready.
However, the pattern used in the e2e test for this function was not
taking into consideration that the controller needs to propagate the Pod
status to the DeamonSet status, and was asserting on the condition only
once after waiting for all the Pods to be ready.
In order to avoid more churn code, change the CheckDaemonStatus
signature to the wait.Condition type and use it in a async poll loop on
the tests.
The RPC call usually does not take much time for containerd or CRI-O. We
now assume the default timeout is fine and therefore resolve the `TODO`.
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
In Go unit tests, the entire test output becomes the failure message because
`go test` doesn't track why a test fails. This can make the failure message
pretty large, in particular in integration tests.
We cannot identify the real failure either because Kubernetes has no convention
for how to format test failures. What we can do is recognize log output added
by klog.
prune-junit-xml now moves the full text to to the test output and only keep
those lines in the failure which are not from klog.
The klog output parsing might eventually get moved to
k8s.io/logtools/logparse. For now it is developed as a sub-package of
prune-junit-xml.
The logic has been updated to ensure that a controller started for
non-node-local resources filters out all resourceslices created for
node-local resources. Without this change, a single driver with both
node-local and non-node-local resources would end up in a constant
battle of creating and deleting node-local resource slices in the
controller it setup for its non-node-local resources. This change fixes
that.
Signed-off-by: Kevin Klues <kklues@nvidia.com>
