Commit Graph

95055 Commits

Author SHA1 Message Date
W. Trevor King
f95ec84322 Event: Document TTL and best-effort-ness
Generally try to waive away folks who see a particular event stream
and feel tempted to extrapolate and build tooling that expects the
same underlying resource transition chain to continue to produce a
similar event stream as the underlying components evolve and are
updated.  New controllers should not be constrained to be
backwards-compatible with previous versions with regard to Event
emission.  This is distinct from the Event type itself, which has the
usual Kubernetes-API compatibility commitments for versioned types.

The EventTTL default has been 1h since 7e258b85bd (Reduce TTL for
events in etcd from 48hrs to 1hr, 2015-03-11, #5315), and remains so
today:

  $ git --no-pager log -1 --format='%h %s' origin/master
  8e5c02255c Merge pull request #90942 from ii/ii-create-pod%2Bpodstatus-resource-lifecycle-test
  $ git --no-pager grep EventTTL: 8e5c02255c cmd/kube-apiserver/app/options/options.go
  8e5c02255cc:cmd/kube-apiserver/app/options/options.go:		EventTTL:               1 * time.Hour,

In this space [1,2]:

  To avoid filling up master's disk, a retention policy is enforced:
  events are removed one hour after the last occurrence.  To provide
  longer history and aggregation capabilities, a third party solution
  should be installed to capture events.
  ...
  Note: It is not guaranteed that all events happening in a cluster
  will be exported to Stackdriver.  One possible scenario when events
  will not be exported is when event exporter is not running
  (e.g. during restart or upgrade).  In most cases it's fine to use
  events for purposes like setting up metrics and alerts, but you
  should be aware of the potential inaccuracy.
  ...
  To prevent disturbing your workloads, event exporter does not have
  resources set and is in the best effort QOS class, which means that
  it will be the first to be killed in the case of resource
  starvation.

Although that's talking more about export from etcd -> external
storage, and not about cluster components submitting events to etcd.

[1]: https://kubernetes.io/docs/tasks/debug-application-cluster/events-stackdriver/
[2]: https://github.com/kubernetes/website/pull/4155/files#diff-d8eb69c5436aa38b396d4f3ed75e4792R10
2020-10-27 15:36:37 -04:00
Kubernetes Prow Robot
56069e4f9d
Merge pull request #95874 from tkashem/webhook-handle-error
Webhook: handle error when calling wait.ExponentialBackoff
2020-10-27 11:41:34 -07:00
Kubernetes Prow Robot
93fcb22e64
Merge pull request #95687 from tangwz/make_profile_an_interface
scheduler: make Profile an interface.
2020-10-27 11:41:26 -07:00
Kubernetes Prow Robot
3523555aab
Merge pull request #95771 from vinayakankugoyal/fluentbit
Grant group KUBE_POD_LOG_READERS_GROUP access to read pod logs on gke…
2020-10-27 10:36:48 -07:00
Kubernetes Prow Robot
94cedd9f14
Merge pull request #95720 from draveness/feature/topology-manager-format
style: update comments in topology manager
2020-10-27 10:36:38 -07:00
Kubernetes Prow Robot
1cb1005437
Merge pull request #95662 from SergeyKanzhelev/nilInterfaceInShouldRecordEvent
The function shouldRecordEvent will panic when the value of input obj…
2020-10-27 10:36:28 -07:00
Kubernetes Prow Robot
554319cce8
Merge pull request #95410 from benhxy/staticcheck
Fix static check for pkg/controller/podautoscaler
2020-10-27 10:36:14 -07:00
Kubernetes Prow Robot
82b38ce9db
Merge pull request #94953 from mattjmcnaughton/mattjmcnaughton/remove-mattjmcnaughton-as-sig-node-reviewer
Remove mattjmcnaughton as a sig-node reviewer
2020-10-27 10:36:01 -07:00
Abu Kashem
f8e35de156
Webhook: handle error when calling wait.ExponentialBackoff
- Inside WithExponentialBackoff function, handle error returned
by wait.ExponentialBackoff.
- Ensure that the wait time is bound to the given context.
2020-10-27 12:04:28 -04:00
Kubernetes Prow Robot
6352f01e66
Merge pull request #95918 from wojtek-t/fix_cacher_test_again
Fix cacher test after bumping fakeBudget timeout to 2 seconds
2020-10-27 08:17:59 -07:00
wojtekt
f62e61c28f Fix cacher test after bumping fakeBudget timeout to 2 seconds 2020-10-27 15:25:31 +01:00
Kubernetes Prow Robot
b4258ec138
Merge pull request #95869 from wojtek-t/debug_watchcache_test
Fix cacher test flakiness
2020-10-27 04:33:59 -07:00
Kubernetes Prow Robot
4df8d97af0
Merge pull request #95725 from p0lyn0mial/delegated-authz-sar-timeout
sets explicit timeout for SubjectAccessReview client
2020-10-27 03:37:59 -07:00
Kubernetes Prow Robot
1f0371bb3f
Merge pull request #95864 from nilo19/cleanup/fix-typos
Fix a lot of typos in Azure codes
2020-10-27 02:13:59 -07:00
Kubernetes Prow Robot
47943d5f9c
Merge pull request #94109 from derekwaynecarr/cleanup-kubelet-todos
Cleanup kubelet TODOs that are no longer pertinent.
2020-10-26 23:49:59 -07:00
Kubernetes Prow Robot
68f6b09e80
Merge pull request #80954 from zachomedia/fix-lock-release
Fix leader election lock release when using LeaseLocks
2020-10-26 20:57:58 -07:00
tangwz
5f3efa671d scheduler: make Profile an interface. 2020-10-27 09:13:04 +08:00
Kubernetes Prow Robot
87cc9bca0f
Merge pull request #95867 from jsafrane/e2e-podexec-stderr
Log PodExec stdout + stderr
2020-10-26 17:55:59 -07:00
Kubernetes Prow Robot
227aa51b94
Merge pull request #95868 from xing-yang/update_test_owners
Update test/e2e/storage owners file
2020-10-26 16:24:12 -07:00
Kubernetes Prow Robot
6c5cda5a40
Merge pull request #95473 from troy0820/fix/validate-verb
Validate verb in auth can-i command
2020-10-26 16:23:59 -07:00
Kubernetes Prow Robot
3d6026499b
Merge pull request #95235 from andrewsykim/controlplane-egress-selector
apiserver: support 'controlplane' as an egress selector type
2020-10-26 14:45:59 -07:00
Khaled Henidak (Kal)
6675eba3ef
dual stack services (#91824)
* api: structure change

* api: defaulting, conversion, and validation

* [FIX] validation: auto remove second ip/family when service changes to SingleStack

* [FIX] api: defaulting, conversion, and validation

* api-server: clusterIPs alloc, printers, storage and strategy

* [FIX] clusterIPs default on read

* alloc: auto remove second ip/family when service changes to SingleStack

* api-server: repair loop handling for clusterIPs

* api-server: force kubernetes default service into single stack

* api-server: tie dualstack feature flag with endpoint feature flag

* controller-manager: feature flag, endpoint, and endpointSlice controllers handling multi family service

* [FIX] controller-manager: feature flag, endpoint, and endpointSlicecontrollers handling multi family service

* kube-proxy: feature-flag, utils, proxier, and meta proxier

* [FIX] kubeproxy: call both proxier at the same time

* kubenet: remove forced pod IP sorting

* kubectl: modify describe to include ClusterIPs, IPFamilies, and IPFamilyPolicy

* e2e: fix tests that depends on IPFamily field AND add dual stack tests

* e2e: fix expected error message for ClusterIP immutability

* add integration tests for dualstack

the third phase of dual stack is a very complex change in the API,
basically it introduces Dual Stack services. Main changes are:

- It pluralizes the Service IPFamily field to IPFamilies,
and removes the singular field.
- It introduces a new field IPFamilyPolicyType that can take
3 values to express the "dual-stack(mad)ness" of the cluster:
SingleStack, PreferDualStack and RequireDualStack
- It pluralizes ClusterIP to ClusterIPs.

The goal is to add coverage to the services API operations,
taking into account the 6 different modes a cluster can have:

- single stack: IP4 or IPv6 (as of today)
- dual stack: IPv4 only, IPv6 only, IPv4 - IPv6, IPv6 - IPv4

* [FIX] add integration tests for dualstack

* generated data

* generated files

Co-authored-by: Antonio Ojea <aojea@redhat.com>
2020-10-26 13:15:59 -07:00
wojtekt
6eb71c4089 Fix cacher test flakiness 2020-10-26 20:09:13 +01:00
Kubernetes Prow Robot
d0e06cf3e0
Merge pull request #95843 from varunmar/update-ip-masq-agent
Bump ip-masq-agent version to pick up CVE fixes
2020-10-26 11:23:16 -07:00
Kubernetes Prow Robot
5ed903dbfd
Merge pull request #95809 from alculquicondor/rebench-spread
Optimize NormalizeScore for PodTopologySpread
2020-10-26 11:23:02 -07:00
Kubernetes Prow Robot
c34a2c44a8
Merge pull request #95866 from JornShen/add_metrics_report_time_permit_change
Report a metric for time taken to perform recursive permission change
2020-10-26 10:25:37 -07:00
Kubernetes Prow Robot
2e1d903b13
Merge pull request #95836 from nodo/yaml-unmarshal-number
Add yaml util to unmarshal numbers into int/float
2020-10-26 10:25:27 -07:00
Kubernetes Prow Robot
bdde4fb8f5
Merge pull request #93040 from cmluciano/cml/ipvsschedmodules
ipvs: ensure selected scheduler kernel modules are loaded
2020-10-26 10:25:17 -07:00
Kubernetes Prow Robot
557885d5d7
Merge pull request #91788 from rahulkjoshi/detect-local-mode
Add option to specify detect-local-mode during cluster configuration
2020-10-26 10:25:02 -07:00
Kubernetes Prow Robot
c492e5bfb7
Merge pull request #95858 from monotek/fluent-es-xpack
added xpack gem to enable ilm support in fluentd-es-image
2020-10-26 09:29:15 -07:00
Kubernetes Prow Robot
9cc882de87
Merge pull request #95592 from fromanirh/tm-e2e-avoid-sriovdp-leak
e2e: topology manager: avoid sriov device plugin pod leak on test failures
2020-10-26 09:29:02 -07:00
Lukasz Szaszkiewicz
2160cbc53f DelegatingAuthorizationOptions: exposes and sets a default timeout for SubjectAccessReview client
previously no timeout was set. Requests without explicit timeout might potentially hang forever and lead to starvation of the application.
2020-10-26 17:11:59 +01:00
Qi Ni
ecdc1ba57c Fix a lot of typos in Azure codes 2020-10-26 22:47:38 +08:00
Kubernetes Prow Robot
e79a873b4c
Merge pull request #95821 from markusthoemmes/optimize-nn-string
Optimize string building for NamespacedName
2020-10-26 07:45:01 -07:00
Andrew Sy Kim
e4b45d944d apiserver: use canonical egress selection names in EgressSelectorConfiguration API docs
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-10-26 10:24:16 -04:00
Andrew Sy Kim
5a09325864 apiserver: update TestReadEgressSelectorConfiguration to use 'controlplane' egress selector name
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-10-26 10:24:16 -04:00
Andrew Sy Kim
30d43806c3 apiserver: add validation for EgressSelection names in EgressSelectorConfiguration API
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-10-26 10:24:16 -04:00
Andrew Sy Kim
a0aebf96ec apiserver: support egress selection name 'controlplane' and deprecate 'master'
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-10-26 10:24:16 -04:00
xing-yang
1d22030894 Update test/e2e/storage owners file 2020-10-26 13:36:59 +00:00
Kubernetes Prow Robot
0ec6602679
Merge pull request #77398 from claudiubelu/test-images/windows-support-part-2
test images: Adds Windows Container images support (part 2)
2020-10-26 06:19:02 -07:00
jornshen
4ed7709774 Report a metric for time taken to perform recursive permission change 2020-10-26 21:04:30 +08:00
Jan Safranek
96e3bc1bfa Log PodExec stdout + stderr
e2e tests should log stdout / stderr of failed commands executed via
PodExec. "command terminated with exit code 1" is not really useful.
2020-10-26 13:22:18 +01:00
Kubernetes Prow Robot
53b2973440
Merge pull request #95844 from MrHohn/ip-masq-owner
Add MrHohn as an owner of the ip-masq-agent addon
2020-10-26 00:45:02 -07:00
Kubernetes Prow Robot
16e18a590f
Merge pull request #95813 from nilo19/bug/fix-pip-name
Azure: Update the frontend IP config when the service's `pipName` annotation is changed
2020-10-25 17:31:01 -07:00
André Bauer
f6475ca56c removed whitspace
Signed-off-by: André Bauer <monotek23@gmail.com>
2020-10-25 19:27:43 +01:00
André Bauer
72e9737255 added xpack gem to enable ilm support in fluentd-es-image
Signed-off-by: André Bauer <monotek23@gmail.com>
2020-10-25 19:19:08 +01:00
Andrea Nodari
04d972cb4b Add yaml util to unmarshal numbers into int/float 2020-10-24 11:36:22 +02:00
Qi Ni
87a4805ba4 Update the frontend IP config when the service's pipName annotation is changed 2020-10-24 17:35:23 +08:00
Kubernetes Prow Robot
5935fcd704
Merge pull request #95766 from towca/jtuznik/ca-params-fix
Properly quote flags passed to Cluster Autoscaler
2020-10-23 20:47:00 -07:00
Kubernetes Prow Robot
1f756e4a37
Merge pull request #92669 from Jefftree/netproxy-configure-helper
Separate network proxy flag for apiserver egress and starting pods
2020-10-23 16:47:00 -07:00