mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-24 20:24:09 +00:00
cb6a653777
This replaces the experimental logr v0.4 with the stable v1.1.0
release. This is a breaking API change for some users because:
- Comparing logr.Logger against nil is not possible anymore:
it's now a struct instead of an interface. Code which
allows a nil logger should switch to *logr.Logger as type.
- Logger implementations must be updated in lockstep.
Instead of updating the forked zapr code in json.go, directly using
the original go-logr/zapr is simpler and avoids duplication of effort.
The updated zapr supports logging of numeric verbosity. Error messages
don't have a verbosity (= always get logged), so "v" is not getting
added to them anymore.
Source code logging for panic messages got fixed so that it references
the code with the invalid log call, not the json.go implementation.
Finally, zapr includes additional information in its panic
messages ("zap field", "ignored key", "invalid key").
18 lines
579 B
Markdown
18 lines
579 B
Markdown
# Contributing
|
|
|
|
Logr is open to pull-requests, provided they fit within the intended scope of
|
|
the project. Specifically, this library aims to be VERY small and minimalist,
|
|
with no external dependencies.
|
|
|
|
## Compatibility
|
|
|
|
This project intends to follow [semantic versioning](http://semver.org) and
|
|
is very strict about compatibility. Any proposed changes MUST follow those
|
|
rules.
|
|
|
|
## Performance
|
|
|
|
As a logging library, logr must be as light-weight as possible. Any proposed
|
|
code change must include results of running the [benchmark](./benchmark)
|
|
before and after the change.
|