Production-Grade Container Scheduling and Management
Go to file
Kubernetes Submit Queue 0b1d023aa7
Merge pull request #55884 from mpolednik/dpi-race-fix
Automatic merge from submit-queue (batch tested with PRs 55839, 54495, 55884, 55983, 56069). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

deviceplugin: fix race when multiple plugins are registered

**What this PR does / why we need it**:
When registering multiple device plugins to Kubelet concurrently, there exists a race that crashes the Kubelet.

Consider two plugins: D1 and D2. The call order method is roughly

D1 -> manager.go:register -> endpoint.go:listAndWatch -> device_plugin_handler.go:(*D1).callback
D2 -> manager.go:register -> endpoint.go:listAndWatch -> device_plugin_handler.go:(*D2).callback

The callback function accesses HandlerImpl's allDevices map that maps (resourceName -> DeviceID). If both plugins reach these accesses at the same time, Kubelet crashes with "fatal error: concurrent map read and map write".

This can be solved by making sure handler is locked when allDevices are being updated. The functionality is needed to avoid Kubelet crashes when multiple device plugins are trying to register with Kubelet at the same moment. Occurs frequently when single binary tries to register itself as multiple plugins.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:

**Special notes for your reviewer**:

**Release note**:
```release-note
NONE
```
2017-11-20 13:08:09 -08:00
.github Merge pull request #54114 from xiangpengzhao/fix-pr-template 2017-10-30 18:37:06 -07:00
api Merge pull request #51530 from rootfs/iscsi-pv-ns 2017-11-18 16:38:36 -08:00
build Merge pull request #54938 from nikhita/kubectl-explain-trailing-period 2017-11-18 04:02:57 -08:00
cluster Merge pull request #55990 from hyperbolic2346/rollup 2017-11-20 04:50:03 -08:00
cmd Merge pull request #54495 from mikedanese/csr2 2017-11-20 13:08:05 -08:00
docs Merge pull request #51530 from rootfs/iscsi-pv-ns 2017-11-18 16:38:36 -08:00
examples Update generated files 2017-11-09 12:14:08 +01:00
Godeps Merge pull request #55496 from JiangtianLi/jiangtli-fixservercore 2017-11-18 10:46:38 -08:00
hack Merge pull request #54007 from vishh/hack-owners 2017-11-18 23:08:05 -08:00
logo
pkg Merge pull request #55884 from mpolednik/dpi-race-fix 2017-11-20 13:08:09 -08:00
plugin Merge pull request #55839 from mindprince/extended-resource-toleration 2017-11-20 12:28:36 -08:00
staging Merge pull request #55660 from smarterclayton/get_clean 2017-11-20 11:36:34 -08:00
test Merge pull request #55871 from atlassian/unstructured-converter-no-mutation 2017-11-20 08:58:37 -08:00
third_party Update generated files 2017-11-09 12:14:08 +01:00
translations Merge pull request #47584 from zjj2wry/translate 2017-11-15 23:57:28 -08:00
vendor Merge pull request #55496 from JiangtianLi/jiangtli-fixservercore 2017-11-18 10:46:38 -08:00
.bazelrc
.generated_files
.gitattributes Hide openapi-spec in diffs 2017-11-04 23:16:04 -07:00
.gitignore
.kazelcfg.json
BUILD.bazel
CHANGELOG-1.2.md
CHANGELOG-1.3.md
CHANGELOG-1.4.md
CHANGELOG-1.5.md
CHANGELOG-1.6.md
CHANGELOG-1.7.md Update CHANGELOG-1.7.md for v1.7.10. 2017-11-03 16:39:03 -04:00
CHANGELOG-1.8.md Update CHANGELOG-1.8.md for v1.8.4. 2017-11-20 10:08:31 -08:00
CHANGELOG-1.9.md Update CHANGELOG-1.9.md for v1.9.0-alpha.3. 2017-11-15 16:08:16 -08:00
CHANGELOG.md
code-of-conduct.md
CONTRIBUTING.md
labels.yaml
LICENSE
Makefile
Makefile.generated_files
OWNERS
OWNERS_ALIASES
README.md
SUPPORT.md
Vagrantfile
WORKSPACE

Kubernetes

Submit Queue Widget GoDoc Widget CII Best Practices


Kubernetes is an open source system for managing containerized applications across multiple hosts, providing basic mechanisms for deployment, maintenance, and scaling of applications.

Kubernetes builds upon a decade and a half of experience at Google running production workloads at scale using a system called Borg, combined with best-of-breed ideas and practices from the community.

Kubernetes is hosted by the Cloud Native Computing Foundation (CNCF). If you are a company that wants to help shape the evolution of technologies that are container-packaged, dynamically-scheduled and microservices-oriented, consider joining the CNCF. For details about who's involved and how Kubernetes plays a role, read the CNCF announcement.


To start using Kubernetes

See our documentation on kubernetes.io.

Try our interactive tutorial.

Take a free course on Scalable Microservices with Kubernetes.

To start developing Kubernetes

The community repository hosts all information about building Kubernetes from source, how to contribute code and documentation, who to contact about what, etc.

If you want to build Kubernetes right away there are two options:

You have a working Go environment.
$ go get -d k8s.io/kubernetes
$ cd $GOPATH/src/k8s.io/kubernetes
$ make
You have a working Docker environment.
$ git clone https://github.com/kubernetes/kubernetes
$ cd kubernetes
$ make quick-release

If you are less impatient, head over to the developer's documentation.

Support

If you need support, start with the troubleshooting guide and work your way through the process that we've outlined.

That said, if you have questions, reach out to us one way or another.

Analytics