Production-Grade Container Scheduling and Management
Go to file
Kubernetes Submit Queue 82f24cee5e Merge pull request #46390 from enj/enj/i/require_delete_strategy
Automatic merge from submit-queue (batch tested with PRs 46552, 46608, 46390, 46605, 46459)

Require DeleteStrategy for all registry.Store

**What this PR does / why we need it**:

All `registry.Store` objects already set a non-nil `DeleteStrategy`.  This change ensures that all future objects do so as well.

Signed-off-by: Monis Khan <mkhan@redhat.com>

xref: #24153 openshift/origin/issues/14198

cc @deads2k @liggitt @caesarxuchao @lavalamp @smarterclayton @derekmahar 

In regards to this, why is the `RESTDeleteStrategy` a useless interface (as far as deletion goes)?  We cast it to `GarbageCollectionDeleteStrategy` or `RESTGracefulDeleteStrategy` in an attempt to do operations related to deletion, but we have "default" behavior for both of those cases.  It should be possible to make `DeleteStrategy` optional by using the other strategies as the `runtime.ObjectTyper` and then defaulting a `nil` `DeleteStrategy` with the expected behavior.

```go
// RESTDeleteStrategy defines deletion behavior on an object that follows Kubernetes
// API conventions.
type RESTDeleteStrategy interface {
	runtime.ObjectTyper
}

type GarbageCollectionPolicy string

const (
	DeleteDependents GarbageCollectionPolicy = "DeleteDependents"
	OrphanDependents GarbageCollectionPolicy = "OrphanDependents"
)

// GarbageCollectionDeleteStrategy must be implemented by the registry that wants to
// orphan dependents by default.
type GarbageCollectionDeleteStrategy interface {
	// DefaultGarbageCollectionPolicy returns the default garbage collection behavior.
	DefaultGarbageCollectionPolicy() GarbageCollectionPolicy
}

// RESTGracefulDeleteStrategy must be implemented by the registry that supports
// graceful deletion.
type RESTGracefulDeleteStrategy interface {
	// CheckGracefulDelete should return true if the object can be gracefully deleted and set
	// any default values on the DeleteOptions.
	CheckGracefulDelete(ctx genericapirequest.Context, obj runtime.Object, options *metav1.DeleteOptions) bool
}
```

**Release note**:

```
NONE
```
2017-05-30 08:41:57 -07:00
.github Merge pull request #44947 from xiangpengzhao/fix-issue-template 2017-05-27 21:36:21 -07:00
api Merge pull request #46407 from liggitt/namespace-delete-collection 2017-05-28 13:16:54 -07:00
build Bump CNI base image to go1.7.6 2017-05-29 09:38:16 -07:00
cluster Merge pull request #46552 from bowei/gcloud-beta 2017-05-30 08:33:46 -07:00
cmd move CRD from alpha to beta 2017-05-30 07:57:26 -04:00
docs Merge pull request #46407 from liggitt/namespace-delete-collection 2017-05-28 13:16:54 -07:00
examples Correct spelling in quobyte 2017-05-29 00:42:23 +08:00
federation Merge pull request #45534 from YuPengZTE/devPodStatus 2017-05-30 04:45:59 -07:00
Godeps Merge pull request #45269 from xilabao/update-gopass 2017-05-25 07:20:59 -07:00
hack move CRD from alpha to beta 2017-05-30 07:57:26 -04:00
hooks
logo
pkg Merge pull request #46608 from fabianofranz/fixes_kubectl_cache_on_windows 2017-05-30 08:41:54 -07:00
plugin Added k82cn as kube-scheduler approver. 2017-05-26 22:26:20 +08:00
staging Merge pull request #46390 from enj/enj/i/require_delete_strategy 2017-05-30 08:41:57 -07:00
test Merge pull request #46613 from FengyunPan/fix-e2e-service 2017-05-30 04:46:04 -07:00
third_party
translations Fix go-xgettext (go get) reference on translations README 2017-05-27 21:24:13 +02:00
vendor Merge pull request #45269 from xilabao/update-gopass 2017-05-25 07:20:59 -07:00
.bazelrc move build related files out of the root directory 2017-05-15 15:53:54 -07:00
.gazelcfg.json
.generated_files
.gitattributes
.gitignore
BUILD.bazel move build related files out of the root directory 2017-05-15 15:53:54 -07:00
CHANGELOG.md Merge pull request #45327 from zhangxiaoyu-zidif/first-letter-to-be-caps 2017-05-30 01:36:35 -07:00
code-of-conduct.md
CONTRIBUTING.md
labels.yaml
LICENSE
Makefile move build related files out of the root directory 2017-05-15 15:53:54 -07:00
Makefile.generated_files move build related files out of the root directory 2017-05-15 15:53:54 -07:00
OWNERS
OWNERS_ALIASES Move PDB controller and type ownership to SIG-Apps 2017-05-22 12:55:28 -07:00
README.md
Vagrantfile
WORKSPACE move build related files out of the root directory 2017-05-15 15:53:54 -07:00

Kubernetes

Submit Queue Widget GoDoc Widget


Kubernetes is an open source system for managing containerized applications across multiple hosts, providing basic mechanisms for deployment, maintenance, and scaling of applications.

Kubernetes builds upon a decade and a half of experience at Google running production workloads at scale using a system called Borg, combined with best-of-breed ideas and practices from the community.

Kubernetes is hosted by the Cloud Native Computing Foundation (CNCF). If you are a company that wants to help shape the evolution of technologies that are container-packaged, dynamically-scheduled and microservices-oriented, consider joining the CNCF. For details about who's involved and how Kubernetes plays a role, read the CNCF announcement.


To start using Kubernetes

See our documentation on kubernetes.io.

Try our interactive tutorial.

Take a free course on Scalable Microservices with Kubernetes.

To start developing Kubernetes

The community repository hosts all information about building Kubernetes from source, how to contribute code and documentation, who to contact about what, etc.

If you want to build Kubernetes right away there are two options:

You have a working Go environment.
$ go get -d k8s.io/kubernetes
$ cd $GOPATH/src/k8s.io/kubernetes
$ make
You have a working Docker environment.
$ git clone https://github.com/kubernetes/kubernetes
$ cd kubernetes
$ make quick-release

If you are less impatient, head over to the developer's documentation.

Support

If you need support, start with the troubleshooting guide and work your way through the process that we've outlined.

That said, if you have questions, reach out to us one way or another.

Analytics