Production-Grade Container Scheduling and Management
Go to file
Kubernetes Submit Queue a7d788d91f
Merge pull request #60886 from mattjmcnaughton/mattjmcnaughton/59975-object-metrics-ignore-unready-pods
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Ignore unready pods when calculating desired replicas

**What this PR does / why we need it**:

This PR causes `GetExternalMetricReplicas` and `GetObjectMetricReplicas` to ignore unready pods when computing the number of desired replicas. If we don't ignore unready pods, there is a risk of overscaling. See the commit messages for examples and implementation info.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #59975 

**Special notes for your reviewer**:
@MaciekPytel and I consciously chose to save `GetExternalPerPodMetricReplicas` for a separate PR, as we aren't definite on what is the preferred behavior.

**Release note**:

```release-note
Unready pods will no longer impact the number of desired replicas when using horizontal auto-scaling with external metrics or object metrics.
```
2018-03-21 01:34:23 -07:00
.github
api Merge pull request #60682 from hanxiaoshuai/update0302 2018-03-07 17:20:04 -08:00
build Merge pull request #60923 from ipuustin/shell-bugfix5 2018-03-20 15:34:34 -07:00
cluster Merge pull request #60873 from wwwtyro/rye/upgrade-needed-bugfix 2018-03-20 10:34:41 -07:00
cmd Merge pull request #60759 from hzxuzhonghu/etcd-flag-validate 2018-03-20 15:34:27 -07:00
docs Merge pull request #60682 from hanxiaoshuai/update0302 2018-03-07 17:20:04 -08:00
examples Merge pull request #58349 from humblec/patch-2 2018-03-20 18:34:35 -07:00
Godeps Merge pull request #60450 from verult/repd-beta-integration 2018-03-08 16:27:05 -08:00
hack Merge pull request #61094 from nikhita/remove-hack-test-cmd 2018-03-20 23:34:33 -07:00
logo
pkg Merge pull request #60886 from mattjmcnaughton/mattjmcnaughton/59975-object-metrics-ignore-unready-pods 2018-03-21 01:34:23 -07:00
plugin Merge pull request #60710 from NickrenREN/admission-pv-dir-change 2018-03-20 10:34:33 -07:00
staging Merge pull request #61105 from lcfang/test0313-2 2018-03-20 23:34:42 -07:00
test Merge pull request #61085 from hzxuzhonghu/unversioned-cleanup 2018-03-20 20:34:31 -07:00
third_party Merge pull request #60506 from php-coder/fix_suppress_gdate_cmd 2018-02-28 07:20:25 -08:00
translations Merge pull request #51925 from zhanghuidinah/fix-broken-link 2018-02-27 21:40:21 -08:00
vendor Merge pull request #60450 from verult/repd-beta-integration 2018-03-08 16:27:05 -08:00
.bazelrc
.generated_files
.gitattributes Hide generated files only on github 2018-01-22 10:58:48 +01:00
.gitignore fix all the typos across the project 2018-02-11 11:04:14 +08:00
.kazelcfg.json
BUILD.bazel
CHANGELOG-1.2.md
CHANGELOG-1.3.md fix the format for github error 2018-01-31 14:49:29 +08:00
CHANGELOG-1.4.md fix the format for github error 2018-02-02 18:44:27 +08:00
CHANGELOG-1.5.md fix typo in kubeadm 2018-02-06 13:48:18 +08:00
CHANGELOG-1.6.md Fix typo 2018-02-01 19:11:19 +08:00
CHANGELOG-1.7.md Update CHANGELOG-1.7.md for v1.7.15. 2018-03-19 13:10:22 -07:00
CHANGELOG-1.8.md Update CHANGELOG-1.8.md for v1.8.10. 2018-03-19 18:45:59 +00:00
CHANGELOG-1.9.md Update CHANGELOG-1.9.md for v1.9.5. 2018-03-19 16:57:54 +00:00
CHANGELOG-1.10.md Update CHANGELOG-1.10.md for v1.10.0-rc.1. 2018-03-19 20:35:56 -04:00
CHANGELOG.md Update release note links for 1.10 2018-01-17 22:45:12 +01:00
code-of-conduct.md Update code-of-conduct.md 2017-12-20 13:33:36 -05:00
CONTRIBUTING.md Pointed to community/contributors/guide/README.md 2017-12-15 22:08:34 +05:30
labels.yaml
LICENSE
Makefile
Makefile.generated_files
OWNERS
OWNERS_ALIASES Merge pull request #61281 from soltysh/sig-cli-approvers 2018-03-20 12:34:39 -07:00
README.md Update README.md 2018-02-11 04:34:01 +00:00
SUPPORT.md
WORKSPACE

Kubernetes

Submit Queue Widget GoDoc Widget CII Best Practices


Kubernetes is an open source system for managing containerized applications across multiple hosts; providing basic mechanisms for deployment, maintenance, and scaling of applications.

Kubernetes builds upon a decade and a half of experience at Google running production workloads at scale using a system called Borg, combined with best-of-breed ideas and practices from the community.

Kubernetes is hosted by the Cloud Native Computing Foundation (CNCF). If you are a company that wants to help shape the evolution of technologies that are container-packaged, dynamically-scheduled and microservices-oriented, consider joining the CNCF. For details about who's involved and how Kubernetes plays a role, read the CNCF announcement.


To start using Kubernetes

See our documentation on kubernetes.io.

Try our interactive tutorial.

Take a free course on Scalable Microservices with Kubernetes.

To start developing Kubernetes

The community repository hosts all information about building Kubernetes from source, how to contribute code and documentation, who to contact about what, etc.

If you want to build Kubernetes right away there are two options:

You have a working Go environment.
$ go get -d k8s.io/kubernetes
$ cd $GOPATH/src/k8s.io/kubernetes
$ make
You have a working Docker environment.
$ git clone https://github.com/kubernetes/kubernetes
$ cd kubernetes
$ make quick-release

For the full story, head over to the developer's documentation.

Support

If you need support, start with the troubleshooting guide, and work your way through the process that we've outlined.

That said, if you have questions, reach out to us one way or another.

Analytics