Production-Grade Container Scheduling and Management
Go to file
Kubernetes Submit Queue b63fab3aaf
Merge pull request #58036 from shlevy/cri-ImageStatus-info
Automatic merge from submit-queue (batch tested with PRs 58171, 58036, 60540). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

dockershim: Return Labels as Info in ImageStatus.

c6ddc749e8 added an Info field to
ImageStatusResponse when Verbose is true. This makes the image's
Labels available in that field, rather than unconditionally returning
an empty map.

**What this PR does / why we need it**:

This PR exposes an image's `Labels` through the CRI. In particular, I want this so I can write an `ImageService` wrapper that delegates all operations to a real `ImageService` but also, when the right `Labels`, ensures any needed [nix store](https://nixos.org/nix/) paths are present on the system when an image is pulled, enabling users to use nix for package distribution while still using containers for isolation and kubernetes for orchestration. In general, though, this should be useful for anything that wants to know about an image's `Labels`

**Special notes for your reviewer**:

I'd prefer to put this change into the `Image` protobuf type instead of putting it into `Info` (gated by `Verbose` or not, available in other requests like `ListImages` or not), but that would be a change to the protocol and it seems `Info` was introduced exactly for this purpose. If it's acceptable to put this into `Image`, I'll rework this.

If this change is acceptable, I will also do the work for `cri-o`, `rktlet`, `frakti`, and `cri-containerd` where applicable.

I have started the process for my employer to sign on to the CLA. I don't have reason to expect it to take long, but because there is more work to do if this change is desired I'd prefer if we can start review before that is completed.

**Release note**:

```release-note
dockershim now makes an Image's Labels available in the Info field of ImageStatusResponse
```
2018-02-28 09:48:23 -08:00
.github
api Merge pull request #59912 from superbrothers/fix-broken-link 2018-02-26 21:34:14 -08:00
build remove gcloud docker -- since it's deprecated 2018-02-28 00:24:27 -08:00
cluster Merge pull request #58171 from verult/NoPath-FlexDirExec 2018-02-28 09:48:19 -08:00
cmd Merge pull request #60291 from hzxuzhonghu/cloud-cm-use-healthz 2018-02-28 03:37:37 -08:00
docs Merge pull request #57415 from stealthybox/feature/kubeadm_594-etcd_tls 2018-02-24 21:19:42 -08:00
examples Merge pull request #59149 from verult/flex-examples 2018-02-28 04:54:29 -08:00
Godeps Merge pull request #54631 from venkat-443/master 2018-02-28 03:37:33 -08:00
hack Ensure generated files are present before typechecking. 2018-02-27 14:31:57 -08:00
logo
pkg Merge pull request #58036 from shlevy/cri-ImageStatus-info 2018-02-28 09:48:23 -08:00
plugin Merge pull request #55019 from mikedanese/svcacct 2018-02-27 10:50:46 -08:00
staging Merge pull request #52900 from xiangpengzhao/remove-ed-const 2018-02-28 06:07:31 -08:00
test Merge pull request #58171 from verult/NoPath-FlexDirExec 2018-02-28 09:48:19 -08:00
third_party Merge pull request #60506 from php-coder/fix_suppress_gdate_cmd 2018-02-28 07:20:25 -08:00
translations Merge pull request #51925 from zhanghuidinah/fix-broken-link 2018-02-27 21:40:21 -08:00
vendor Merge pull request #54631 from venkat-443/master 2018-02-28 03:37:33 -08:00
.bazelrc
.generated_files
.gitattributes
.gitignore fix all the typos across the project 2018-02-11 11:04:14 +08:00
.kazelcfg.json
BUILD.bazel
CHANGELOG-1.2.md
CHANGELOG-1.3.md
CHANGELOG-1.4.md fix the format for github error 2018-02-02 18:44:27 +08:00
CHANGELOG-1.5.md fix typo in kubeadm 2018-02-06 13:48:18 +08:00
CHANGELOG-1.6.md
CHANGELOG-1.7.md
CHANGELOG-1.8.md Update CHANGELOG-1.8.md for v1.8.8. 2018-02-09 15:01:39 -08:00
CHANGELOG-1.9.md Fix incorrectly formatted URL 2018-02-22 12:20:54 -08:00
CHANGELOG-1.10.md Merge pull request #59250 from thedrow/patch-1 2018-02-20 20:00:38 -08:00
CHANGELOG.md
code-of-conduct.md
CONTRIBUTING.md
labels.yaml
LICENSE
Makefile
Makefile.generated_files
OWNERS
OWNERS_ALIASES Remove dep-reviewers 2018-02-26 17:04:32 -08:00
README.md Update README.md 2018-02-11 04:34:01 +00:00
SUPPORT.md
WORKSPACE

Kubernetes

Submit Queue Widget GoDoc Widget CII Best Practices


Kubernetes is an open source system for managing containerized applications across multiple hosts; providing basic mechanisms for deployment, maintenance, and scaling of applications.

Kubernetes builds upon a decade and a half of experience at Google running production workloads at scale using a system called Borg, combined with best-of-breed ideas and practices from the community.

Kubernetes is hosted by the Cloud Native Computing Foundation (CNCF). If you are a company that wants to help shape the evolution of technologies that are container-packaged, dynamically-scheduled and microservices-oriented, consider joining the CNCF. For details about who's involved and how Kubernetes plays a role, read the CNCF announcement.


To start using Kubernetes

See our documentation on kubernetes.io.

Try our interactive tutorial.

Take a free course on Scalable Microservices with Kubernetes.

To start developing Kubernetes

The community repository hosts all information about building Kubernetes from source, how to contribute code and documentation, who to contact about what, etc.

If you want to build Kubernetes right away there are two options:

You have a working Go environment.
$ go get -d k8s.io/kubernetes
$ cd $GOPATH/src/k8s.io/kubernetes
$ make
You have a working Docker environment.
$ git clone https://github.com/kubernetes/kubernetes
$ cd kubernetes
$ make quick-release

For the full story, head over to the developer's documentation.

Support

If you need support, start with the troubleshooting guide, and work your way through the process that we've outlined.

That said, if you have questions, reach out to us one way or another.

Analytics