github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-29 22:46:12 +00:00
Code Issues Projects Releases Wiki Activity
Production-Grade Container Scheduling and Management
51,231 Commits 42 Branches 7,905 Tags 1.3 GiB
Go 97%
Shell 2.6%
PowerShell 0.2%
b664aebb49
Go to file
Kubernetes Submit Queue b664aebb49 Merge pull request #48915 from mattmoyer/fix-kubeadm-config-regression 
Automatic merge from submit-queue

kubeadm: fix broken `kubeadm init --config` flag

**What this PR does / why we need it**:
This code was changed in ea196490a0 (https://github.com/kubernetes/kubernetes/pull/43558) to validate that `--config` wasn't passed along with other flags. Unfortunately, the implementation was checking `PersistentFlags()`, which was not parsed at the point it was being validated.

The fix is to use `Flags()` instead, which contains the expected data.


**Which issue this PR fixes** fixes https://github.com/kubernetes/kubeadm/issues/345

**Special notes for your reviewer**:
This is a regression that was cherry picked (https://github.com/kubernetes/kubernetes/pull/48577) into the `release-1.7` branch. We should fix this before the next 1.7 point release.

This is awkward to unit test without restructuring the code. I think this command parsing code would be a good candidate for some higher level tests.

**Release note**:
```release-note
Fix a regression that broke the `--config` flag for `kubeadm init`.
```

/assign @luxas
2017-07-14 09:03:18 -07:00
.github Merge pull request #46714 from castrojo/new-issue-template 2017-06-22 16:43:47 -07:00
api Name change: s/timstclair/tallclair/ 2017-07-10 14:05:46 -07:00
build Move kubectl e2e tests to their own directory and prefix the test names with [sig-cli] 2017-07-12 09:42:06 -07:00
cluster Merge pull request #48812 from crassirostris/change-fluentd-monitoring 2017-07-14 04:43:42 -07:00
cmd kubeadm: fix broken kubeadm init --config flag. 2017-07-13 16:41:32 -07:00
docs Merge pull request #48353 from deads2k/tpr-17-delete-01 2017-07-05 05:49:30 -07:00
examples Merge pull request #46825 from zjj2wry/fix_doc_spell 2017-07-13 18:50:36 -07:00
federation fed: Move namespace propagation to the sync controller 2017-07-12 13:54:24 -07:00
Godeps pull compute alpha api client 2017-07-12 13:46:53 -07:00
hack Merge pull request #48651 from shyamjvs/logexporter-supporter 2017-07-14 03:10:45 -07:00
logo
pkg Merge pull request #48669 from supereagle/revert-pr46246 2017-07-14 00:32:09 -07:00
plugin Merge pull request #47955 from CaoShuFeng/trivial 2017-07-13 18:50:19 -07:00
staging Merge pull request #48276 from pmichali/issue48225 2017-07-14 04:43:44 -07:00
test Remove max-pods density test 2017-07-14 14:32:29 +02:00
third_party change junit output format 2017-06-14 11:26:51 -07:00
translations removed 'Storage' option from 'kubectl top' like options 2017-06-23 08:34:53 -07:00
vendor use overrided api endpoint in gce cloud provider 2017-07-12 15:10:13 -07:00
.bazelrc move build related files out of the root directory 2017-05-15 15:53:54 -07:00
.gazelcfg.json
.generated_files
.gitattributes
.gitignore
BUILD.bazel move build related files out of the root directory 2017-05-15 15:53:54 -07:00
CHANGELOG.md Merge pull request #48897 from nicksardo/known-issue-1.7 2017-07-13 23:39:10 -07:00
code-of-conduct.md
CONTRIBUTING.md
labels.yaml Update labels.yaml 2017-07-11 11:21:18 -07:00
LICENSE
Makefile move build related files out of the root directory 2017-05-15 15:53:54 -07:00
Makefile.generated_files move build related files out of the root directory 2017-05-15 15:53:54 -07:00
OWNERS Add jregan to OWNERS for kubectl isolation work. 2017-05-30 14:32:48 -07:00
OWNERS_ALIASES Name change: s/timstclair/tallclair/ 2017-07-10 14:05:46 -07:00
README.md
Vagrantfile
WORKSPACE move build related files out of the root directory 2017-05-15 15:53:54 -07:00

README.md

Kubernetes

Submit Queue Widget GoDoc Widget

Kubernetes is an open source system for managing containerized applications across multiple hosts, providing basic mechanisms for deployment, maintenance, and scaling of applications.

Kubernetes builds upon a decade and a half of experience at Google running production workloads at scale using a system called Borg, combined with best-of-breed ideas and practices from the community.

Kubernetes is hosted by the Cloud Native Computing Foundation (CNCF). If you are a company that wants to help shape the evolution of technologies that are container-packaged, dynamically-scheduled and microservices-oriented, consider joining the CNCF. For details about who's involved and how Kubernetes plays a role, read the CNCF announcement.

To start using Kubernetes

See our documentation on kubernetes.io.

Try our interactive tutorial.

Take a free course on Scalable Microservices with Kubernetes.

To start developing Kubernetes

The community repository hosts all information about building Kubernetes from source, how to contribute code and documentation, who to contact about what, etc.

If you want to build Kubernetes right away there are two options:

You have a working Go environment.
$ go get -d k8s.io/kubernetes
$ cd $GOPATH/src/k8s.io/kubernetes
$ make
You have a working Docker environment.
$ git clone https://github.com/kubernetes/kubernetes
$ cd kubernetes
$ make quick-release

If you are less impatient, head over to the developer's documentation.

Support

If you need support, start with the troubleshooting guide and work your way through the process that we've outlined.

That said, if you have questions, reach out to us one way or another.

Analytics