Production-Grade Container Scheduling and Management
Go to file
Kubernetes Submit Queue d65039c56c
Merge pull request #65751 from andyzhangx/mount-windows-fix
Automatic merge from submit-queue (batch tested with PRs 65381, 65751). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

fix smb mount security issue

**What this PR does / why we need it**:
fix smb mount security issue:
user PowerShell Environment Variables to store user input string to prevent command line injection, the env var in PowerShell would be taken as literal values and not as executable vulnerable code, this kind of fix is common for command line injection issue (called: parameterized way)

Originally use go sdk for `New-SmbGlobalMapping` is best solution, while after discussion with Windows team, go API for `New-SmbGlobalMapping` is not ready yet and the new functionality of basic win32 API [NetUseAdd](https://msdn.microsoft.com/en-us/library/windows/desktop/aa370645(v=vs.85).aspx) is not public yet, use [PowerShell with Environment Variables](https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_environment_variables?view=powershell-5.1) is also their recommended way.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #65750 

**Special notes for your reviewer**:
 - This is a security issue fix, no behavior change, E2E test of smb mount passes.
 - Original logging as `azureMount` is incorrect since this mount_windows is for mount disk & smb, it's a common feature on Windows, not specific to Azure, I will send another PR to fixing all the logging naming issue, anyway it's not related to this security issue. Let's keep this PR simple.

**Release note**:

```
fix smb mount security issue
```

/sig windows
/sig storage
/kind bug

@jessfraz 
/assign @jsafrane @msau42
2018-07-03 06:16:06 -07:00
.github
api Fix comments about default mount propagation 2018-06-28 17:04:41 -04:00
build Merge pull request #65319 from MaciekPytel/gke_manifests 2018-06-29 12:15:05 -07:00
cluster Merge pull request #65381 from ostromart/istio-fix-latest-label 2018-07-03 06:16:03 -07:00
cmd Merge pull request #65731 from bsalamat/cfg_no_warn 2018-07-02 23:24:05 -07:00
docs Fix comments about default mount propagation 2018-06-28 17:04:41 -04:00
Godeps Merge pull request #65568 from eisig/aws-sdk 2018-07-03 03:24:04 -07:00
hack Merge pull request #65648 from sttts/sttts-k8s-metrics-codegen 2018-07-02 19:46:09 -07:00
logo
pkg fix smb mount security issue 2018-07-03 08:03:31 +00:00
plugin Addressed reviewers comments 2018-06-29 10:22:11 -07:00
staging Merge pull request #65357 from nikhita/crd-subresources-root-schema 2018-07-03 03:24:00 -07:00
test Merge pull request #65635 from neolit123/zfs-fix 2018-07-02 16:52:12 -07:00
third_party
translations
vendor Merge pull request #65568 from eisig/aws-sdk 2018-07-03 03:24:04 -07:00
.bazelrc
.generated_files
.gitattributes
.gitignore
.kazelcfg.json
BUILD.bazel
CHANGELOG-1.2.md
CHANGELOG-1.3.md
CHANGELOG-1.4.md
CHANGELOG-1.5.md
CHANGELOG-1.6.md
CHANGELOG-1.7.md
CHANGELOG-1.8.md
CHANGELOG-1.9.md Update CHANGELOG-1.9.md for v1.9.9. 2018-06-29 05:49:31 +00:00
CHANGELOG-1.10.md
CHANGELOG-1.11.md Fix K8s-Storage-Plugins repo 2018-06-28 10:36:05 +00:00
CHANGELOG.md Insert human curated 1.11 release notes and set current version 2018-06-27 19:19:19 -04:00
code-of-conduct.md
CONTRIBUTING.md
labels.yaml
LICENSE
Makefile
Makefile.generated_files
OWNERS
OWNERS_ALIASES
README.md
SECURITY_CONTACTS
SUPPORT.md
WORKSPACE

Kubernetes

Submit Queue Widget GoDoc Widget CII Best Practices


Kubernetes is an open source system for managing containerized applications across multiple hosts; providing basic mechanisms for deployment, maintenance, and scaling of applications.

Kubernetes builds upon a decade and a half of experience at Google running production workloads at scale using a system called Borg, combined with best-of-breed ideas and practices from the community.

Kubernetes is hosted by the Cloud Native Computing Foundation (CNCF). If you are a company that wants to help shape the evolution of technologies that are container-packaged, dynamically-scheduled and microservices-oriented, consider joining the CNCF. For details about who's involved and how Kubernetes plays a role, read the CNCF announcement.


To start using Kubernetes

See our documentation on kubernetes.io.

Try our interactive tutorial.

Take a free course on Scalable Microservices with Kubernetes.

To start developing Kubernetes

The community repository hosts all information about building Kubernetes from source, how to contribute code and documentation, who to contact about what, etc.

If you want to build Kubernetes right away there are two options:

You have a working Go environment.
$ go get -d k8s.io/kubernetes
$ cd $GOPATH/src/k8s.io/kubernetes
$ make
You have a working Docker environment.
$ git clone https://github.com/kubernetes/kubernetes
$ cd kubernetes
$ make quick-release

For the full story, head over to the developer's documentation.

Support

If you need support, start with the troubleshooting guide, and work your way through the process that we've outlined.

That said, if you have questions, reach out to us one way or another.

Analytics