mirror of
https://github.com/k3s-io/kubernetes.git
synced 2026-07-19 07:25:19 +00:00
e74b4063d8
This commit reorganizes component-base's metrics package to bring about the following changes: * migrate all related functions and methods to options.go (from registry.go) * inline v1.MetricsConfiguration in Options and expose it in api/v1, also re-generate deepcopy assets for the same * add missing validation functions for MetricsConfiguration fields * add missing setter functions for MetricsConfiguration fields * addressed a logical bug in SetDisabledMetric to not increment the disabled metrics counter when a duplicate metric is disabled again * refactored some tests to also take into consideration meta metrics, wherever applicable * changed validateAllowListMappingManifest's godoc to mention that components are expected to pass in the *absolute* path to the manifest file Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
Kubernetes hack GuideLines
This document describes how you can use the scripts from hack directory
and gives a brief introduction and explanation of these scripts.
Overview
The hack directory contains many scripts that ensure continuous development of kubernetes,
enhance the robustness of the code, improve development efficiency, etc.
The explanations and descriptions of these scripts are helpful for contributors.
For details, refer to the following guidelines.
Key scripts
verify-all.sh: This script is a vestigial redirection, Please do not add "real" logic. It is equivalent tomake verify.update-all.sh: This script is a vestigial redirection, Please do not add "real" logic. Thetruetarget of this makerule ishack/make-rules/update.sh.It is equivalent tomake update.
Attention
Note that all scripts must be run from the Kubernetes root directory.
We should run hack/verify-all.sh before submitting a PR and if anything fails run hack/update-all.sh.