github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-08-01 09:04:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

openai[patch]: fix name param (#19365)

Browse Source
This commit is contained in:
Erick Friis 2024-03-20 15:22:09 -07:00 committed by GitHub
parent f6c8700326
commit 0b20c098df
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libs/partners/openai/Makefile
View File

@ -6,9 +6,9 @@ all: help
# Define a variable for the test file path.
TEST_FILE ?= tests/unit_tests/
integration_tests: TEST_FILE=tests/integration_tests/
integration_test integration_tests: TEST_FILE=tests/integration_tests/
test tests integration_tests:
test tests integration_test integration_tests:
poetry run pytest $(TEST_FILE)

13
libs/partners/openai/langchain_openai/chat_models/base.py
View File

@ -140,8 +140,17 @@ def _convert_message_to_dict(message: BaseMessage) -> dict:
"""
message_dict: Dict[str, Any] = {
"content": message.content,
"name": message.name,
}
if message.name is not None:
message_dict["name"] = message.name
elif (
"name" in message.additional_kwargs
and message.additional_kwargs["name"] is not None
):
# fall back on additional kwargs for backwards compatibility
message_dict["name"] = message.additional_kwargs["name"]
# populate role and additional message data
if isinstance(message, ChatMessage):
message_dict["role"] = message.role
elif isinstance(message, HumanMessage):
@ -171,8 +180,6 @@ def _convert_message_to_dict(message: BaseMessage) -> dict:
del message_dict["name"]
else:
raise TypeError(f"Got unknown type {message}")
if "name" in message.additional_kwargs:
message_dict["name"] = message.additional_kwargs["name"]
return message_dict