github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-09-11 07:50:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(core): reactivate commented tests in test_indexing (#32882)

Browse Source 
* These tests now pass
* Commenting them is a [ruff
ERA](https://docs.astral.sh/ruff/rules/commented-out-code/) violation
This commit is contained in:
Christophe Bornet
2025-09-10 17:14:14 +02:00
committed by GitHub
parent 181bb91ce0
commit 12921a94c5
3 changed files with 16 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libs/core/langchain_core/tools/base.py
View File

@@ -1362,8 +1362,8 @@ def get_all_basemodel_annotations(
continue
# if class = FooBar inherits from Baz[str]:
# parent = Baz[str],
# parent_origin = Baz,
# parent = class Baz[str],
# parent_origin = class Baz,
# generic_type_vars = (type vars in Baz)
# generic_map = {type var in Baz: str}
generic_type_vars: tuple = getattr(parent_origin, "__parameters__", ())

2
libs/core/langchain_core/tools/convert.py
View File

@@ -315,7 +315,7 @@ def tool(
if runnable is not None:
# tool is used as a function
# tool_from_runnable = tool("name", runnable)
# for instance tool_from_runnable = tool("name", runnable)
if not name_or_callable:
msg = "Runnable without name for tool constructor"
raise ValueError(msg)

29
libs/core/tests/unit_tests/indexing/test_indexing.py
View File

@@ -2421,14 +2421,12 @@ def test_index_into_document_index(record_manager: InMemoryRecordManager) -> Non
"num_updated": 2,
}
# TODO: This test is failing due to an existing bug with DocumentIndex deletion
# when indexing an empty list. Skipping this assertion for now.
# assert index([], record_manager, document_index, cleanup="full") == {
# "num_added": 0,
# "num_deleted": 2,
# "num_skipped": 0,
# "num_updated": 0,
# }
assert index([], record_manager, document_index, cleanup="full") == {
"num_added": 0,
"num_deleted": 2,
"num_skipped": 0,
"num_updated": 0,
}
async def test_aindex_into_document_index(
@@ -2460,6 +2458,7 @@ async def test_aindex_into_document_index(
"num_skipped": 2,
"num_updated": 0,
}
assert await aindex(
docs, arecord_manager, document_index, cleanup="full", force_update=True
) == {
@@ -2469,14 +2468,12 @@ async def test_aindex_into_document_index(
"num_updated": 2,
}
# TODO: This test is failing due to an existing bug with DocumentIndex deletion
# when indexing an empty list. Skipping this assertion for now.
# assert await aindex([], arecord_manager, document_index, cleanup="full") == {
# "num_added": 0,
# "num_deleted": 2,
# "num_skipped": 0,
# "num_updated": 0,
# }
assert await aindex([], arecord_manager, document_index, cleanup="full") == {
"num_added": 0,
"num_deleted": 2,
"num_skipped": 0,
"num_updated": 0,
}
def test_index_with_upsert_kwargs(