github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-08-09 13:00:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

openai: fix lint and tests

Browse Source
This commit is contained in:
Chester Curme 2025-07-23 09:53:46 -04:00
parent eb8d32aff2
commit 7c0d1cb324
3 changed files with 26 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
libs/partners/openai/langchain_openai/chat_models/base.py
View File

@ -3807,11 +3807,12 @@ def _construct_lc_result_from_responses_api(
)
if image_generation_call.output_format:
mime_type = f"image/{image_generation_call.output_format}"
for block in message.content:
for content_block in message.content:
# OK to mutate output message
if (
block.get("type") == "image"
and "base64" in block
isinstance(content_block, dict)
and content_block.get("type") == "image"
and "base64" in content_block
and "mime_type" not in block
):
block["mime_type"] = mime_type
@ -4055,10 +4056,13 @@ def _convert_responses_chunk_to_generation_chunk(
)
elif output_version == "v1":
message = cast(AIMessageChunk, _convert_to_v1_from_responses(message))
for block in message.content:
if block.get("index", -1) > current_index:
for content_block in message.content:
if (
isinstance(content_block, dict)
and content_block.get("index", -1) > current_index
):
# blocks were added for v1
current_index = block["index"]
current_index = content_block["index"]
else:
pass
return (

20
libs/partners/openai/tests/integration_tests/chat_models/test_responses_api.py
View File

@ -496,7 +496,7 @@ def test_code_interpreter(output_version: Literal["v0", "responses/v1", "v1"]) -
code_interpreter_result = next(
item
for item in response.content
if item["type"] == "code_interpreter_result"
if isinstance(item, dict) and item["type"] == "code_interpreter_result"
)
assert tool_outputs
assert code_interpreter_result
@ -528,12 +528,14 @@ def test_code_interpreter(output_version: Literal["v0", "responses/v1", "v1"]) -
]
else:
code_interpreter_call = next(
item for item in response.content if item["type"] == "code_interpreter_call"
item
for item in response.content
if isinstance(item, dict) and item["type"] == "code_interpreter_call"
)
code_interpreter_result = next(
item
for item in response.content
if item["type"] == "code_interpreter_result"
if isinstance(item, dict) and item["type"] == "code_interpreter_result"
)
assert code_interpreter_call
assert code_interpreter_result
@ -701,7 +703,9 @@ def test_image_generation_streaming(output_version: str) -> None:
# v1
standard_keys = {"type", "base64", "id", "status", "index"}
tool_output = next(
block for block in complete_ai_message.content if block["type"] == "image"
block
for block in complete_ai_message.content
if isinstance(block, dict) and block["type"] == "image"
)
assert set(standard_keys).issubset(tool_output.keys())
@ -758,7 +762,9 @@ def test_image_generation_multi_turn(output_version: str) -> None:
else:
standard_keys = {"type", "base64", "id", "status"}
tool_output = next(
block for block in ai_message.content if block["type"] == "image"
block
for block in ai_message.content
if isinstance(block, dict) and block["type"] == "image"
)
assert set(standard_keys).issubset(tool_output.keys())
@ -810,6 +816,8 @@ def test_image_generation_multi_turn(output_version: str) -> None:
else:
standard_keys = {"type", "base64", "id", "status"}
tool_output = next(
block for block in ai_message2.content if block["type"] == "image"
block
for block in ai_message2.content
if isinstance(block, dict) and block["type"] == "image"
)
assert set(standard_keys).issubset(tool_output.keys())

6
libs/partners/openai/tests/unit_tests/chat_models/test_base.py
View File

@ -2534,8 +2534,7 @@ def test_convert_to_v1_from_chat_completions(
},
{
"type": "image",
"source_type": "base64",
"data": "...",
"base64": "...",
"id": "img_123",
},
{
@ -2739,8 +2738,7 @@ def test_convert_from_v1_to_responses(
},
{
"type": "image",
"source_type": "base64",
"data": "...",
"base64": "...",
"id": "img_123",
},
{