github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-08-03 18:24:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

parent retriever nit (#9570)

Browse Source 
if ids are nullable seems like they should have default val None.
mirrors VectorStore interface as well. cc @mcantillon21 @jacoblee93
This commit is contained in:
Bagatur 2023-08-22 11:58:16 -07:00 committed by GitHub
parent f3ba9ce7f4
commit 81163e3c0c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libs/langchain/langchain/retrievers/parent_document_retriever.py
View File

@ -97,7 +97,7 @@ class ParentDocumentRetriever(BaseRetriever):
def add_documents( def add_documents(
self, self,
documents: List[Document], documents: List[Document],
ids: Optional[List[str]], ids: Optional[List[str]] = None,
add_to_docstore: bool = True, add_to_docstore: bool = True,
) -> None: ) -> None:
"""Adds documents to the docstore and vectorstores. """Adds documents to the docstore and vectorstores.