mirror of
https://github.com/hwchase17/langchain.git
synced 2025-06-23 15:19:33 +00:00
Replaced bind variable in SQL with formatted string for compatibility with sql syntax. (#21439)
Thank you for contributing to LangChain! - [ ] **PR title**: "package: description" - Where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes. - Example: "community: add foobar LLM" - [ ] **PR message**: ***Delete this entire checklist*** and replace with - **Description:** a description of the change - **Issue:** the issue # it fixes, if applicable - **Dependencies:** any dependencies required for this change - **Twitter handle:** if your PR gets announced, and you'd like a mention, we'll gladly shout you out! - [ ] **Add tests and docs**: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. - [ ] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ Additional guidelines: - Make sure optional dependencies are imported within a function. - Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests. - Most PRs should not touch more than one package. - Changes should be backwards compatible. - If you are adding something to community, do not re-import it in langchain. If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17.
This commit is contained in:
parent
f92006de3c
commit
aa966b6161
@ -623,11 +623,11 @@ class OracleVS(VectorStore):
|
||||
{_get_distance_function(self.distance_strategy)}) as distance
|
||||
FROM {self.table_name}
|
||||
ORDER BY distance
|
||||
FETCH APPROX FIRST :k ROWS ONLY
|
||||
FETCH APPROX FIRST {k} ROWS ONLY
|
||||
"""
|
||||
# Execute the query
|
||||
with self.client.cursor() as cursor:
|
||||
cursor.execute(query, embedding=embedding_arr, k=k)
|
||||
cursor.execute(query, embedding=embedding_arr)
|
||||
results = cursor.fetchall()
|
||||
|
||||
# Filter results if filter is provided
|
||||
@ -683,12 +683,12 @@ class OracleVS(VectorStore):
|
||||
embedding
|
||||
FROM {self.table_name}
|
||||
ORDER BY distance
|
||||
FETCH APPROX FIRST :k ROWS ONLY
|
||||
FETCH APPROX FIRST {k} ROWS ONLY
|
||||
"""
|
||||
|
||||
# Execute the query
|
||||
with self.client.cursor() as cursor:
|
||||
cursor.execute(query, embedding=embedding_arr, k=k)
|
||||
cursor.execute(query, embedding=embedding_arr)
|
||||
results = cursor.fetchall()
|
||||
|
||||
for result in results:
|
||||
|
Loading…
Reference in New Issue
Block a user