mirror of
https://github.com/hwchase17/langchain.git
synced 2026-04-23 20:23:59 +00:00
Improve runnable generator error messages (#18142)
h/t @hinthornw
Thank you for contributing to LangChain!
- [ ] **PR title**: "package: description"
- Where "package" is whichever of langchain, community, core,
experimental, etc. is being modified. Use "docs: ..." for purely docs
changes, "templates: ..." for template changes, "infra: ..." for CI
changes.
- Example: "community: add foobar LLM"
- [ ] **PR message**: ***Delete this entire checklist*** and replace
with
- **Description:** a description of the change
- **Issue:** the issue # it fixes, if applicable
- **Dependencies:** any dependencies required for this change
- **Twitter handle:** if your PR gets announced, and you'd like a
mention, we'll gladly shout you out!
- [ ] **Add tests and docs**: If you're adding a new integration, please
include
1. a test for the integration, preferably unit tests that do not rely on
network access,
2. an example notebook showing its use. It lives in
`docs/docs/integrations` directory.
- [ ] **Lint and test**: Run `make format`, `make lint` and `make test`
from the root of the package(s) you've modified. See contribution
guidelines for more: https://python.langchain.com/docs/contributing/
Additional guidelines:
- Make sure optional dependencies are imported within a function.
- Please do not add dependencies to pyproject.toml files (even optional
ones) unless they are required for unit tests.
- Most PRs should not touch more than one package.
- Changes should be backwards compatible.
- If you are adding something to community, do not re-import it in
langchain.
If no one reviews your PR within a few days, please @-mention one of
baskaryan, efriis, eyurtsev, hwchase17.
This commit is contained in:
@@ -3036,12 +3036,7 @@ class RunnableGenerator(Runnable[Input, Output]):
|
||||
return False
|
||||
|
||||
def __repr__(self) -> str:
|
||||
if hasattr(self, "_transform"):
|
||||
return f"RunnableGenerator({self._transform.__name__})"
|
||||
elif hasattr(self, "_atransform"):
|
||||
return f"RunnableGenerator({self._atransform.__name__})"
|
||||
else:
|
||||
return "RunnableGenerator(...)"
|
||||
return f"RunnableGenerator({self.name})"
|
||||
|
||||
def transform(
|
||||
self,
|
||||
@@ -3049,6 +3044,8 @@ class RunnableGenerator(Runnable[Input, Output]):
|
||||
config: Optional[RunnableConfig] = None,
|
||||
**kwargs: Any,
|
||||
) -> Iterator[Output]:
|
||||
if not hasattr(self, "_transform"):
|
||||
raise NotImplementedError(f"{repr(self)} only supports async methods.")
|
||||
return self._transform_stream_with_config(
|
||||
input, self._transform, config, **kwargs
|
||||
)
|
||||
@@ -3079,7 +3076,7 @@ class RunnableGenerator(Runnable[Input, Output]):
|
||||
**kwargs: Any,
|
||||
) -> AsyncIterator[Output]:
|
||||
if not hasattr(self, "_atransform"):
|
||||
raise NotImplementedError("This runnable does not support async methods.")
|
||||
raise NotImplementedError(f"{repr(self)} only supports sync methods.")
|
||||
|
||||
return self._atransform_stream_with_config(
|
||||
input, self._atransform, config, **kwargs
|
||||
|
||||
Reference in New Issue
Block a user