github/linuxkit
1
0
Fork 0
mirror of https://github.com/linuxkit/linuxkit.git synced 2025-07-29 05:27:41 +00:00
Code Issues Projects Releases Wiki Activity

Avoid brace expansion which is a bashism.

Browse Source 
Building on Debian where /bin/sh is dash:

make[1]: Leaving directory '/home/ijc/development/Docker/moby.git/alpine/packages/docker/docker.git'
mkdir -p bin
cp docker.git/bundles/latest/binary-daemon/{dockerd,docker-runc} bin/
cp: cannot stat 'docker.git/bundles/latest/binary-daemon/{dockerd,docker-runc}': No such file or directory
Makefile:9: recipe for target 'bin' failed

Pasting the construct into a file and running checkbashsisms:
possible bashism in foo line 2 (brace expansion):
cp docker.git/bundles/latest/binary-daemon/{dockerd,docker-runc} bin/

Signed-off-by: Ian Campbell <ian.campbell@docker.com>
This commit is contained in:
Ian Campbell 2016-06-17 13:46:32 +01:00
parent 9fee7113eb
commit 8fab3e5607
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
alpine/packages/docker/Makefile
View File

@ -9,8 +9,11 @@ bin: docker.git
(cd docker.git && git fetch origin --tags && git checkout moby-$(DOCKER_VERSION))
DOCKER_EXPERIMENTAL=$(EXPERIMENTAL) BIND_DIR=$(shell pwd) make -C docker.git binary
mkdir -p bin
cp docker.git/bundles/latest/binary-daemon/{dockerd,docker-runc} bin/
cp docker.git/bundles/latest/binary-daemon/{docker-containerd,docker-containerd-shim,docker-containerd-ctr} bin/
cp docker.git/bundles/latest/binary-daemon/dockerd bin/
cp docker.git/bundles/latest/binary-daemon/docker-runc bin/
cp docker.git/bundles/latest/binary-daemon/docker-containerd bin/
cp docker.git/bundles/latest/binary-daemon/docker-containerd-shim bin/
cp docker.git/bundles/latest/binary-daemon/docker-containerd-ctr bin/
cp docker.git/bundles/latest/binary-daemon/docker-proxy bin/
cp docker.git/bundles/latest/binary-client/docker bin/