commit bdf9b1f31a introduced a bug with disk size handling
where GB was not handled correctly. Fix it.
Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
Use the `with-cdhcpc` branch of charrua-client, which exposes `Dhcp_client_lwt`. Dhcp_client_lwt exposes similar functions to `Dhcp_client_mirage`, but does not impose the structure of a Mirage_types_lwt.ipv4_config on the returned object, rather returning the full lease; the engine can then expose whatever information from the lease it finds to be pertinent.
Signed-off-by: Mindy Preston <mindy.preston@docker.com>
Most cloud providers allow disk size allocation on in units
of GB. Make it the default for linuxkit disk "size" arguments.
Users can override the unit by appending a M to the disk size.
Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
This patch adds cross compilation steps for Linux, macOS and,
Windows to the CI targets to ensure that the all commands cross
compile nicely.
Although the CI runs on Linux we still explicitly compile for
Linux in case developers use the CI targets locally on a
non-Linux host.
While at it, also fix the GOARCH override to enable cross compilation
of ARM64 on Linux. The build support seems to work, but the
compilation fails (hence it is not added to the test).
Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
When mapping e-mail addresses and names;
<preferred@example.com> <foo@bar.com>
Maps `foo@bar.com` to `preferred@example.com`, whereas:
Preferred Name <preferred@example.com> <foo@bar.com>
Will update the e-mail address _and_ set the preferred name, _if_ the original
e-mail address in the commit was `<foo@bar.com>` (otherwise the rule is not
executed).
Finally, this rule:
Preferred Name <preferred@example.com>
Will set the name to `Preferred Name` if the e-mail address in the commit
matches `preferred@example.com`
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The 'docker.json' file is not used in the top level
example and was merely there as an example use of the
'file' section. Since we now have the containerd config
file in the 'file' section the 'docker.json' entry is
no longer needed.
Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
This at least checks for buildability of packages, even if we
are not yet pushing them.
See https://github.com/linuxkit/linuxkit/issues/1991 for what it mitigates.
Will not pass until this is fixed.
Signed-off-by: Justin Cormack <justin.cormack@docker.com>
With the updated HyperKit go bindings we can redirect the VM output
and check for test results. Use this for all kernel tests as this
speeds up running the tests on OSX.
Also use 'set -x' instead of 'set -v' for consistency and don't fail
when the clean up code fails.
The mkimage package test currently doesn't work on HyperKit as it
requires support for multiple disks to be added.
Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
With the updated HyperKit go bindings we can redirect the VM output
and check for test results. Use this for all kernel tests as this
speeds up running the tests on OSX.
Also enable 'set -x' so we see the commands being executed and don't
fail the test if the cleanup failed.
Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
