github/ping
1
0
Fork 0
mirror of https://github.com/go-ping/ping.git synced 2025-09-13 05:29:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove uses of Fatalf which causes the application to quit if a custom logger is provided such as Uber zap

Browse Source
This commit is contained in:
Stanimir Ivanov
2022-06-27 11:57:14 -04:00
parent b89bb75386
commit 51fc3918b1
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ping.go
View File

@@ -481,8 +481,8 @@ func (p *Pinger) runLoop(
case r := <-recvCh:
err := p.processPacket(r)
if err != nil {
// FIXME: this logs as FATAL but continues
logger.Fatalf("processing received packet: %s", err)
// TODO: should this break the loop and return an error?
logger.Errorf("error processing received packet: %s", err)
}
case <-interval.C:
@@ -492,8 +492,8 @@ func (p *Pinger) runLoop(
}
err := p.sendICMP(conn)
if err != nil {
// FIXME: this logs as FATAL but continues
logger.Fatalf("sending packet: %s", err)
// TODO: should this break the loop and return an error?
logger.Errorf("error sending packet: %s", err)
}
}
if p.Count > 0 && p.PacketsRecv >= p.Count {