Merge pull request #1370 from mtrmac/stateless-disable-completion

Set cobra.Command.CompletionOption already in createApp
This commit is contained in:
Valentin Rothberg
2021-07-10 10:48:18 +02:00
committed by GitHub

View File

@@ -45,6 +45,11 @@ func createApp() (*cobra.Command, *globalOptions) {
},
SilenceUsage: true,
SilenceErrors: true,
// Currently, skopeo uses manually written completions. Cobra allows
// for auto-generating completions for various shells. Podman is
// already making us of that. If Skopeo decides to follow, please
// remove the line below (and hide the `completion` command).
CompletionOptions: cobra.CompletionOptions{DisableDefaultCmd: true},
}
if gitCommit != "" {
rootCommand.Version = fmt.Sprintf("%s commit: %s", version.Version, gitCommit)
@@ -102,11 +107,6 @@ func main() {
return
}
rootCmd, _ := createApp()
// Currently, skopeo uses manually written completions. Cobra allows
// for auto-generating completions for various shells. Podman is
// already making us of that. If Skopeo decides to follow, please
// remove the line below (and hide the `completion` command).
rootCmd.CompletionOptions.DisableDefaultCmd = true
if err := rootCmd.Execute(); err != nil {
logrus.Fatal(err)
}