`prepare-files` action was interfering with spec file update which caused
https://github.com/containers/skopeo/issues/2760 .
`post-modifications` needs to be limited to the propose_downstream job or
else it will interfere with upstream PR copr builds.
Also, s/PACKIT_PROJECT_TAG/PACKIT_PROJECT_VERSION/ .
Co-authored-by: Nikola Forró <nforro@redhat.com>
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
(cherry picked from commit e26a4237fc)
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
- New support for creating "simple signing" signatures using Sequoia-PGP,
dependent on a build tag that enables it
- New option (skopeo copy --force-compression-format)
- New option --user-agent-prefix
- TLS options on the command line of (skopeo sync) take precedence
over options in YAML
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
These happen after commit to upstream and don't affect upstream.
These notifications only end up adding unnecessary noise.
Overall build failures can happen for a variety of reasons like copr
infra, outdated toolchain on some environments etc.
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
This will ensure both `test-system` and `test-system-local` work.
The `test-system` target will use the skopeo binary at `./bin/skopeo`.
Setting SKOPEO_BINARY should have no effect on it.
The `test-system-local` (and `test-integration-local`) target can use
SKOPEO_BINARY at any location. This will be useful in CI where we need to test
skopeo installed by the package at /usr/bin.
Co-authored-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
`hack/test-system.sh` earlier removed in commit 7e235ea contained
a storage.conf setup useful for running system tests in skopeo_cidev
container.
Getting rid of that also broke `make test-system` because the
systemtest: `copy: additional tag` started to break.
Running `make test-system-local` isn't ideal for local environments due
to creation of system-global containers with predictable names.
See: https://github.com/containers/skopeo/issues/2701#issuecomment-3415769846
So, this commit resurrects hack/test-system.sh. Followup commit will
modify Makefile targets to use this script again.
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
I want this for https://github.com/bootc-dev/bootc/issues/1686
so we can distinguish pulls there.
But more generally it's can be a good idea for people writing
scripts using skopeo to set custom user agents so that registries
can more easily trace which actors are performing tasks.
Assisted-by: Claude Code
Signed-off-by: Colin Walters <walters@verbum.org>
... and construct it from the primary inputs instead.
The name doesn't hurt in itself, but it ~forces us to use
multi-line test data, making this larger and harder to read than
necessary.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This changes the test, we drop the two inputs that can't happen
in practice; and, instead, test the default situation of no TLS
options provided anywhere.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
They use exactly the same body, and differ only in data
(and we are going to keep iterating on the body).
Should not change (test) behavior.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Else use ./bin/skopeo as the default binary.
This makes it a lot more flexible compared to just searching and using
the first skopeo in PATH. Also, allows to avoid any binary installation
to /usr/bin.
The SKOPEO_BINARY evaluation logic has been moved to a separate and
reusable Makefile target.
Co-authored-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
NewEphemeralSigningMechanism() may, with Sequoia, return
a mechanism which !SupportsSigning(); so, to determine that,
test with a non-ephemeral mechanism instead. (That's likely
actually faster, because we create a GNUPGHOME in these tests
anyway, so we avoid creating an deleting a separate temporary
directory.)
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
