Commit Graph

3213 Commits

Author SHA1 Message Date
Miloslav Trmač
8be40c376b Fix the "missing image" check when reading oci:
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-06-23 19:18:04 +02:00
Miloslav Trmač
56410674b7 Fix some comments
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-06-23 19:18:04 +02:00
Miloslav Trmač
54077f5238
Merge pull request #2631 from cevich/add_release_test
Add conditional release-checking system test
2025-06-23 18:04:14 +02:00
Chris Evich
3ddcdee045 Add conditional release-checking system test
Unfortunately on a number of occasions, Skopeo has been released
officially with a `-dev` suffix in the version number.  Assist in
catching this mistake at release time by the addition of a simple
conditional test.  Note that it must be positively enabled by a
magic env. var. before executing the system tests.

Also (as suggested by @lsm5) update the TMT test to trigger the new
condition for future Fedora releases.

Signed-off-by: Chris Evich <cevich@redhat.com>
2025-06-23 17:45:52 +02:00
Miloslav Trmač
25d4df6ee8
Merge pull request #2632 from lsm5/disable-osh-diff-scan
Packit: disable osh-diff-scan
2025-06-23 17:44:50 +02:00
Lokesh Mandvekar
abf7bbbab3
Packit: disable osh-diff-scan
Doesn't currently work for go packages anyway.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2025-06-20 16:39:59 -04:00
Miloslav Trmač
0f7515e099
Merge pull request #2628 from TomSweeneyRedHat/dev/tsweeney/governance
Tweak Governance and Maintainers for alignment
2025-06-20 18:00:26 +02:00
tomsweeneyredhat
889225db22 Tweak Governance and Maintainers for alignment
Tweak the Governance and Maintainers files to align them
with those in Buildah and Podman.

For reference, here's the Buildah PR that started this effort: https://github.com/containers/buildah/pull/6124

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
2025-06-17 18:11:14 -04:00
Miloslav Trmač
eb0e5cf578
Merge pull request #2624 from Luap99/sqlite-dynamic-link
dynamically link sqlite3
2025-06-11 15:12:06 +02:00
Paul Holzinger
f87cd5ec62
rpm: build rpm with libsqlite3 tag
So we dynamically link to sqlite in fedora instead of vendoring a static
copy.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-10 18:34:52 +02:00
Paul Holzinger
a50b2d910b
Makefile: use libsqlite3 build when possible
Dynamically link sqlite3 when installed, the main motivation is that we
reduce the podman binary size with that. I see about 3.3 MB savings.

But also dynamically linking it means if there a vulnerabilities only
the sqlite3 distro package needs updating and we don't have to make a
new podman release with the vendored update.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-10 18:34:45 +02:00
Miloslav Trmač
753f8be5c6
Merge pull request #2614 from mtrmac/authfile
Improve documentation of `--authfile`
2025-06-05 21:15:37 +02:00
Miloslav Trmač
763606cdde Improve documentation of --authfile
- Don't claim that Windows uses XDG_RUNTIME_DIR, defer to the authoritative
  man page.
- Consistently document the (regrettable?) REGISTRY_AUTH_FILE environment
  variable.
- Consistently refer to "registry credentials file", not "authentication file".
- (Also deemphasizes (docker login), I'm not sure we want that.)

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-06-04 21:37:06 +02:00
Miloslav Trmač
f825fdcb15
Merge pull request #2615 from mtrmac/reviewers
Add Colin Walters as a reviewer
2025-06-04 21:32:51 +02:00
Miloslav Trmač
ea37e10d4b Add Colin Walters as a reviewer
... to match past practice.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-06-04 20:23:02 +02:00
Miloslav Trmač
69af7bfe4c
Merge pull request #2609 from mtrmac/retry
Add --retry to test operations that tend to fail
2025-06-04 20:21:44 +02:00
Miloslav Trmač
3618a76e92 Add --retry[-times] to test operations that tend to fail
... to decrease impact of flakes.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-06-04 19:25:38 +02:00
Miloslav Trmač
8abee34d4b
Merge pull request #2621 from containers/renovate/github.com-containers-common-0.x
fix(deps): update module github.com/containers/common to v0.63.1
2025-06-04 19:24:13 +02:00
renovate[bot]
08dc3c94de
fix(deps): update module github.com/containers/common to v0.63.1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-06-04 12:21:06 +00:00
Miloslav Trmač
65cee5abeb
Merge pull request #2620 from lsm5/rpm-gating
[skip-ci] RPM: fix gating.yaml
2025-06-03 20:10:37 +02:00
Lokesh Mandvekar
c9d5569a84
[skip-ci] RPM: fix gating.yaml
Koji builds don't work without this fix.
Ref: https://dashboard.packit.dev/jobs/koji/11394

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2025-06-03 09:01:23 -04:00
Lokesh Mandvekar
cfae4fd800
Merge pull request #2618 from mtrmac/ostree
Don't BuildRequires: ostree-devel
2025-06-02 08:49:02 -04:00
Miloslav Trmač
3ad4bfcfee Don't BuildRequires: ostree-devel
We are not opting into the ostree backend, and it doesn't
build: https://github.com/containers/image/pull/2821 .
So, stop referencing the dependency.

Should not change behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-05-31 01:35:37 +02:00
Miloslav Trmač
5c119083fe
Merge pull request #2616 from giuseppe/add-cap-sys-admin-needed-caps
unshare: Add CAP_SYS_ADMIN to needed capabilities
2025-05-30 20:57:26 +02:00
Giuseppe Scrivano
50f414a7cf
unshare: Add CAP_SYS_ADMIN to needed capabilities
Some container storage operations (e.g., mounting the home directory
for containers/storage) require CAP_SYS_ADMIN.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2025-05-30 15:15:44 +02:00
Miloslav Trmač
dc88f3211b
Merge pull request #2605 from cgwalters/manpage-proxy
docs: Add a manpage for experimental-image-proxy
2025-05-26 19:08:29 +02:00
Colin Walters
a5cbf05259 docs: Add a manpage for experimental-image-proxy
I'm thinking about making it un-experimental. Having docs
is a step towards that.

Co-authored-by: Gemini Code Assist (which basically got this right)
Co-authored-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Colin Walters <walters@verbum.org>
2025-05-22 20:31:55 -04:00
Miloslav Trmač
c3e66b5876
Merge pull request #2604 from TomSweeneyRedHat/dev/tsweeney/bumpcommon_v0.60
Bump to c/common 0.63.0, c/image 5.35.0, Skopeo to v1.19.0, v1.20.0-dev
2025-05-22 18:41:40 +02:00
tomsweeneyredhat
aaba5370de Bump to v1.20.0-dev
Bump to the next dev version v1.20.0-dev

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
2025-05-22 09:55:59 -04:00
tomsweeneyredhat
7aa78df96b Bump to v1.19.0
Bump to v1.19.0 to align with the Podman v5.5 release

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
2025-05-22 09:55:50 -04:00
Miloslav Trmač
37b0289f3b
Merge pull request #2608 from containers/renovate/github.com-containers-common-0.x
fix(deps): update module github.com/containers/common to v0.63.0
2025-05-21 00:00:56 +02:00
renovate[bot]
64e5ebe20e
fix(deps): update module github.com/containers/common to v0.63.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-20 21:00:14 +00:00
Miloslav Trmač
8335d5aa6e
Merge pull request #2607 from containers/renovate/github.com-containers-image-v5-5.x
fix(deps): update module github.com/containers/image/v5 to v5.35.0
2025-05-20 22:57:20 +02:00
renovate[bot]
ec3516ec89 fix(deps): update module github.com/containers/image/v5 to v5.35.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-05-20 21:48:36 +02:00
Miloslav Trmač
d0d0b7099e Disable Packit builds on ELN
We need Go 1.23.3, which is not yet available there.

Compare https://github.com/containers/podman/pull/25706 .

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-05-20 21:48:36 +02:00
Miloslav Trmač
802f85645c
Merge pull request #2606 from lsm5/packit-post-f40
[skip-ci] Packit: set fedora-all after F40 EOL
2025-05-20 18:16:28 +02:00
Lokesh Mandvekar
9ddfd54926
[skip-ci] Packit: set fedora-all after F40 EOL
F40 is now EOL and all current Fedora releases have Go 1.23. So, we're
safe to re-enable fedora-all.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2025-05-19 12:22:03 -04:00
Miloslav Trmač
4e4bb0e9d7
Merge pull request #2598 from lsm5/openssf-passing
[CI:DOCS] README.md: Add openssf passing badge
2025-05-19 18:17:45 +02:00
Lokesh Mandvekar
ffad97c2ff
[CI:DOCS] README.md: Add openssf passing badge
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2025-05-19 11:54:20 -04:00
Miloslav Trmač
39445ea592
Merge pull request #2601 from cgwalters/get-raw-blob
proxy: Add GetRawBlob
2025-05-16 20:53:08 +02:00
Colin Walters
6ecc6c334f proxy: Move defer() higher up
Pre-existing problem noticed in review.

Signed-off-by: Colin Walters <walters@verbum.org>
2025-05-16 14:14:52 -04:00
Colin Walters
983e77d85f proxy: Add GetRawBlob
The original model the idea here is the proxy centralizes
verification of things like digest. However in practice,
this causes reading to be seriously awkward; ref
https://github.com/containers/containers-image-proxy-rs/issues/79
(Basically `FinishPipe` blocks the metadata channel)

Also, I have a project to implement a registry frontend to
`containers-storage:` and a core problem with `GetBlob` right
now is it *requires* the blob size up front even though the
underlying Go logic doesn't.

Moving to a "raw" interface solves that too. In this new
raw API, we return two file descriptors, one for the data
and one for the error channel, which contains a JSON
serialization of an error.

For the error type we reuse the existing "is error retryable"
and expose that back to the client.

We also (backwards compatibly) add this new error code
for the existing APIs.

Signed-off-by: Colin Walters <walters@verbum.org>
2025-05-16 14:14:52 -04:00
Miloslav Trmač
a477063650
Merge pull request #2596 from lsm5/badges
[CI:DOCS] README.md: Add badges
2025-05-09 14:21:47 +02:00
Lokesh Mandvekar
faa6f8a008 [CI:DOCS] README.md: Add badges
Add badges for License, Latest Release and Go Report Card.
Copied and modified from podman.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2025-05-08 15:42:39 +05:30
Miloslav Trmač
1942cd2ba7
Merge pull request #2597 from lsm5/communication
[CI:DOCS] CONTRIBUTING.md: Update communication channels
2025-05-07 16:56:21 +02:00
Lokesh Mandvekar
c228b1dba4
[CI:DOCS] CONTRIBUTING.md: Update communication channels
Fixes: #2592

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2025-05-07 19:04:04 +05:30
Miloslav Trmač
6c3096231c
Merge pull request #2593 from containers/renovate/golang.org-x-term-0.x
fix(deps): update module golang.org/x/term to v0.32.0
2025-05-06 15:26:09 +02:00
renovate[bot]
f8432950fa
fix(deps): update module golang.org/x/term to v0.32.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-06 00:11:08 +00:00
Miloslav Trmač
7ef7c49749
Merge pull request #2591 from containers/renovate/golangci-golangci-lint-2.x
chore(deps): update dependency golangci/golangci-lint to v2.1.6
2025-05-05 18:27:14 +02:00
renovate[bot]
2bd609a0dd
chore(deps): update dependency golangci/golangci-lint to v2.1.6
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-04 17:58:13 +00:00