Commit Graph

3245 Commits

Author SHA1 Message Date
Miloslav Trmač
94e949984f Centralize policy edits in copySuite.policyFixture
Should not change test behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-07-18 17:59:10 +02:00
Miloslav Trmač
5d2cb67fb1 Use t.Cleanup in fileFromFixture
... to simplify users.

Should not change test behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-07-18 17:59:10 +02:00
Miloslav Trmač
4dafc99bd6
Merge pull request #2657 from containers/renovate/github.com-spf13-pflag-1.x
Update module github.com/spf13/pflag to v1.0.7
2025-07-18 17:58:23 +02:00
renovate[bot]
d64b59917d
Update module github.com/spf13/pflag to v1.0.7
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-07-17 19:26:14 +00:00
Lokesh Mandvekar
5a1e5749c8
Merge pull request #2658 from containers/renovate/github.com-containers-common-0.x
Update module github.com/containers/common to v0.64.0
2025-07-17 15:24:19 -04:00
renovate[bot]
0aab0745e9
Update module github.com/containers/common to v0.64.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-07-17 19:03:14 +00:00
Miloslav Trmač
7b68a033bc
Merge pull request #2659 from mtrmac/image-spec
Update opencontainers/image-spec after https://github.com/opencontainers/image-spec/pull/1253
2025-07-17 21:00:42 +02:00
Miloslav Trmač
a3b8e175c5 Update opencontainers/image-spec after https://github.com/opencontainers/image-spec/pull/1253 .
This updates github.com/opencontainers/image-spec/schema subpackage from an obsolete
.../jsonschema/v5 to /v6 .

We use these dependencies only in tests, so it doesn't matter that much,
but removing references to years-old unmaintained versions makes it easier to check
/ remove other such cases.

(This is test-only, so the added files in vendor/ do not mean a larger binary
size; it's almost exactly unchanged.)

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-07-17 19:25:53 +02:00
Miloslav Trmač
729a053464
Merge pull request #2653 from containers/renovate/github.com-containers-image-v5-5.x
Update module github.com/containers/image/v5 to v5.36.0
2025-07-16 16:13:54 +02:00
renovate[bot]
f17b4c9672
Update module github.com/containers/image/v5 to v5.36.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-07-15 21:58:37 +00:00
Miloslav Trmač
cb17dedf54
Merge pull request #2651 from containers/renovate/golangci-golangci-lint-2.x
Update dependency golangci/golangci-lint to v2.2.2
2025-07-11 19:14:49 +02:00
renovate[bot]
f87d569628
Update dependency golangci/golangci-lint to v2.2.2
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-07-11 16:56:02 +00:00
Miloslav Trmač
b395b2b923
Merge pull request #2648 from mtrmac/shared-signing
Consolidate options shared between copy and sync to sharedCopyOptions
2025-07-10 21:41:37 +02:00
Miloslav Trmač
f9bdc2d8fc Consolidate options shared between copy and sync to sharedCopyOptions
Add some test coverage, but not full - the previous code
did not have any.

Should not change behavior, other than some help texts.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-07-10 21:11:30 +02:00
Miloslav Trmač
1f18641d34 Consistently use AddFlagSet before flag definitions
AddFlagSet silently ignores conflicting flags, whereas individual
flag definitions panic on (simple) conflicts; so, to detect ambiguities,
prefer to use AddFlagSet first.

Should not change behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-07-10 21:11:30 +02:00
Miloslav Trmač
8651716fa7
Merge pull request #2647 from mtrmac/sha256-test-keys
Update GPG keys not to use SHA-1
2025-07-10 21:09:25 +02:00
Miloslav Trmač
4ac60afc85 Update GPG keys not to use SHA-1
Sequoia-PGP does not accept SHA-1 by default; update
to avoid that.

Both the keys and the signatures come from c/image commit
70dbc81047f63a68130a5bdf1bfaee43db39746d .

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-07-10 20:24:17 +02:00
Miloslav Trmač
73f3b44cdb
Merge pull request #2649 from containers/renovate/golang.org-x-term-0.x
Update module golang.org/x/term to v0.33.0
2025-07-10 18:21:03 +02:00
renovate[bot]
862c2331b7
Update module golang.org/x/term to v0.33.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-07-09 23:42:17 +00:00
Miloslav Trmač
872ab48154
Merge pull request #2637 from containers/renovate/github.com-masterminds-semver-v3-3.x
Update module github.com/Masterminds/semver/v3 to v3.4.0
2025-06-30 18:35:27 +02:00
renovate[bot]
ef2375bc80
Update module github.com/Masterminds/semver/v3 to v3.4.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-06-30 15:53:16 +00:00
Miloslav Trmač
a4ab531365
Merge pull request #2638 from containers/renovate/golangci-golangci-lint-2.x
Update dependency golangci/golangci-lint to v2.2.1
2025-06-30 17:52:07 +02:00
renovate[bot]
3de83e9f73
Update dependency golangci/golangci-lint to v2.2.1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-06-30 15:23:26 +00:00
Miloslav Trmač
e5104ad291
Merge pull request #2636 from lsm5/disable-downstream-centos
Packit: disable official CentOS Stream update job
2025-06-30 17:22:35 +02:00
Lokesh Mandvekar
3c93577be1
Packit: disable official CentOS Stream update job
We're currently not updating official CentOS Stream packages via Packit.
So, this commit disables the downstream PR update job.

No noticeable effect upstream. Safe to merge.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2025-06-27 14:29:56 -04:00
Miloslav Trmač
b6c726f854
Merge pull request #2635 from actionmancan/update-neil-smith-github-username
Update Neil Smith's GitHub username in MAINTAINERS.md
2025-06-27 14:37:49 +02:00
G A Neil Smith
ac8b652729 Update Neil Smith's GitHub username in MAINTAINERS.md
- Changed GitHub username from 'Neil-Smith' to 'actionmancan'
- Fixed GitHub URL from https://github.com/Neil-Smith to https://github.com/actionmancan
- Corrected column alignment for consistent formatting
- Maintains Neil Smith's role as Community Manager

Does this PR introduce a user-facing change?

```release-note
None
```

Signed-off-by: G A Neil Smith <nesmith@redhat.com>
2025-06-26 13:32:25 -04:00
Miloslav Trmač
c49bbbe2ee
Merge pull request #2613 from mtrmac/archive-not-found
Fix recognizing “tag not found” in `oci:`, and add that for `oci-archive:`
2025-06-25 23:18:00 +02:00
Miloslav Trmač
99c6fb09e9 Also exit with status 2 for missing tags in oci-archive:
No tests because we aren't testing oci-archive: anywhere
else either.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-06-25 20:54:25 +02:00
Miloslav Trmač
634c0d99f3 Fix the "missing image" check when reading oci:
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-06-25 20:54:25 +02:00
Miloslav Trmač
40353ad7eb Fix some comments
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-06-25 20:54:25 +02:00
Miloslav Trmač
855cfb2f23
Merge pull request #2626 from lsm5/fix-bats-dep
RPM: make bats a weak dep
2025-06-23 19:54:14 +02:00
Lokesh Mandvekar
bdc6d70f0e
TMT: Install bats from source on RHEL
bats isn't shipped on ELN, RHEL and CentOS Stream. Enabling EPEL is also
problematic on internal testing farm environments.

This commit fetches and installs bats from source on RHEL and CentOS
Stream so we don't have to worry about EPEL enablement anymore.

We also aren't doing any ELN testing on TMT currently, so we don't need
any additional configuration for it and the current config should work
across the board.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2025-06-23 12:04:58 -04:00
Lokesh Mandvekar
654c3fcc9c
RPM: make bats a weak dep
bats isn't present on RHEL, CentOS Stream and ELN.

Ref: f88186e688 (r159874060)

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2025-06-23 12:04:58 -04:00
Miloslav Trmač
54077f5238
Merge pull request #2631 from cevich/add_release_test
Add conditional release-checking system test
2025-06-23 18:04:14 +02:00
Chris Evich
3ddcdee045 Add conditional release-checking system test
Unfortunately on a number of occasions, Skopeo has been released
officially with a `-dev` suffix in the version number.  Assist in
catching this mistake at release time by the addition of a simple
conditional test.  Note that it must be positively enabled by a
magic env. var. before executing the system tests.

Also (as suggested by @lsm5) update the TMT test to trigger the new
condition for future Fedora releases.

Signed-off-by: Chris Evich <cevich@redhat.com>
2025-06-23 17:45:52 +02:00
Miloslav Trmač
25d4df6ee8
Merge pull request #2632 from lsm5/disable-osh-diff-scan
Packit: disable osh-diff-scan
2025-06-23 17:44:50 +02:00
Lokesh Mandvekar
abf7bbbab3
Packit: disable osh-diff-scan
Doesn't currently work for go packages anyway.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2025-06-20 16:39:59 -04:00
Miloslav Trmač
0f7515e099
Merge pull request #2628 from TomSweeneyRedHat/dev/tsweeney/governance
Tweak Governance and Maintainers for alignment
2025-06-20 18:00:26 +02:00
tomsweeneyredhat
889225db22 Tweak Governance and Maintainers for alignment
Tweak the Governance and Maintainers files to align them
with those in Buildah and Podman.

For reference, here's the Buildah PR that started this effort: https://github.com/containers/buildah/pull/6124

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
2025-06-17 18:11:14 -04:00
Miloslav Trmač
eb0e5cf578
Merge pull request #2624 from Luap99/sqlite-dynamic-link
dynamically link sqlite3
2025-06-11 15:12:06 +02:00
Paul Holzinger
f87cd5ec62
rpm: build rpm with libsqlite3 tag
So we dynamically link to sqlite in fedora instead of vendoring a static
copy.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-10 18:34:52 +02:00
Paul Holzinger
a50b2d910b
Makefile: use libsqlite3 build when possible
Dynamically link sqlite3 when installed, the main motivation is that we
reduce the podman binary size with that. I see about 3.3 MB savings.

But also dynamically linking it means if there a vulnerabilities only
the sqlite3 distro package needs updating and we don't have to make a
new podman release with the vendored update.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-10 18:34:45 +02:00
Miloslav Trmač
753f8be5c6
Merge pull request #2614 from mtrmac/authfile
Improve documentation of `--authfile`
2025-06-05 21:15:37 +02:00
Miloslav Trmač
763606cdde Improve documentation of --authfile
- Don't claim that Windows uses XDG_RUNTIME_DIR, defer to the authoritative
  man page.
- Consistently document the (regrettable?) REGISTRY_AUTH_FILE environment
  variable.
- Consistently refer to "registry credentials file", not "authentication file".
- (Also deemphasizes (docker login), I'm not sure we want that.)

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-06-04 21:37:06 +02:00
Miloslav Trmač
f825fdcb15
Merge pull request #2615 from mtrmac/reviewers
Add Colin Walters as a reviewer
2025-06-04 21:32:51 +02:00
Miloslav Trmač
ea37e10d4b Add Colin Walters as a reviewer
... to match past practice.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-06-04 20:23:02 +02:00
Miloslav Trmač
69af7bfe4c
Merge pull request #2609 from mtrmac/retry
Add --retry to test operations that tend to fail
2025-06-04 20:21:44 +02:00
Miloslav Trmač
3618a76e92 Add --retry[-times] to test operations that tend to fail
... to decrease impact of flakes.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-06-04 19:25:38 +02:00
Miloslav Trmač
8abee34d4b
Merge pull request #2621 from containers/renovate/github.com-containers-common-0.x
fix(deps): update module github.com/containers/common to v0.63.1
2025-06-04 19:24:13 +02:00