The "registry-v2" binary currently being used is present in the
container image but it can't be found on local environments.
The docker-distribution provides the `registry` binary which does work
for the integration tests.
This commit switches to preferring the `registry-v2` binary and defaults
to `registry`. `make test-integration-local` passes with this change
and docker-distribution installed.
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
Add some test coverage, but not full - the previous code
did not have any.
Should not change behavior, other than some help texts.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
AddFlagSet silently ignores conflicting flags, whereas individual
flag definitions panic on (simple) conflicts; so, to detect ambiguities,
prefer to use AddFlagSet first.
Should not change behavior.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Sequoia-PGP does not accept SHA-1 by default; update
to avoid that.
Both the keys and the signatures come from c/image commit
70dbc81047f63a68130a5bdf1bfaee43db39746d .
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
We're currently not updating official CentOS Stream packages via Packit.
So, this commit disables the downstream PR update job.
No noticeable effect upstream. Safe to merge.
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
- Changed GitHub username from 'Neil-Smith' to 'actionmancan'
- Fixed GitHub URL from https://github.com/Neil-Smith to https://github.com/actionmancan
- Corrected column alignment for consistent formatting
- Maintains Neil Smith's role as Community Manager
Does this PR introduce a user-facing change?
```release-note
None
```
Signed-off-by: G A Neil Smith <nesmith@redhat.com>
bats isn't shipped on ELN, RHEL and CentOS Stream. Enabling EPEL is also
problematic on internal testing farm environments.
This commit fetches and installs bats from source on RHEL and CentOS
Stream so we don't have to worry about EPEL enablement anymore.
We also aren't doing any ELN testing on TMT currently, so we don't need
any additional configuration for it and the current config should work
across the board.
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
Unfortunately on a number of occasions, Skopeo has been released
officially with a `-dev` suffix in the version number. Assist in
catching this mistake at release time by the addition of a simple
conditional test. Note that it must be positively enabled by a
magic env. var. before executing the system tests.
Also (as suggested by @lsm5) update the TMT test to trigger the new
condition for future Fedora releases.
Signed-off-by: Chris Evich <cevich@redhat.com>
Tweak the Governance and Maintainers files to align them
with those in Buildah and Podman.
For reference, here's the Buildah PR that started this effort: https://github.com/containers/buildah/pull/6124
Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
Dynamically link sqlite3 when installed, the main motivation is that we
reduce the podman binary size with that. I see about 3.3 MB savings.
But also dynamically linking it means if there a vulnerabilities only
the sqlite3 distro package needs updating and we don't have to make a
new podman release with the vendored update.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
- Don't claim that Windows uses XDG_RUNTIME_DIR, defer to the authoritative
man page.
- Consistently document the (regrettable?) REGISTRY_AUTH_FILE environment
variable.
- Consistently refer to "registry credentials file", not "authentication file".
- (Also deemphasizes (docker login), I'm not sure we want that.)
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
