Commit Graph

3345 Commits

Author SHA1 Message Date
Miloslav Trmač
d2a1740f0d Merge pull request #2719 from mtrmac/generate-newline
Add missing newline to the output of (skopeo generate-sigstore-key)
2025-10-14 18:20:35 +02:00
Miloslav Trmač
144e9151bd Add missing newline to the output of (skopeo generate-sigstore-key)
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-10-13 20:47:47 +02:00
Miloslav Trmač
01f5061a82 Merge pull request #2722 from containers/renovate/golang.org-x-term-0.x
fix(deps): update module golang.org/x/term to v0.36.0
2025-10-09 11:17:30 +02:00
renovate[bot]
a45ceb03d3 fix(deps): update module golang.org/x/term to v0.36.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-10-08 17:44:41 +00:00
Miloslav Trmač
3d18794ee8 Merge pull request #2711 from mtrmac/sync-tls
Simplify tests for #2710
2025-10-02 19:39:15 +02:00
Miloslav Trmač
d287ec074a Fold the test cases of TestSyncTLSPrecedence to a single line each
... to make it much easier to compare+contrast.

Should not change (test) behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-10-02 17:42:49 +02:00
Miloslav Trmač
286c599025 Remove the explicit test name
... and construct it from the primary inputs instead.

The name doesn't hurt in itself, but it ~forces us to use
multi-line test data, making this larger and harder to read than
necessary.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-10-02 17:42:40 +02:00
Miloslav Trmač
5699f10b40 Construct the source context from CLI instead of manually
This changes the test, we drop the two inputs that can't happen
in practice; and, instead, test the default situation of no TLS
options provided anywhere.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-10-02 17:42:29 +02:00
Miloslav Trmač
6d2144e685 Use a real YAML fragment instead of constructing inputs manually
To be more clearly representative.

Should not change (test) behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-10-02 17:42:19 +02:00
Miloslav Trmač
1e6817a12c Merge the two TestTLSPrecedence tests
They use exactly the same body, and differ only in data
(and we are going to keep iterating on the body).

Should not change (test) behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-10-02 17:41:52 +02:00
Lokesh Mandvekar
fcf9dd6911 Merge pull request #2713 from containers/renovate/golangci-golangci-lint-2.x
Update dependency golangci/golangci-lint to v2.5.0
2025-10-02 10:03:53 -04:00
renovate[bot]
d80c776b87 Update dependency golangci/golangci-lint to v2.5.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-10-01 16:04:49 +00:00
Miloslav Trmač
d79dd05773 Merge pull request #2717 from containers/renovate/github.com-opencontainers-image-spec-digest
Update github.com/opencontainers/image-spec digest to 6519a62
2025-10-01 17:57:30 +02:00
renovate[bot]
c7a3a90716 Update github.com/opencontainers/image-spec digest to 6519a62
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-10-01 01:46:04 +00:00
Miloslav Trmač
b810e9eb46 Merge pull request #2710 from andya1lan/fix-sync-tls-verify-yaml
sync: honor CLI/global tls-verify unless YAML explicitly sets tls-verify
2025-09-19 18:46:58 +02:00
Andy Allan
dbd18b9728 sync: honor CLI/global tls-verify unless YAML explicitly sets tls-verify
Signed-off-by: Andy Allan <58987282+andya1lan@users.noreply.github.com>

chore: make linter happy

Signed-off-by: Andy Allan <58987282+andya1lan@users.noreply.github.com>

test(sync): refactor TLS override precedence test to table-driven

Signed-off-by: Andy Allan <58987282+andya1lan@users.noreply.github.com>

test(sync): refactor cases when YAML omitted

Signed-off-by: Andy Allan <58987282+andya1lan@users.noreply.github.com>

test(sync): readd TLS verification tests when yaml specfied

Signed-off-by: Andy Allan <58987282+andya1lan@users.noreply.github.com>

test(sync): readd TLS verification tests when yaml specfied and `incomingDaemonSkip` condition

Signed-off-by: Andy Allan <58987282+andya1lan@users.noreply.github.com>
2025-09-19 18:07:14 +08:00
Miloslav Trmač
f0f0c2c639 Merge pull request #2703 from lsm5/integration-test-binary-path
test-integration-local: use SKOPEO_BINARY if set
2025-09-17 15:06:55 +02:00
Lokesh Mandvekar
a489ea39a7 test-integration-local: use SKOPEO_BINARY if set
Else use ./bin/skopeo as the default binary.

This makes it a lot more flexible compared to just searching and using
the first skopeo in PATH. Also, allows to avoid any binary installation
to /usr/bin.

The SKOPEO_BINARY evaluation logic has been moved to a separate and
reusable Makefile target.

Co-authored-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2025-09-17 08:31:10 -04:00
Miloslav Trmač
96eabba0b4 Merge pull request #2645 from mtrmac/sequoia-cli
Add --sign-by-sq-fingerprint
2025-09-11 19:32:58 +02:00
Miloslav Trmač
f59e8938db Add --sign-by-sq-fingerprint and an integration test
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-09-11 19:00:40 +02:00
Miloslav Trmač
9753a1a11a Also build+test with Sequoia
Relies on https://github.com/containers/automation_images/pull/411 .

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-09-11 19:00:27 +02:00
Miloslav Trmač
cba2164671 Update CI images
... from https://github.com/containers/automation_images/pull/416

That requires updating tests to also work with rust-podman-sequoia 0.2.0:
d41fefaa1f changed
how the error is reported.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-09-11 19:00:20 +02:00
Miloslav Trmač
b258da23c2 Update conditions for signing tests
NewEphemeralSigningMechanism() may, with Sequoia, return
a mechanism which !SupportsSigning(); so, to determine that,
test with a non-ephemeral mechanism instead. (That's likely
actually faster, because we create a GNUPGHOME in these tests
anyway, so we avoid creating an deleting a separate temporary
directory.)

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-09-11 19:00:10 +02:00
Miloslav Trmač
99e3d917f9 Merge pull request #2705 from containers/renovate/golang.org-x-term-0.x
Update module golang.org/x/term to v0.35.0
2025-09-10 19:57:19 +02:00
renovate[bot]
86853ba4a5 Update module golang.org/x/term to v0.35.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-09-10 17:38:56 +00:00
Miloslav Trmač
933f797dec Merge pull request #2706 from mtrmac/go1.24
Update to Go1.24
2025-09-10 15:33:14 +02:00
Miloslav Trmač
0114569b17 Use strings.SplitSeq
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-09-08 23:05:37 +02:00
Miloslav Trmač
24c2a374d6 Use bytes.SplitSeq
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-09-08 23:05:30 +02:00
Miloslav Trmač
afc0c0f021 Rely on Go-maintained commit value instead of handling that ourselves
Should not change behavior

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-09-08 23:05:20 +02:00
Miloslav Trmač
509ed8e1a4 Update to Go 1.24
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-09-08 23:05:05 +02:00
Miloslav Trmač
ac66ca51ec Merge pull request #2700 from lsm5/rpm-sequoia
Packit/RPM: build with sequoia for f43+ and couple of other changes for distro conditionals and easier testing
2025-09-08 18:55:31 +02:00
Lokesh Mandvekar
53bba51c2f RPM: build with sequoia for F43+
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2025-09-08 18:38:09 +02:00
Lokesh Mandvekar
85e4414c43 RPM: Re-org distro conditionals
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2025-09-08 18:38:09 +02:00
Lokesh Mandvekar
af27d1d877 Packit/RPM: Epoch and version fetching fixes
1. Packit config includes a `get-current-version` action to fetch the
   version from `version/version.go` and not from the default `git
   describe`. So, the copr rpm version will always be ahead of what's in
   the official repos.

2. The absurdly high RPM Epoch is now limited to builds from
   rhcontainerbot/podman-next copr. So, copr builds on PR jobs will use
   the default Epoch value.

These two changes will make it easier for testers to fetch the scratch copr builds from
upstream PRs and it should allow for seamless upgrades.
(official rpm -> test copr rpm for bugfix -> upgrade to new official rpm)

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2025-09-08 18:38:09 +02:00
Miloslav Trmač
ee194d4c44 Merge pull request #2702 from bitoku/update-contributing.md
Update CONTRIBUTING.md
2025-09-08 18:16:10 +02:00
Ayato Tokubi
193b51364b Update CONTRIBUTING.md
Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
2025-09-05 12:01:58 +00:00
Lokesh Mandvekar
d8be59c1ec Merge pull request #2699 from containers/renovate/actions-stale-10.x
[skip-ci] Update actions/stale action to v10
2025-09-04 12:33:38 -04:00
renovate[bot]
cf5b488bef [skip-ci] Update actions/stale action to v10
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-09-04 14:39:51 +00:00
Miloslav Trmač
b0c3f56cf8 Merge pull request #2698 from lsm5/re-enable-centos-stream
Packit: re-enable ELN and CentOS Stream jobs on PRs
2025-09-04 16:39:19 +02:00
Lokesh Mandvekar
a3cb7bf314 Packit: re-enable CentOS Stream jobs on PRs
Does not affect propose_downstream jobs.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2025-09-04 08:42:12 -04:00
Lokesh Mandvekar
8675decea0 Packit/TMT: enable ELN testing on PRs
testing-farm public ranch now provides ELN composes which enables
super-early testing of the next RHEL.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2025-09-03 15:36:59 -04:00
Miloslav Trmač
749370dd99 Merge pull request #2697 from mtrmac/monorepo-tags
Update to tagged container-libs releases
2025-09-03 18:19:34 +02:00
Miloslav Trmač
e5cf4ec75e Update to tagged container-libs releases
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-09-03 17:56:58 +02:00
Miloslav Trmač
e54634f56a Merge pull request #2696 from containers/renovate/github.com-spf13-pflag-1.x
Update module github.com/spf13/pflag to v1.0.10
2025-09-03 16:48:18 +02:00
renovate[bot]
5489763ce3 Update module github.com/spf13/pflag to v1.0.10
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-09-02 20:41:11 +00:00
XYenon
4e452f974c Add --dest-force-compress-format option on copy
Signed-off-by: XYenon <i@xyenon.bid>
2025-09-02 18:45:10 +02:00
Lokesh Mandvekar
ef442e3696 Merge pull request #2687 from lsm5/ci-agnostic-2
Follow up on #2654
2025-09-02 09:12:03 -04:00
Lokesh Mandvekar
31ca77cea6 Packit: enable ELN
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2025-09-02 08:49:05 -04:00
Lokesh Mandvekar
9558c9c013 Packit: replace files_to_sync with prepare-files
With TMT being able to fetch and run tests using git url
and ref, there's no need to sync files on every propose_downstream
Packit action.

Removing files_to_sync should be safe as we only need to sync
`.packit.yaml` which is part of Packit's default behavior already.

Other files like gating.yaml only need to exist downstream and
shouldn't need any frequent manual changes, so
we can remove those from upstream and packit file-sync too.

New setup: We use a `prepare-files` action that will operate only on
`plans/main.fmf` in downstream dist-git and update the ref with the
tag from the latest release.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2025-09-02 08:49:05 -04:00
Lokesh Mandvekar
cd978903c8 RPM: skopeo-tests only installs dependencies
The sole purpose of skopeo-tests subpackage was to make system test
files readily available for CI on bodhi updates.

Given we can reuse test config from upstream via TMT, there's no
reason to continue shipping the test files. This subpackage can be
repurposed to only install test dependencies.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2025-09-02 08:49:05 -04:00