github/skopeo
1
0
Fork 0
mirror of https://github.com/containers/skopeo.git synced 2025-04-28 03:10:18 +00:00
Code Issues Projects Releases Wiki Activity
2,510 Commits 19 Branches 100 Tags 84 MiB
d4bd787e5f
Commit Graph

2510 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Miloslav Trmač
d4bd787e5f Use golangci-lint instead of golint 
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2023-04-06 21:45:51 +02:00
Miloslav Trmač
c538340e3b Finally, eliminate hack/make.sh 
The only thing hack/make.sh is now really doing is the
warning + sleep without SKOPEO_CONTAINER_TESTS .

So, make that a separate script, and eliminate the
hack/make directory.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2023-04-06 21:45:51 +02:00
Miloslav Trmač
f8f5a25fe2 Actually fail if (go vet) fails 
The errors are printed on stderr, so read that.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2023-04-06 21:45:51 +02:00
Miloslav Trmač
aebab49285 Speed up validate-git-marks by about a factor of three 
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2023-04-06 21:45:51 +02:00
Miloslav Trmač
4298692dd4 Don't use hack/make.sh for validate-git-marks 
hack/make.sh now does not make a difference, so simplify.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2023-04-06 21:45:51 +02:00
Miloslav Trmač
7e35ad54c3 Test all files by validate-git-marks 
This is simpler to do, cheap enough for our repo size, and it
does not require a network access to see which files to check.

And it's the last user of hack/make/.validate, which I wanted to
remove in the first place.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2023-04-06 21:45:51 +02:00
Miloslav Trmač
789257f767 Simplify the package list of (go vet) 
That extra process is an extra 0.5s on macOS at least.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2023-04-06 21:45:51 +02:00
Miloslav Trmač
bee51e5eed Don't use hack/make.sh for validate-gofmt 
hack/make.sh now does not make a difference, so simplify.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2023-04-06 21:45:51 +02:00
Miloslav Trmač
85fef03670 Run gofmt on all files, not just the changed ones 
... so that if we upgrade gofmt, the updates
need happen immediately.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2023-04-06 21:45:51 +02:00
Miloslav Trmač
82268ea8bf Don't use hack/make.sh for validate-lint 
hack/make.sh now does not make a difference, so simplify.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2023-04-06 21:45:51 +02:00
Miloslav Trmač
694b1565d1 Lint many more files in validate-lint 
- Always lint everything, not just changed files;
  that means that if we upgrade the linter, we will
  need to clean everything up, but that's a good thing
  for contributors who come after that linter upgrade.

- Don't skip linting the integration tests, there's no
  good reason to skip them.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2023-04-06 21:45:51 +02:00
Miloslav Trmač
43090b2917 Don't use hack/make.sh for validate-vet 
hack/make.sh now does not make a difference, so simplify.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2023-04-06 21:45:51 +02:00
Miloslav Trmač
225f239a69 Remove no-longer-necessary module options 
We now require Go 1.18. As of that version:
- GO111MODULE=on is implied by having a go.mod file
- -mod=vendor is implied by having a vendor directory

so just remove both options everywhere

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2023-04-06 21:45:51 +02:00
Miloslav Trmač
98b01af031 Fix Makefile dependencies 
validate-docs requires bin/skopeo; test-unit-local ctually doesn't.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2023-04-06 21:45:51 +02:00
Miloslav Trmač
835d71a3a4 Remove some outright unused code from hack/make* 
Should not affect observable behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2023-04-06 21:45:51 +02:00
Miloslav Trmač
cd1c43c65d
Merge pull request #1965 from mtrmac/verify-error 
Fix error handling of signature.NewEphemeralGPGSigningMechanism
 2023-04-06 21:44:58 +02:00
Miloslav Trmač
4be583c8a9 Fix error handling of signature.NewEphemeralGPGSigningMechanism 
signature.NewEphemeralGPGSigningMechanism is called in an if branch
where the previous err := introduces a "new" err variable, which means
the failure isn't visible after the if.

So, do the dumb thing and just check on both branches explicitly.
(We still need to worry about correctly setting "mech" and
"publicKeyfingerprints" to persist after the if.)

How I hate Go sometimes. And this shows we really should update
the linter.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2023-04-06 21:23:36 +02:00
Miloslav Trmač
0f3e6e30e4
Merge pull request #1966 from containers/renovate/major-ci-vm-image 
chore(deps): update dependency containers/automation_images to v20230405
 2023-04-06 21:22:33 +02:00
renovate[bot]
e841409787
chore(deps): update dependency containers/automation_images to v20230405 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2023-04-06 16:29:28 +00:00
Miloslav Trmač
9ffdceb157
Merge pull request #1968 from mtrmac/NewPid2 
Avoid use of a deprecated capability.NewPid
 2023-04-06 18:24:32 +02:00
Miloslav Trmač
4f5e821436 Avoid use of a deprecated capability.NewPid 
This is reported by golangci-lint.

(Absolutely untested.)

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2023-04-05 22:21:26 +02:00
Miloslav Trmač
1e70fee21d
Merge pull request #1962 from containers/renovate/github.com-spf13-cobra-1.x 
fix(deps): update module github.com/spf13/cobra to v1.7.0
 2023-04-05 20:07:27 +02:00
renovate[bot]
ca0f8418e1
fix(deps): update module github.com/spf13/cobra to v1.7.0 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2023-04-05 16:29:43 +00:00
Miloslav Trmač
3ddbfec17c
Merge pull request #1903 from containers/renovate/github.com-containers-image-v5-5.x 
fix(deps): update module github.com/containers/image/v5 to v5.25.0
 2023-04-05 18:28:43 +02:00
renovate[bot]
b0d339f0fd
fix(deps): update module github.com/containers/image/v5 to v5.25.0 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2023-04-05 16:14:44 +00:00
Miloslav Trmač
c4dac7632c
Merge pull request #1964 from containers/renovate/golang.org-x-term-0.x 
fix(deps): update module golang.org/x/term to v0.7.0
 2023-04-05 18:13:15 +02:00
renovate[bot]
03ca2871fe
fix(deps): update module golang.org/x/term to v0.7.0 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2023-04-05 15:45:36 +00:00
Miloslav Trmač
841eab319f
Merge pull request #1950 from Jamstah/easy-verify-options 
Verify signatures from a list of public keys
 2023-04-05 17:40:52 +02:00
James Hewitt
4ca2058d01
Use multiple fingerprint function 
Allow comma separated fingerprint list

To be squashed later

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
 2023-04-01 12:07:35 +01:00
James Hewitt
c54f2025d8
Review comments (to be squashed later 
Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
 2023-04-01 11:51:58 +01:00
James Hewitt
9b1f1fa1a9
Rename argument. Only use any with public key file. Double check fingerprint is in public key file. 
Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
 2023-04-01 11:51:57 +01:00
James Hewitt
3097b7a4e9
Verify signatures from a trust store 
Add the ability to use an on-disk trust store to verify signatures. Also allow the user to trust any known fingerprint instead of having to specify one.

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
 2023-04-01 11:51:57 +01:00
Miloslav Trmač
d08bf21367
Merge pull request #1959 from mtrmac/update-image 
Update c/image from the main branch
 2023-04-01 12:41:59 +02:00
Miloslav Trmač
bfe82593c8 Update c/image from the main branch 
> go get github.com/containers/image/v5@main
> make vendor

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2023-04-01 12:24:04 +02:00
Miloslav Trmač
4f475bd4d2
Merge pull request #1957 from containers/renovate/github.com-containers-common-0.x 
Update module github.com/containers/common to v0.51.2
 2023-04-01 12:14:03 +02:00
renovate[bot]
468ac6559e
Update module github.com/containers/common to v0.51.2 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2023-04-01 09:30:13 +00:00
Miloslav Trmač
2409c25922
Merge pull request #1955 from containers/renovate/major-ci-vm-image 
Update dependency containers/automation_images to v20230330
 2023-04-01 11:27:58 +02:00
renovate[bot]
7481aae6ac
Update dependency containers/automation_images to v20230330 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2023-03-30 19:02:55 +00:00
Miloslav Trmač
3952227939
Merge pull request #1953 from sstosh/tests-xdg 
systemtests: Fix 040-local-registry-auth about XDG_RUNTIME_DIR
 2023-03-28 22:36:09 +02:00
Toshiki Sonoda
454f8559c1 systemtests: Fix 040-local-registry-auth about XDG_RUNTIME_DIR 
Need to restore XDG_RUNTIME_DIR when podman removes the registry.

Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
 2023-03-28 15:01:41 +09:00
Miloslav Trmač
0c43e43e36
Merge pull request #1942 from lsm5/packit-build-on-main-commit 
[CI:BUILD] Packit: trigger builds on commit to main branch
 2023-03-24 21:03:43 +01:00
Lokesh Mandvekar
bbdcb79c03
[CI:BUILD] Packit: trigger builds on commit to main branch 
This commit lets packit trigger builds on
`rhcontainerbot/podman-next` copr after a commit to the main branch
instead of the current github webhook trigger.

The builds triggered via packit also provide more information in their
`version-release`:

Current webhook triggered build:
`101:0.0.git.2460.cfd6f20f-1`.
Ref: https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/package/skopeo/

Packit triggered build for another package (netavark) on podman-next:
101:1.6.0~dev-1.20230321121647013339.main.61.gd6f0352
Ref: https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/package/netavark/

The packit triggered build correctly shows the upstream branch name,
commit id, timestamp as well as the upstream version.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
 2023-03-24 11:21:54 +05:30
Miloslav Trmač
dd80c87c2c
Merge pull request #1947 from containers/renovate/actions-stale-8.x 
[skip-ci] Update actions/stale action to v8
 2023-03-23 21:33:37 +01:00
renovate[bot]
cd4f2ee554
[skip-ci] Update actions/stale action to v8 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2023-03-23 09:38:29 +00:00
Valentin Rothberg
f588f8bde7
Merge pull request #1943 from mtrmac/promote-install 
Make the installation instructions more prominent in README.md
 2023-03-23 09:33:11 +01:00
Miloslav Trmač
b2ede999f3 Make the installation instructions more prominent in README.md 
... per https://github.com/containers/skopeo/issues/1940 .

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2023-03-22 22:29:47 +01:00
Miloslav Trmač
b43ec279d2
Merge pull request #1945 from containers/renovate/major-ci-vm-image 
Update dependency containers/automation_images to v20230320
 2023-03-22 22:28:17 +01:00
renovate[bot]
8ea5fd4458
Update dependency containers/automation_images to v20230320 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2023-03-22 20:14:04 +00:00
Miloslav Trmač
81c63c331f
Merge pull request #1946 from containers/renovate/github.com-containers-common-0.x 
Update module github.com/containers/common to v0.51.1
 2023-03-22 21:12:46 +01:00
renovate[bot]
aa9862a718
Update module github.com/containers/common to v0.51.1 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2023-03-22 15:11:42 +00:00