github/skopeo
1
0
Fork 0
mirror of https://github.com/containers/skopeo.git synced 2025-06-26 06:42:21 +00:00
Code Issues Projects Releases Wiki Activity
2,150 Commits 17 Branches 101 Tags 85 MiB
db663df804
Commit Graph

2150 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Miloslav Trmač
db663df804
Merge pull request #1659 from Luap99/make-completions 
fix make completions for all POSIX shells
 2022-05-30 15:00:14 +02:00
Paul Holzinger
263a5f017f
fix make completions for all POSIX shells 
The {a,b} syntax is not POSIX compatible. The Makefile should run with
all POSIX shells so we cannot use shell specific features like this.

Fixes #1657

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
 2022-05-30 14:38:56 +02:00
Valentin Rothberg
47afd101f0
Merge pull request #1656 from mtrmac/yaml-3.0.0 
Update to gopkg.in/yaml.v3 v3.0.0
 2022-05-30 11:38:26 +02:00
Miloslav Trmač
0a3be734a9 Update to gopkg.in/yaml.v3 v3.0.0 
... to include a fix for CVE-2022-28948 = GHSA-hp87-p4gw-j4gq .

Note that the package is only used for Skopeo's tests, so
Skopeo's users can't reach the vulnerable code.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2022-05-26 20:30:59 +02:00
Chris Evich
e8a3064328
Merge pull request #1652 from cevich/fix_gha_security 
[CI:DOCS] Pin actions to a full length commit SHA
 2022-05-26 14:28:01 -04:00
Chris Evich
014d47f396
[CI:DOCS] Pin actions to a full length commit SHA 
+ Pin actions to a full length commit SHA is currently the only way
  to use an action as an immutable release. Pinning to a particular SHA
  helps mitigate the risk of a bad actor adding a backdoor to the action's
  repository, as they would need to generate a SHA-1 collision for a valid
  Git object payload. Ref:
  https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions

+ Explicitly set permissions for actions to minimum required.  The
  defaults are (unfortunately) overly permissive: Ref:
  https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token

Signed-off-by: Chris Evich <cevich@redhat.com>
 2022-05-25 11:29:18 -04:00
Daniel J Walsh
0fa1b5038f
Merge pull request #1649 from mtrmac/gpgme-native-pkg-config 
Stop calling gpgme-config
 2022-05-23 23:32:14 -04:00
Miloslav Trmač
1add7a81d7
Merge pull request #1647 from Luap99/completion 
use spf13/cobra to generate shell completions
 2022-05-23 19:22:10 +02:00
Paul Holzinger
d78bc82782
shell completion: add completion for transports names 
Make sure skopeo copy/inspect/delete show the transport names when shell
completion is used to not regress compared to the old bash completion
script.

In theory I would highly recommend to set completion functions for
every flag and command. This can be ensured with a test like this:
https://github.com/containers/podman/blob/main/cmd/podman/shell_completion_test.go
But this is a lot of work to get right and I am neither a skopeo user or
maintainer so I am missing a lot of context for most options. I think
this would be better handled by a person who knows skopeo better.

Normally options should either use AutocompleteNone() or
AutocompleteDefault() from c/common/pkg/completion.
Even better would be to add custom completion functions for arguments
that only accept fixed values, see AutocompleteSupportedTransports() in
this commit.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
 2022-05-23 18:47:51 +02:00
Paul Holzinger
6c2a415f6c
shell completion: add install instructions docs 
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
 2022-05-23 18:47:51 +02:00
Paul Holzinger
9bed0a9e9a
shell completion: add Makefile target 
Add target to generate the shell scripts and a target to install them.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
 2022-05-23 18:47:46 +02:00
Miloslav Trmač
ebc5573e83 Stop calling gpgme-config 
As of the just-updated github.com/proglottis/gpgme 0.1.2,
the gpgme subpackage uses CGo's native #cgo pkg-config support
to find the relevant libraries, and we no longer need to manually set
CGO_CFLAGS and CGO_LDFLAGS. So stop doing that.

Note that the proglottis/gpgme update (implied by vendoring c/image)
means the minimal supported version of GPGME is 1.13.0.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2022-05-19 22:03:26 +02:00
Miloslav Trmač
1ebb2520ca Update c/image 
... to bring in github.com/proglottis/gpgme 0.1.2.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2022-05-19 21:59:36 +02:00
Miloslav Trmač
9b4c1f15f5 Remove cgo_pthread_ordering_workaround.go 
Per https://bugzilla.redhat.com/show_bug.cgi?id=1326903 and
https://sourceware.org/bugzilla/show_bug.cgi?id=19861#c9 , this
was fixed in Glibc 2.24 .

Removing this will also allow us not to worry about LDFLAGS
necessary to make -lgpgme work.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2022-05-19 21:54:07 +02:00
Paul Holzinger
6863fe2d35
add completion command to generate shell completion scripts 
Use the cobra lib to automatically generate shell completion scripts.
We can use the completion command which is automatically added, since it
is not importent for most users we hide it.

To test the new script on bash you can use `source <(bin/skopeo completion bash)`

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
 2022-05-19 16:56:21 +02:00
Miloslav Trmač
4b924061b8
Merge pull request #1644 from containers/dependabot/go_modules/github.com/docker/docker-20.10.16incompatible 
Bump github.com/docker/docker from 20.10.15+incompatible to 20.10.16+incompatible
 2022-05-13 18:09:45 +02:00
dependabot[bot]
3eca480c2b
Bump github.com/docker/docker 
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.15+incompatible to 20.10.16+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Changelog](https://github.com/moby/moby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/docker/docker/compare/v20.10.15...v20.10.16)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-05-13 08:17:07 +00:00
Miloslav Trmač
149bb8a671
Merge pull request #1643 from containers/dependabot/go_modules/github.com/containers/storage-1.41.0 
Bump github.com/containers/storage from 1.40.2 to 1.41.0
 2022-05-12 18:10:19 +02:00
dependabot[bot]
149dea8dce
Bump github.com/containers/storage from 1.40.2 to 1.41.0 
Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.40.2 to 1.41.0.
- [Release notes](https://github.com/containers/storage/releases)
- [Changelog](https://github.com/containers/storage/blob/main/docs/containers-storage-changes.md)
- [Commits](https://github.com/containers/storage/compare/v1.40.2...v1.41.0)

---
updated-dependencies:
- dependency-name: github.com/containers/storage
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-05-12 08:10:20 +00:00
Daniel J Walsh
a90efa2d60
Merge pull request #1642 from dfr/freebsd-config 
Config files live in /usr/local/etc on FreeBSD (highlight in release notes!)
 2022-05-10 16:13:39 -04:00
Doug Rabson
804f7c249d Avoid hard-coding the location of bash 
On FreeBSD, bash lives in /usr/local/bin/bash. These scripts don't
really depend on bash so could be changed to /bin/sh.

Signed-off-by: Doug Rabson <dfr@rabson.org>
 2022-05-10 11:24:45 +01:00
Doug Rabson
e47765ed9e Config files live in /usr/local/etc on FreeBSD 
Signed-off-by: Doug Rabson <dfr@rabson.org>
 2022-05-10 10:37:29 +01:00
Miloslav Trmač
0c6074db50
Merge pull request #1640 from containers/dependabot/go_modules/github.com/docker/docker-20.10.15incompatible 
Bump github.com/docker/docker from 20.10.14+incompatible to 20.10.15+incompatible
 2022-05-09 20:03:20 +02:00
dependabot[bot]
13ceb93bdf
Bump github.com/docker/docker 
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.14+incompatible to 20.10.15+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Changelog](https://github.com/moby/moby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/docker/docker/compare/v20.10.14...v20.10.15)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-05-07 12:22:43 +00:00
Daniel J Walsh
30446fae02
Merge pull request #1641 from rhatdan/main 
Bump to v1.8.0
 2022-05-07 08:21:40 -04:00
Daniel J Walsh
cd4607f96b
Move to v1.8.1-dev 
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
 2022-05-06 10:09:43 -04:00
Daniel J Walsh
37727a45f9
Bump to v1.8.0 
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
 2022-05-06 10:09:11 -04:00
Daniel J Walsh
75d94e790c
Bump ocicrypt to v1.1.4 
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
 2022-05-06 10:07:37 -04:00
Miloslav Trmač
1fe8da63a9
Merge pull request #1636 from rhatdan/main 
Vendor in containers/storage v1.40.2
 2022-05-03 20:38:28 +02:00
Daniel J Walsh
737ed9c2a4
Vendor in containers/storage v1.40.2 
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
 2022-05-03 13:06:55 -04:00
Miloslav Trmač
39a4475cf3
Merge pull request #1635 from rhatdan/main 
Vendor in containers/(common, storage, image)
 2022-05-03 16:48:44 +02:00
Daniel J Walsh
3c286dd1d1
Vendor in containers/(common, storage, image) 
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
 2022-05-03 09:59:43 -04:00
Lokesh Mandvekar
b8b0e9937b [CI:DOCS] install.md: include distro package info links 
Co-authored-by: Tom Sweeney <tsweeney@redhat.com>
Co-authored-by: Miloslav Trmač <mitr@redhat.com>

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
 2022-05-02 10:33:57 -04:00
Miloslav Trmač
437d33ec9a
Merge pull request #1632 from lsm5/remove-kubic 
[CI:DOCS] install.md: remove Kubic package info for Ubuntu
 2022-04-29 17:44:00 +02:00
Lokesh Mandvekar
d9035db615
[CI:DOCS] install.md: remove Kubic package info for Ubuntu 
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
 2022-04-29 11:38:02 -04:00
Chris Evich
198842bbec
Merge pull request #1631 from cevich/f36_update 
Cirrus: Update to F36 w/ netavark+aardvark-dns
 2022-04-29 11:15:18 -04:00
Chris Evich
916a395d82
Cirrus: Update to F36 w/ netavark+aardvark-dns 
Also includes some updates relating to improvements in the common
automation library.

Signed-off-by: Chris Evich <cevich@redhat.com>
 2022-04-28 13:39:25 -04:00
Daniel J Walsh
89acf46019
Merge pull request #1626 from rhatdan/VENDOR 
Update vendor of containers/(common,storage,image)
 2022-04-22 08:32:24 -04:00
Daniel J Walsh
8960ab3ce7
Update vendor of containers/(common,storage,image) 
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
 2022-04-22 06:45:18 -04:00
Daniel J Walsh
145304b7cf
Merge pull request #1597 from mtrmac/delete-warning 
Improve the (skopeo delete) man page
 2022-04-14 07:15:47 -04:00
Valentin Rothberg
e534472e7d
Merge pull request #1621 from mtrmac/go1.16 
Update to benefit from Go 1.16
 2022-04-14 09:14:09 +02:00
Miloslav Trmač
d9d3ceca45 Use filepath.WalkDir instead of filepath.Walk 
... to optimize away some lstat(2) calls.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2022-04-13 20:14:04 +02:00
Miloslav Trmač
23a4605742 Extract four copies of the same loop into a function 
Should not change behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2022-04-13 20:14:04 +02:00
Miloslav Trmač
4811c07d71 Update users of deprecated io/ioutil 
Mostly just name changes that should not change behavior, apart
from ioutil.ReadDir -> os.ReadDir avoiding per-item lstat(2) in
one case.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
 2022-04-13 20:13:52 +02:00
Miloslav Trmač
15b38112b1
Merge pull request #1610 from Jamstah/sign-identity 
Add option to specify the identity for signing
 2022-04-04 13:14:49 +02:00
James Hewitt
4ef35a385a
Add option to specify the identity for signing 
This enables pushing to registries where the push and pull uris may be
different, for example where pushed images are mirrored to a read only
replica for distribution.

Closes #1588

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
 2022-03-30 22:02:43 +01:00
James Hewitt
38ae81fa03
Bump containers/image to include sign identity option 
Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
 2022-03-30 22:02:40 +01:00
Miloslav Trmač
e4297e3b30
Merge pull request #1611 from masatake/fix-man-page 
delete non-existent option in the cmdline example
 2022-03-30 19:47:58 +02:00
Masatake YAMATO
9b09b6eb87 delete non-existent option in the cmdline example 
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
 2022-03-31 02:27:42 +09:00
Valentin Rothberg
45ed92ce0c
Merge pull request #1608 from rhatdan/dry-run 
Add dry-run mode to skopeo-sync
 2022-03-29 08:30:43 +02:00