We should document requied packages for installing on Ubuntu and Debian
to match up with the use on Fedora.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
When we fail to pull an image, don't try to include the name of the
image that pullImage() returned in the error text - it will have
returned nil for the pulled reference in most cases. Instead, use the
name of the image as we were told it.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #255
Approved by: nalind
Try to use pkg-config to check for 'ostree-1' and 'libselinux'.
If ostree-1 is not found, use the containers_image_ostree_stub build tag
to not require it, at the cost of not being able to use or write images
to the 'ostree' transport.
If libselinux is found, build with the 'selinux' tag,
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #252
Approved by: rhatdan
This is no simpler then putting the transport in the image page,
we should default to the registry specified in containers/image
and not override it. People are confused by this option, and I
see no value.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Closes: #234
Approved by: rhatdan
Don't worry about not being able to populate temporary volumes using the
contents of the location in the image where they're expected to be
mounted if we fail to do so because that location doesn't exist.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #248
Approved by: rhatdan
We have implemented most of this code in kpod export, and we now
have kpod import/load/save. No reason to implement them in both
commands.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Closes: #245
Approved by: nalind
Whenever we create a containers/image/signature.PolicyContext, make sure
we don't forget to destroy it.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #231
Approved by: rhatdan
When ensuring that the working directory exists before running a
command, make sure we create the location that we set in the
configuration file that we pass to runc.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #241
Approved by: rhatdan
Replace --registry command line flags with --transport. For backward
compatibility, add Transport as an addtional setting that we prepend to
the still-optional Registry setting if the Transport and image name
alone don't provide a parseable image reference.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #235
Approved by: rhatdan
Fix our instantiation behavior when the source image reference is not a
named reference.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #235
Approved by: rhatdan
containers/image now fully supports pushing images and signatures to an
openshift/atomic registry using the docker:// transport.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Closes: #238
Approved by: rhatdan
Avoid parsing metadata that the image library keeps in order to find an
image's digest and creation date; instead, compute the digest from the
manifest, and read the creation date value by inspecting the image,
logging a debug-level diagnostic if it doesn't match the value that the
storage library has on record.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #218
Approved by: rhatdan
Use the storage library's new public field for retrieving an image's
creation date.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #218
Approved by: rhatdan
Use the official Fedora 26 image from the Fedora registry rather than
from the Docker Hub.
Also mount yum repos from the host. This will speed up provisioning
because PAPR injects mirror repos that are much closer and faster.
Signed-off-by: Jonathan Lebon <jlebon@redhat.com>
Closes: #225
Approved by: rhatdan
Rename the YAML file and its auxiliary files to the newly supported
name.
Signed-off-by: Jonathan Lebon <jlebon@redhat.com>
Closes: #225
Approved by: rhatdan
Return a "doesn't match" result if an image's ID can't be turned into a
valid reference for any reason.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #217
Approved by: rhatdan
It looks like the metalinter is running out of memory while running
tests under PAPR, so give this a try.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #221
Approved by: rhatdan
Add a CI test that ensures that we can build an RPM package on the
current version (as of this writing, 26) of Fedora, using the .spec file
under contrib.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #208
Approved by: jlebon
Have storageImageID() use a lower-level image lookup to let it handle
truncated IDs correctly. Wrap errors in getImage(). When reporting
that an image is in use, report its ID correctly.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #211
Approved by: rhatdan
In-memory image objects created using an ImageReference's NewImage()
method need to be Close()d.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #211
Approved by: rhatdan
The libseccomp2 in Travis (or rather, in the default repositories that
we have) is too old to support conditional filtering, so we need to
supply our own in order to not get "conditional filtering requires
libseccomp version >= 2.2.1" errors from runc.
That version also appears to be happy to translate the syscall name
_llseek from a name to a number that it doesn't recognize, triggering
"unrecognized syscall" errors.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #202
Approved by: rhatdan
Try to ensure that we have runc, so that we can test the "run" command
in CI. In the absence of a compatible packaged version of runc, we may
have to build our own.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #202
Approved by: rhatdan
Add a test to compare the version we claim to be with the version
recorded in the RPM .spec file.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #202
Approved by: rhatdan
OCI 1.0 Image specification is now released so we want to bump
buildah version to support 1.0 images.
Bump to version 0.3
Signed-off-by: Dan Walsh <dwalsh@redhat.com>
Closes: #203
Approved by: rhatdan
run: The latest version of runtime-spec dropped the Platform field, so
stop trying to set it when generating a configuration for a runtime.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #201
Approved by: rhatdan
Update to just-released versions of image-spec and runtime-spec, and the
latest version of runtime-tools.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #201
Approved by: rhatdan
If you specify an option in a buildah run command, the command fails.
The proper syntax for this is to add --
buildah run $ctr -- ls -l /
Signed-off-by: Dan Walsh <dwalsh@redhat.com>
Closes: #197
Approved by: nalind
The current buildah images command prints the heading twice, this
bug was introduced when --json flag was added.
Signed-off-by: Dan Walsh <dwalsh@redhat.com>
Closes: #195
Approved by: rhatdan
I think this would be good practice to eliminate wasted disk space.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Signed-off-by: Dan Walsh <dwalsh@redhat.com>
Closes: #189
Approved by: rhatdan
