Revert "Enables UART tx_watermark interrupts"

This reverts commit 010f0d7045d40ea6b0900fc74d79fe92df0fae69.

Reason for revert: kata console fails to come up.

Change-Id: Icab24e9043f967ea76907ce938eef72b2fbf47ac
GitOrigin-RevId: 342e260470ba0c194c7f7a0d1006b2f3a2432236
This commit is contained in:
Henry Herman
2021-08-23 19:14:55 +00:00
committed by Sam Leffler
parent b35f77a2fe
commit cbfec8e9b7

View File

@@ -163,7 +163,12 @@ void pre_init() {
// Enables interrupts.
REG(INTR_ENABLE) = (
BIT(UART_INTR_COMMON_TX_WATERMARK) |
// TODO(mattharvey): Enable tx_watermark. Currently the handler fires
// repeatedly in a loop when doing this, even while the TX FIFO remains
// empty, contrary to the "edge triggered events" working in the OpenTitan
// docs. Check that Renode is doing the right thing and if so debug after
// re-enabling this.
// BIT(UART_INTR_COMMON_TX_WATERMARK) |
BIT(UART_INTR_COMMON_RX_WATERMARK) | BIT(UART_INTR_COMMON_TX_EMPTY));
}
@@ -234,6 +239,9 @@ void tx_update(uint32_t num_valid_dataport_bytes) {
// These happen when the transmit FIFO is half-empty. This refills the FIFO to
// prevent stalling, stopping early if tx_buf becomes empty, and then signals
// any tx_update that might be waiting for tx_buf to not be full.
//
// Currently this is not actually enabled. See the TODO in the implementation of
// pre_init.
void tx_watermark_handle(void) {
fill_tx_fifo();