1
0
mirror of https://github.com/haiwen/seahub.git synced 2025-07-30 22:34:53 +00:00

optimized function naming (#2824)

This commit is contained in:
杨顺强 2019-01-14 13:33:36 +08:00 committed by Daniel Pan
parent 2cdba5012a
commit 3d2e21eecd
10 changed files with 18 additions and 18 deletions

View File

@ -182,7 +182,7 @@ class Member extends React.PureComponent {
isEditIconShow={true}
currentRole={this.props.item.role}
roles={this.roles}
onRoleChangedHandler={this.onChangeUserRole}
onRoleChanged={this.onChangeUserRole}
/>
}
</td>

View File

@ -45,7 +45,7 @@ class GroupItem extends React.Component {
isEditIconShow={this.state.isOperationShow}
currentPermission={item.permission}
permissions={this.props.permissions}
onPermissionChangedHandler={this.onChangeUserPermission}
onPermissionChanged={this.onChangeUserPermission}
/>
</td>
<td>
@ -275,7 +275,7 @@ class ShareToGroup extends React.Component {
isEditIconShow={false}
currentPermission={this.state.permission}
permissions={this.permissions}
onPermissionChangedHandler={this.setPermission}
onPermissionChanged={this.setPermission}
/>
</td>
<td>

View File

@ -45,7 +45,7 @@ class UserItem extends React.Component {
isEditIconShow={this.state.isOperationShow}
currentPermission={currentPermission}
permissions={this.props.permissions}
onPermissionChangedHandler={this.onChangeUserPermission}
onPermissionChanged={this.onChangeUserPermission}
/>
</td>
<td>
@ -297,7 +297,7 @@ class ShareToUser extends React.Component {
isEditIconShow={false}
currentPermission={this.state.permission}
permissions={this.permissions}
onPermissionChangedHandler={this.setPermission}
onPermissionChanged={this.setPermission}
/>
</td>
<td>

View File

@ -8,7 +8,7 @@ const propTypes = {
isEditIconShow: PropTypes.bool.isRequired,
roles: PropTypes.array.isRequired,
currentRole: PropTypes.string.isRequired,
onRoleChangedHandler: PropTypes.func.isRequired,
onRoleChanged: PropTypes.func.isRequired,
};
class RoleEditor extends React.Component {
@ -30,7 +30,7 @@ class RoleEditor extends React.Component {
isEditIconShow={this.props.isEditIconShow}
options={this.props.roles}
currentOption={this.props.currentRole}
onOptionChangedHandler={this.props.onRoleChangedHandler}
onOptionChanged={this.props.onRoleChanged}
translateOption={this.translateRole}
/>
);

View File

@ -9,7 +9,7 @@ const propTypes = {
options: PropTypes.array.isRequired,
currentOption: PropTypes.string.isRequired,
translateOption: PropTypes.func.isRequired,
onOptionChangedHandler: PropTypes.func.isRequired,
onOptionChanged: PropTypes.func.isRequired,
};
class SelectEditor extends React.Component {
@ -34,11 +34,11 @@ class SelectEditor extends React.Component {
this.setState({isEditing: true});
}
onOptionChangedHandler = (e) => {
onOptionChanged = (e) => {
e.nativeEvent.stopImmediatePropagation();
let permission = e.target.value;
if (permission !== this.props.currentOption) {
this.props.onOptionChangedHandler(permission);
this.props.onOptionChanged(permission);
}
this.setState({isEditing: false});
}
@ -66,7 +66,7 @@ class SelectEditor extends React.Component {
return (
<div className="permission-editor">
{(!isTextMode || this.state.isEditing) &&
<Input style={selectStyle} type="select" onChange={this.onOptionChangedHandler} onClick={this.onSelectHandler} value={currentOption}>
<Input style={selectStyle} type="select" onChange={this.onOptionChanged} onClick={this.onSelectHandler} value={currentOption}>
{options.map((item, index) => {
return (
<option key={index} value={item}>{this.props.translateOption(item)}</option>

View File

@ -8,7 +8,7 @@ const propTypes = {
isEditIconShow: PropTypes.bool.isRequired,
permissions: PropTypes.array.isRequired,
currentPermission: PropTypes.string.isRequired,
onPermissionChangedHandler: PropTypes.func.isRequired
onPermissionChanged: PropTypes.func.isRequired
};
class SharePermissionEditor extends React.Component {
@ -24,7 +24,7 @@ class SharePermissionEditor extends React.Component {
isEditIconShow={this.props.isEditIconShow}
options={this.props.permissions}
currentOption={this.props.currentPermission}
onOptionChangedHandler={this.props.onPermissionChangedHandler}
onOptionChanged={this.props.onPermissionChanged}
translateOption={this.translatePermission}
/>
);

View File

@ -8,7 +8,7 @@ const propTypes = {
isEditIconShow: PropTypes.bool.isRequired,
permissions: PropTypes.array.isRequired,
currentPermission: PropTypes.string.isRequired,
onPermissionChangedHandler: PropTypes.func.isRequired
onPermissionChanged: PropTypes.func.isRequired
};
class WikiPermissionEditor extends React.Component {
@ -30,7 +30,7 @@ class WikiPermissionEditor extends React.Component {
isEditIconShow={this.props.isEditIconShow}
options={this.props.permissions}
currentOption={this.props.currentPermission}
onOptionChangedHandler={this.props.onPermissionChangedHandler}
onOptionChanged={this.props.onPermissionChanged}
translateOption={this.translatePermission}
/>
);

View File

@ -175,7 +175,7 @@ class WikiListItem extends Component {
isEditIconShow={this.state.showOpIcon}
currentPermission={this.state.permission}
permissions={this.permissions}
onPermissionChangedHandler={this.changePerm}
onPermissionChanged={this.changePerm}
/>
</td>
<td className="text-center cursor-pointer">

View File

@ -158,7 +158,7 @@ class Item extends Component {
isEditIconShow={this.state.showOpIcon}
currentPermission={this.state.share_permission}
permissions={this.permissions}
onPermissionChangedHandler={this.changePerm}
onPermissionChanged={this.changePerm}
/>
</td>
<td><a href="#" className={unshareIconClassName} title={gettext('Unshare')} onClick={this.unshare}></a></td>

View File

@ -178,7 +178,7 @@ class Item extends Component {
isEditIconShow={this.state.showOpIcon}
currentPermission={share_permission}
permissions={this.permissions}
onPermissionChangedHandler={this.changePerm}
onPermissionChanged={this.changePerm}
/>
</td>
<td><a href="#" className={unshareIconClassName} title={gettext('Unshare')} onClick={this.unshare}></a></td>