haiwen/seahub
1
0
Fork 0
mirror of https://github.com/haiwen/seahub.git synced 2025-09-03 16:10:26 +00:00
Code Issues Releases Wiki Activity

optimized function naming (#2824)

Browse Source
This commit is contained in:
杨顺强
2019-01-14 13:33:36 +08:00
committed by Daniel Pan
parent 2cdba5012a
commit 3d2e21eecd
10 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
frontend/src/components/select-editor/role-eidtor.js
View File

@@ -8,7 +8,7 @@ const propTypes = {
isEditIconShow: PropTypes.bool.isRequired,
roles: PropTypes.array.isRequired,
currentRole: PropTypes.string.isRequired,
onRoleChangedHandler: PropTypes.func.isRequired,
onRoleChanged: PropTypes.func.isRequired,
};
class RoleEditor extends React.Component {
@@ -30,7 +30,7 @@ class RoleEditor extends React.Component {
isEditIconShow={this.props.isEditIconShow}
options={this.props.roles}
currentOption={this.props.currentRole}
onOptionChangedHandler={this.props.onRoleChangedHandler}
onOptionChanged={this.props.onRoleChanged}
translateOption={this.translateRole}
/>
);

8
frontend/src/components/select-editor/select-editor.js
View File

@@ -9,7 +9,7 @@ const propTypes = {
options: PropTypes.array.isRequired,
currentOption: PropTypes.string.isRequired,
translateOption: PropTypes.func.isRequired,
onOptionChangedHandler: PropTypes.func.isRequired,
onOptionChanged: PropTypes.func.isRequired,
};
class SelectEditor extends React.Component {
@@ -34,11 +34,11 @@ class SelectEditor extends React.Component {
this.setState({isEditing: true});
}
onOptionChangedHandler = (e) => {
onOptionChanged = (e) => {
e.nativeEvent.stopImmediatePropagation();
let permission = e.target.value;
if (permission !== this.props.currentOption) {
this.props.onOptionChangedHandler(permission);
this.props.onOptionChanged(permission);
}
this.setState({isEditing: false});
}
@@ -66,7 +66,7 @@ class SelectEditor extends React.Component {
return (
<div className="permission-editor">
{(!isTextMode || this.state.isEditing) &&
<Input style={selectStyle} type="select" onChange={this.onOptionChangedHandler} onClick={this.onSelectHandler} value={currentOption}>
<Input style={selectStyle} type="select" onChange={this.onOptionChanged} onClick={this.onSelectHandler} value={currentOption}>
{options.map((item, index) => {
return (
<option key={index} value={item}>{this.props.translateOption(item)}</option>

4
frontend/src/components/select-editor/share-permission-editor.js
View File

@@ -8,7 +8,7 @@ const propTypes = {
isEditIconShow: PropTypes.bool.isRequired,
permissions: PropTypes.array.isRequired,
currentPermission: PropTypes.string.isRequired,
onPermissionChangedHandler: PropTypes.func.isRequired
onPermissionChanged: PropTypes.func.isRequired
};
class SharePermissionEditor extends React.Component {
@@ -24,7 +24,7 @@ class SharePermissionEditor extends React.Component {
isEditIconShow={this.props.isEditIconShow}
options={this.props.permissions}
currentOption={this.props.currentPermission}
onOptionChangedHandler={this.props.onPermissionChangedHandler}
onOptionChanged={this.props.onPermissionChanged}
translateOption={this.translatePermission}
/>
);

4
frontend/src/components/select-editor/wiki-permission-editor.js
View File

@@ -8,7 +8,7 @@ const propTypes = {
isEditIconShow: PropTypes.bool.isRequired,
permissions: PropTypes.array.isRequired,
currentPermission: PropTypes.string.isRequired,
onPermissionChangedHandler: PropTypes.func.isRequired
onPermissionChanged: PropTypes.func.isRequired
};
class WikiPermissionEditor extends React.Component {
@@ -30,7 +30,7 @@ class WikiPermissionEditor extends React.Component {
isEditIconShow={this.props.isEditIconShow}
options={this.props.permissions}
currentOption={this.props.currentPermission}
onOptionChangedHandler={this.props.onPermissionChangedHandler}
onOptionChanged={this.props.onPermissionChanged}
translateOption={this.translatePermission}
/>
);