Merge pull request #1240 from joshwget/enable-validate-script

Enable scripts/validate without golint

cmd/console/console.go

@@ -173,7 +173,7 @@ func writeRespawn() error {
 			p := path.Join("/etc/respawn.conf.d", f.Name())
 			content, err := ioutil.ReadFile(p)
 			if err != nil {
-				log.Error("Failed to read %s: %v", p, err)
+				log.Errorf("Failed to read %s: %v", p, err)
 				continue
 			}
 			respawn += fmt.Sprintf("\n%s", string(content))

cmd/switchconsole/switch_console.go

@@ -25,7 +25,7 @@ func Main() {
 	}
 
 	if newConsole != "default" {
-                project.ServiceConfigs.Add("console", &composeConfig.ServiceConfig{})
+		project.ServiceConfigs.Add("console", &composeConfig.ServiceConfig{})
 
 		if err = compose.LoadService(project, cfg, true, newConsole); err != nil {
 			log.Fatal(err)

config/config_test.go

@@ -202,12 +202,12 @@ func TestSet(t *testing.T) {
 }
 
 type OuterData struct {
-	One Data `"yaml:one"`
+	One Data `yaml:"one"`
 }
 
 type Data struct {
-	Two   bool `"yaml:two"`
-	Three bool `"yaml:three"`
+	Two   bool `yaml:"two"`
+	Three bool `yaml:"three"`
 }
 
 func TestMapMerge(t *testing.T) {

scripts/ci

@@ -5,7 +5,7 @@ cd $(dirname $0)
 
 ./build
 ./test
-#./validate
+./validate
 ./prepare
 ./package
 ./integration-test

scripts/validate

@@ -9,12 +9,12 @@ PACKAGES=". $(find -name '*.go' | xargs -I{} dirname {} |  cut -f2 -d/ | sort -u
 
 echo Running: go vet
 go vet ${PACKAGES}
-echo Running: golint
-for i in ${PACKAGES}; do
-    if [ -n "$(golint $i | grep -v 'should have comment.*or be unexported' | tee /dev/stderr)" ]; then
-        failed=true
-    fi
-done
+#echo Running: golint
+#for i in ${PACKAGES}; do
+#    if [ -n "$(golint $i | grep -v 'should have comment.*or be unexported' | tee /dev/stderr)" ]; then
+#        failed=true
+#    fi
+#done
 test -z "$failed"
 echo Running: go fmt
 test -z "$(go fmt ${PACKAGES} | tee /dev/stderr)"

tests/mounts_test.go

@@ -8,10 +8,10 @@ func (s *QemuSuite) TestMounts(c *C) {
 
 	s.CheckCall(c, "cat /home/rancher/test | grep test")
 
-        s.CheckCall(c, "mkdir -p /home/rancher/a /home/rancher/b /home/rancher/c")
-        s.CheckCall(c, "sudo mkfs.ext4 /dev/vdb")
-        s.CheckCall(c, "sudo cloud-init-execute")
-        s.CheckCall(c, "mount | grep /home/rancher/a")
-        s.CheckCall(c, "mount | grep /home/rancher/b")
-        s.CheckCall(c, "mount | grep /home/rancher/c")
+	s.CheckCall(c, "mkdir -p /home/rancher/a /home/rancher/b /home/rancher/c")
+	s.CheckCall(c, "sudo mkfs.ext4 /dev/vdb")
+	s.CheckCall(c, "sudo cloud-init-execute")
+	s.CheckCall(c, "mount | grep /home/rancher/a")
+	s.CheckCall(c, "mount | grep /home/rancher/b")
+	s.CheckCall(c, "mount | grep /home/rancher/c")
 }