github/kata-containers
1
0
Fork 1
mirror of https://github.com/kata-containers/kata-containers.git synced 2025-07-31 07:19:06 +00:00
Code Issues Projects Releases Wiki Activity

workflow: Revert "workflow: trigger test-kata-deploy with pull_request"

Browse Source 
This reverts commit 7676cde0c5.
It turns out that when triggerred from a PR, the docker login command is
failing with
```
Error: Cannot perform an interactive login from a non TTY device
```

Signed-off-by: Peng Tao <bergwolf@hyper.sh>
This commit is contained in:
Peng Tao 2022-10-09 11:48:06 +08:00
parent 2c88e1cd80
commit 102a9dda71
2 changed files with 7 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
.github/workflows/kata-deploy-test.yaml vendored
View File

@ -1,19 +1,11 @@
on:
pull_request: # this will trigger the workflow on PRs that changes release version
types:
- opened
- edited
- reopened
- synchronize
paths:
- VERSION
workflow_dispatch: # this allows to trigger the workflow manually on non-main branches
workflow_dispatch: # this is used to trigger the workflow on non-main branches
inputs:
pr:
description: 'PR number from the selected branch to test'
type: string
required: true
issue_comment: # this allows to trigger the workflow from main by commenting "/test_kata_deploy"
issue_comment:
types: [created, edited]
name: test-kata-deploy
@ -27,14 +19,13 @@ jobs:
&& github.event.action == 'created'
&& startsWith(github.event.comment.body, '/test_kata_deploy')
|| github.event_name == 'workflow_dispatch'
|| github.event_name == 'pull_request'
steps:
- name: Check membership on comment or dispatch
uses: kata-containers/is-organization-member@1.0.1
id: is_organization_member
with:
organization: kata-containers
username: ${{ github.event.comment.user.login || github.event.sender.login }} # first one applies only on issue_comment
username: ${{ github.event.comment.user.login || github.event.sender.login }}
token: ${{ secrets.GITHUB_TOKEN }}
- name: Fail if not member
run: |
@ -70,10 +61,8 @@ jobs:
run: |
if [ ${{ github.event_name }} == 'issue_comment' ]; then
ref=$(cat $GITHUB_EVENT_PATH | jq -r '.issue.pull_request.url' | sed 's#^.*\/pulls#refs\/pull#' | sed 's#$#\/merge#')
elif [ ${{ github.event_name }} == 'workflow_dispatch' ]; then
else # workflow_dispatch
ref="refs/pull/${{ github.event.inputs.pr }}/merge"
elif [ ${{ github.event_name }} == 'pull_request' ]; then
ref="refs/pull/${{ github.event.number }}/merge"
fi
echo "reference for PR: " ${ref} "event:" ${{ github.event_name }}
echo "##[set-output name=pr-ref;]${ref}"
@ -112,10 +101,8 @@ jobs:
run: |
if [ ${{ github.event_name }} == 'issue_comment' ]; then
ref=$(cat $GITHUB_EVENT_PATH | jq -r '.issue.pull_request.url' | sed 's#^.*\/pulls#refs\/pull#' | sed 's#$#\/merge#')
elif [ ${{ github.event_name }} == 'workflow_dispatch' ]; then
else # workflow_dispatch
ref="refs/pull/${{ github.event.inputs.pr }}/merge"
elif [ ${{ github.event_name }} == 'pull_request' ]; then
ref="refs/pull/${{ github.event.number }}/merge"
fi
echo "reference for PR: " ${ref} "event:" ${{ github.event_name }}
echo "##[set-output name=pr-ref;]${ref}"
@ -145,10 +132,8 @@ jobs:
run: |
if [ ${{ github.event_name }} == 'issue_comment' ]; then
ref=$(cat $GITHUB_EVENT_PATH | jq -r '.issue.pull_request.url' | sed 's#^.*\/pulls#refs\/pull#' | sed 's#$#\/merge#')
elif [ ${{ github.event_name }} == 'workflow_dispatch' ]; then
else # workflow_dispatch
ref="refs/pull/${{ github.event.inputs.pr }}/merge"
elif [ ${{ github.event_name }} == 'pull_request' ]; then
ref="refs/pull/${{ github.event.number }}/merge"
fi
echo "reference for PR: " ${ref} "event:" ${{ github.event_name }}
echo "##[set-output name=pr-ref;]${ref}"

2
docs/Release-Process.md
View File

@ -48,7 +48,7 @@
### Merge all bump version Pull requests
- The above step will create a GitHub pull request in the Kata projects. Trigger the CI using `/test` command on each bump Pull request.
- `test-kata-deploy` workflow should be triggered automatically, validate it passes under the `Actions` tab on the repository GitHub page (you're also able to run it manually from there).
- Trigger the `test-kata-deploy` workflow which is under the `Actions` tab on the repository GitHub page (make sure to select the correct branch and validate it passes).
- Check any failures and fix if needed.
- Work with the Kata approvers to verify that the CI works and the pull requests are merged.