github/kata-containers
1
0
Fork 2
mirror of https://github.com/kata-containers/kata-containers.git synced 2026-04-26 18:43:06 +00:00
Code Issues Projects Releases Wiki Activity

tools: Fix shellcheck issues in build-static-firecracker.sh

Browse Source 
Address shellcheck warnings including proper variable quoting,
use of [[ ]] over [ ], declaring and assigning variables separately,
and adding appropriate shellcheck disable directives where needed.

Signed-off-by: Fabiano Fidêncio <ffidencio@nvidia.com>
Made-with: Cursor
This commit is contained in:
Fabiano Fidêncio
2026-04-21 18:15:35 +02:00
parent a8d3cd72cd
commit 8360f9eef7
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tools/packaging/static-build/firecracker/build-static-firecracker.sh
View File

@@ -10,21 +10,24 @@ set -o pipefail
script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
# shellcheck source=/dev/null
source "${script_dir}/../../scripts/lib.sh"
# shellcheck disable=SC2034
config_dir="${script_dir}/../../scripts/"
firecracker_url="${firecracker_url:-}"
# shellcheck disable=SC2034
firecracker_dir="firecracker"
firecracker_version="${firecracker_version:-}"
arch=$(uname -m)
[ -n "$firecracker_url" ] ||firecracker_url=$(get_from_kata_deps ".assets.hypervisor.firecracker.url")
[ -n "$firecracker_url" ] || die "failed to get firecracker url"
[[ -n "${firecracker_url}" ]] ||firecracker_url=$(get_from_kata_deps ".assets.hypervisor.firecracker.url")
[[ -n "${firecracker_url}" ]] || die "failed to get firecracker url"
[ -n "$firecracker_version" ] || firecracker_version=$(get_from_kata_deps ".assets.hypervisor.firecracker.version")
[ -n "$firecracker_version" ] || die "failed to get firecracker version"
[[ -n "${firecracker_version}" ]] || firecracker_version=$(get_from_kata_deps ".assets.hypervisor.firecracker.version")
[[ -n "${firecracker_version}" ]] || die "failed to get firecracker version"
firecracker_tarball_url="${firecracker_url}/releases/download"
@@ -32,13 +35,13 @@ file_name="firecracker-${firecracker_version}-${arch}.tgz"
download_url="${firecracker_tarball_url}/${firecracker_version}/${file_name}"
info "Download firecracker version: ${firecracker_version} from ${download_url}"
curl -o ${file_name} -L $download_url
curl -o "${file_name}" -L "${download_url}"
sha256sum="${file_name}.sha256.txt"
sha256sum_url="${firecracker_tarball_url}/${firecracker_version}/${sha256sum}"
info "Download firecracker ${sha256sum} from ${sha256sum_url}"
curl -o ${sha256sum} -L $sha256sum_url
curl -o "${sha256sum}" -L "${sha256sum_url}"
sha256sum -c ${sha256sum}
tar zxvf ${file_name}
sha256sum -c "${sha256sum}"
tar zxvf "${file_name}"